Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp827057pxb; Wed, 15 Sep 2021 14:21:05 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxGPDHXlfSPaxR1q7kla6IQqljl5d7ky1j3q6p1cVl+Rnfzwx/NHRn9taU0UMc3iKfps3Dt X-Received: by 2002:a92:c24e:: with SMTP id k14mr987979ilo.197.1631740865162; Wed, 15 Sep 2021 14:21:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631740865; cv=none; d=google.com; s=arc-20160816; b=Co/52g5jZo3SL8nCAjgWdrG0j7az+HEZCc1WPs7SIKm9hNt6WuMDry4CfN8HWroDTM vc1PQQ8a1jA+pAQyKjj1rA86KmsVNH9TroDdLMgXXfzTdjOGDFU/SAN/DrF1FaSKByKV eWZyFCkrA0qj/uYNXdzYQ0PH/C/d97guYQwzNtg1dyp5xML5G31Z+JfYFqtlbiCEh2BW d8J/FfEvlGoSKWswOb45lZP0UqhmD3hTu1qpd4RFS5QP+BADYzmMpyhRaFRR2Dxo7V5u LrEuGOm6Nk7qUlqnOmvOI85gGynT2lH17G/kNLls5DuR3+RL+6r06VlFsUjKjWPbSLOr WLGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=w3BMwFy0chXS7YMqLdf36Rg6yUUlp6nBZba3YILPvA0=; b=hZlEXelqlefJR+R4oKw2k3qcWTm4mA6d0K+XxWJW3rYFSJbJM/6lLrcHoSG7DQJCZF PSiXJ8SW1cKURKbPkLDt49y26zIuuqHrLX0vNGuM0+NUOYqsOSbxuk4nRfxOVz5JMKu7 RZAMA42mdISydlqS5HI72yK7rvfsF5FnNhb83lIBwOJ/wnx8Js6eHsssKrTg+4+79zuX +DAkVo2ANM4G48yNhUh+BjHGq1izQfQtkvJCGXEKbXuCYgvKN1rc3r+9DFZICrbgDcf/ Lj7s2svxvB68Wh24jUW2byUJG3cywk9asqcvcOTEtvzlOJE8ac78Uxgm3bky7SdbSA+p EC3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WsNqD0Op; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h199si955887iof.50.2021.09.15.14.20.53; Wed, 15 Sep 2021 14:21:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WsNqD0Op; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232341AbhIOVVW (ORCPT + 99 others); Wed, 15 Sep 2021 17:21:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232173AbhIOVVU (ORCPT ); Wed, 15 Sep 2021 17:21:20 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26E26C061764 for ; Wed, 15 Sep 2021 14:20:01 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id x27so9800117lfu.5 for ; Wed, 15 Sep 2021 14:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w3BMwFy0chXS7YMqLdf36Rg6yUUlp6nBZba3YILPvA0=; b=WsNqD0Opa3lPgwayobITOeBYzY09REebVD84cTigbwiVy8RERoiSXisEu8y+Nk+bfI rwr6ffFTpZComKTqahfaOR7CdEVqoy7csTG2SKHpEYZNr9AVK2EZciaTVWrgEw6jv2ed w803wR6rUWc2E3pW5t7Ag7qcjFS9X02JepaeA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w3BMwFy0chXS7YMqLdf36Rg6yUUlp6nBZba3YILPvA0=; b=XLi4RMVuSgVbY6cdKauSFypkkYeCTtlmkglj4cmr/xOJ+uSW/8Va6NuBip9u0CuG3V AeSKKKKus0snqrGKtbBVrLhaqOaf1VuxIyAUt7w72e3iSOwNF15T+QNOzkatGwb+E89J ljxJR8SOfhEz2FU/vAX/b0UwtQGuBTB5tNbVhSS42VIUfuhCpFFAYfBuzopHAmp6HNTZ 6r+yPToWhZ4z66HXgqiMg+nR+ppSo3t0vOfDax0qShcX3uT7FxsajI3/T77WNemU678Q GP8/gBqQAg+qzNEyeuUvsJNEEtRad1H16FB7IKp28TZEzKcnwQyzRT+dG1KoeZBk/jsc 0T5w== X-Gm-Message-State: AOAM530Uc7S67vNIoHNAYnhw3REk7wJ6m8q5VzMn8hmPY5U5LFRa3OQH Gqq0JS9A+ja97/lTb4rtj2R2u2l7Ob4Vq8qg X-Received: by 2002:a05:6512:6c4:: with SMTP id u4mr1456031lff.284.1631740798987; Wed, 15 Sep 2021 14:19:58 -0700 (PDT) Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com. [209.85.167.43]) by smtp.gmail.com with ESMTPSA id y35sm116138lje.127.2021.09.15.14.19.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 14:19:57 -0700 (PDT) Received: by mail-lf1-f43.google.com with SMTP id i25so9822319lfg.6 for ; Wed, 15 Sep 2021 14:19:56 -0700 (PDT) X-Received: by 2002:a2e:bc1e:: with SMTP id b30mr1593765ljf.191.1631740795868; Wed, 15 Sep 2021 14:19:55 -0700 (PDT) MIME-Version: 1.0 References: <20210915035227.630204-1-linux@roeck-us.net> <47fcc9cc-7d2e-bc79-122b-8eccfe00d8f3@roeck-us.net> In-Reply-To: From: Linus Torvalds Date: Wed, 15 Sep 2021 14:19:39 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 0/4] Introduce and use absolute_pointer macro To: Guenter Roeck Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , "James E . J . Bottomley" , Helge Deller , "David S . Miller" , Jakub Kicinski , alpha , Geert Uytterhoeven , Linux Kernel Mailing List , linux-parisc@vger.kernel.org, Netdev , Sparse Mailing-list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 15, 2021 at 12:50 PM Linus Torvalds wrote: > > On Wed, Sep 15, 2021 at 12:47 PM Linus Torvalds > wrote: > > > > What other notable issues end up being still live? I sent out that one > > patch for sparc, but didn't get any response to it. I'm inclined to > > just apply it (the 'struct mdesc_hdr' pointer misuse one). > > Oh, I forgot about the qnx4 one. That happens on sparc, possibly > others, but not on x86-64. > > I'll go look at that patch too. Ok, I didn't love any of the patches I saw for the qnx4 problem, so I silenced that warning with a new patch of my own. Like the sparc64 case, the fix is to describe more extensively to the compiler what the code is actually doing. I think it ended up making it clearer what is going on to humans too. Although that may be the old "peeing in the snow" effect - it looks more understandable to me only because I spent so much time trying to understand what it does, and then wrote the fix based on that possibly flawed understanding. So of course I find it more understandable. Looking at the qnx4 code-base history, I don't think it has gotten any actual development outside of cleanups in the git history timeframe, which makes me suspect nobody uses this code. But hey, maybe it just works so well for the very specialized user base ... Anyway, I pushed it out. I have a clean "allmodconfig" build on all the architectures I tested, but I didn't test _that_ many. sparc64, arm64, powerpc64. Lots of dts warnings (which aren't fatal), though. Particularly for the powerpc64 build. Linus