Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <bad42db0-3552-df3e-8c40-a41b16f50088@amd.com>
Date:   Wed, 15 Sep 2021 17:58:00 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH 0/4] Fix stack usage of DML
Content-Language: en-US
To:     Harry Wentland <harry.wentland@amd.com>,
        amd-gfx@lists.freedesktop.org
Cc:     ndesaulniers@google.com, torvalds@linux-foundation.org,
        linux-kernel@vger.kernel.org, arnd@kernel.org,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, nathan@kernel.org, linux@roeck-us.net,
        llvm@lists.linux.dev
References: <20210909010023.29110-1-harry.wentland@amd.com>
From:   Leo Li <sunpeng.li@amd.com>
In-Reply-To: <20210909010023.29110-1-harry.wentland@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Z010VnNYM2Y5aG9Ea1NtMG5IS2JvRXF2YTdWTnYyam9IdzgrU0hoSjM3eXhk?=
 =?utf-8?B?WVN1Q29KQXBwY3VEZk1QN2dQKzIvMy96L3ovVlR6RjU1MFg1ajhYQ0YzdDZ4?=
 =?utf-8?B?am5GS0hwNWk4UW5rL00xYnNIZC93ODhSWTFVL1FFTFJleTFYY2gvNE5qRXBt?=
 =?utf-8?B?RXRZYm1QK04wSDRvRmNucGpMWXZ5Y20zSjJBS0s5V3hPYkNEdWVZeGRGc2Zj?=
 =?utf-8?B?QW1hQWlEa0pXelVNYWNMRGJXUlZFZGZWK21GSGl0ZUJ4TW4ycmd4eEZEK1hT?=
 =?utf-8?B?WDJQYzNtRjl1TCttZHA2Uk95aFRFSWoycDFleDlibElreENrZzRPRFhNbEs3?=
 =?utf-8?B?NW9odHNwRnRTakR6STA1YTl2SWkxTmlSS1c3eUE4Y09zNlF1djIyZjhmeWRH?=
 =?utf-8?B?RHVjVzlqamdkTlFQY3ZoRVRna2NRN3NKZjEzS055QUVxeG1OWE9iblJqSXVH?=
 =?utf-8?B?S0xxU1JaU0d0eHFvUEliTjBpSFpUbHZQQTgycVRpVFpoUUg1RnhsRytsOFpl?=
 =?utf-8?B?Y09HVVowZzlLUlZMK1lNUG1PMnF2WEdFUEpwSkhJOW1EalNOYkZyeEprV0cy?=
 =?utf-8?B?d25DMUhib3kzTHBlSkZoZEJOU2lOTEQyNWlFWHpRdWhvMzQram5uYnZjR3Zx?=
 =?utf-8?B?dmFYeHBkMi9OQit5anZDR3JXOWJBOGl1emdQRUIvc3o0cmQ2YmZtZk90NU1q?=
 =?utf-8?B?SjZpWUZZSVJLTmJSSDByUFdVR0ZpTUErUXdQSWFjNngxcllxcTN1QVJFdWtx?=
 =?utf-8?B?MnhCTFQxK1pBVEhEYlJGalMySk1SVHJZSnJtNnBPZ2k4OWM3ampwZU85Z2Zx?=
 =?utf-8?B?SENYUmd2RjI1Vko0dG9PUklFK2hzUGxtSTJoc1RVSHpvTzhUOXVpRGk1L2sr?=
 =?utf-8?B?WXYyWm5pTVhlT0hSa0xaaytxdkhpK0NtdTltS0V5dHVtNWI0dVFmN2xkWEVy?=
 =?utf-8?B?ZzRPV3p2MmFHZjV0cTZlZng0OGhWTkhEZXRmaFlKTFZqdkpEdWFsbHBXL1R2?=
 =?utf-8?B?UkEvVENmc2Nxb2tXV1JjR0xUSkFkRXpuN1lLSlBWM1FNRVNTS0t4VXFzYTJT?=
 =?utf-8?B?UDl1OVR5eTBWN2VZZWFnd05obHkrOVF3b0x5NDlsbmtqQmFCb3NzckY4MWtx?=
 =?utf-8?B?KzVHeWhPV0tCRHVKZmJCQ2pneGtaWlVhSTJMajduVUhZMHRCY1lKYmMyb0pv?=
 =?utf-8?B?Nkp1eGk1aVd4VGE3YnZxYWc5Q1hpTkpCRG5pWHUyOFY3Y21DS0lDbGRSMWNC?=
 =?utf-8?B?TCtYdFJFVk1aQUgwMFd2c2VXK3pZOXhqcW9HaWY4M3RHUEM0Zy9KMTM3bTVF?=
 =?utf-8?B?VWFZR0E2L1dlbDBucDZwR0tZK3ViOFBPUnNhUFkzdnl6d1Vvb2R4S0sraGFB?=
 =?utf-8?B?d3dUSUg0RXFDZ24xTk9JVlphNWt4cXpBQnlodGJ3aVhpdFc4RkhuSUI1VFox?=
 =?utf-8?B?cXgvczNYMUV2MDN5TUlvc1FKU3h6K282T3NFcWQwTUl1Yks1eFFUblBYMmhu?=
 =?utf-8?B?WU14UUgwREdVZklkLzB6MDlSRURCdW4yVDY3Yk5GTUd2V1RibUlFWlhGTkJV?=
 =?utf-8?B?azNPNzZJOEZRMXlSWW9yRE44WVoxRG05b2k1SWg1dTkxZ0FvYi9QQUtDYTNW?=
 =?utf-8?B?dkM5M0pVMlQ4S3BnYVdjMEFTTVF3SkpXZzJLUFNXYjUzNUpMOFUweG9QZzU1?=
 =?utf-8?B?U2ZEaFB5WmlTNDVDYzI2NFljNzVldHAxWXNjcVB3VVE0bUYzY2xMc0loS29X?=
 =?utf-8?Q?ZyQNwEUi3H5y0wIbln7IuW3PSysV1LG0K2AJlEV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c550bbad-2667-4acc-481c-08d97893e402
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5300.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 21:58:03.2039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SAQu+wvvbfim2tppXyh80NpOvTDq/lbSxAIfDOLZM/dJcFZ/dQ3fDaYWLlbI/yPB
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5266
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2021-09-08 21:00, Harry Wentland wrote:
> With the '-Werror' enablement patch the amdgpu build was failing
> on clang builds because a bunch of functions were blowing past
> the 1024 byte stack frame default. Due to this we also noticed
> that a lot of functions were passing large structs by value
> instead of by pointer.
> 
> This series attempts to fix this.
> 
> There is still one remaining function that blows the 1024 limit by 40 bytes:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dml/dcn21/display_mode_vba_21.c:3397:6:
>   
> error: stack frame size of 1064 bytes in function
> 'dml21_ModeSupportAndSystemConfigurationFull' [-Werror,-Wframe-larger-than=]
> 
> This will be a slightly more challenging fix but I'll see if we can get it
> below 1024 by breaking it into smaller functions.
> 
> With this series I can build amdgpu with CC=clang and a stack frame limit of
> 1064.
> 
> This series boots on a Radeon RX 5500 XT.
> 
> Harry Wentland (4):
>    drm/amd/display: Pass display_pipe_params_st as const in DML
>    drm/amd/display: Pass all structs in display_rq_dlg_helpers by pointer
>    drm/amd/display: Fix rest of pass-by-value structs in DML
>    drm/amd/display: Allocate structs needed by dcn_bw_calc_rq_dlg_ttu in
>      pipe_ctx

Series LGTM,

Reviewed-by: Leo Li <sunpeng.li@amd.com>

Thanks!

> 
>   .../gpu/drm/amd/display/dc/calcs/dcn_calcs.c  |  55 ++--
>   .../drm/amd/display/dc/dcn20/dcn20_resource.c |   2 +-
>   .../dc/dml/dcn20/display_rq_dlg_calc_20.c     | 158 +++++------
>   .../dc/dml/dcn20/display_rq_dlg_calc_20.h     |   4 +-
>   .../dc/dml/dcn20/display_rq_dlg_calc_20v2.c   | 156 +++++------
>   .../dc/dml/dcn20/display_rq_dlg_calc_20v2.h   |   4 +-
>   .../dc/dml/dcn21/display_rq_dlg_calc_21.c     | 156 +++++------
>   .../dc/dml/dcn21/display_rq_dlg_calc_21.h     |   4 +-
>   .../dc/dml/dcn30/display_rq_dlg_calc_30.c     | 132 ++++-----
>   .../dc/dml/dcn30/display_rq_dlg_calc_30.h     |   4 +-
>   .../dc/dml/dcn31/display_rq_dlg_calc_31.c     | 166 ++++++------
>   .../dc/dml/dcn31/display_rq_dlg_calc_31.h     |   4 +-
>   .../drm/amd/display/dc/dml/display_mode_lib.h |   4 +-
>   .../display/dc/dml/display_rq_dlg_helpers.c   | 256 +++++++++---------
>   .../display/dc/dml/display_rq_dlg_helpers.h   |  20 +-
>   .../display/dc/dml/dml1_display_rq_dlg_calc.c | 246 ++++++++---------
>   .../display/dc/dml/dml1_display_rq_dlg_calc.h |  10 +-
>   .../gpu/drm/amd/display/dc/inc/core_types.h   |   3 +
>   18 files changed, 695 insertions(+), 689 deletions(-)
>