Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v4] hugetlbfs: Extend the definition of hugepages
 parameter to support node allocation
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     zhenguo yao <yaozhenguo1@gmail.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     corbet@lwn.net, yaozhenguo@jd.com,
        Matthew Wilcox <willy@infradead.org>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        Linux Memory Management List <linux-mm@kvack.org>
References: <20210909141655.87821-1-yaozhenguo1@gmail.com>
 <20210914205001.7ccc7ef3dd76a9ec551b370e@linux-foundation.org>
 <CA+WzARmsPT46ck17-96cJVWE-=QEK8QobRFnCnEcNxsd42zNTw@mail.gmail.com>
 <c55f0be5-f68d-1a33-a9e4-5890a2887a15@oracle.com>
Message-ID: <cea19799-e516-4983-7e00-11f9542f05f4@oracle.com>
Date:   Wed, 15 Sep 2021 15:38:33 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
In-Reply-To: <c55f0be5-f68d-1a33-a9e4-5890a2887a15@oracle.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WkNZbWdqTkNISGkwMmZYMmRxT0NiNkpKOGk1KzEwaGw5RUl2NXBHZTBtNlhD?=
 =?utf-8?B?QW5BYUkyWW12OUFQL0dCcFRHOUVDNG5LbUZnaVZPS1ByVE5odklmWE1VNk0w?=
 =?utf-8?B?TEJadk5kTWNVOWhYd1JDZ0YxYXJ4eDcwRFpTY3d6YlVEMjByeFBNaDZRNUVa?=
 =?utf-8?B?NkdRcFlpakMyc29hSFNtdkdBRjc1cVRweWszRldZZjZBb2wxN0dwU3RyQkdD?=
 =?utf-8?B?V0szYmpjTHB4SXJlbmpLbnNzdEZCVjVKUllMMjZuRkNyakoyTW51dERqd2NI?=
 =?utf-8?B?dG5vcUNqbFBUVkgwYXBRYVNZY3lsc1F4N2V0MXBxUENodk11RUVrYzVvSVFy?=
 =?utf-8?B?OUZYYXZnYnVjeUlFV0ZQZm5mRm5Lc205dk13SmdldEVHajQrdTQyM2FwUkpZ?=
 =?utf-8?B?K2M1OGwzWXhTZ29CUEVIVFBnZUJVaVZGcm5vV1ZmK1JmOXNZNFd6UWtlQ0JZ?=
 =?utf-8?B?eTk0YjE1ZnBUOGFFRHpLbVYyOUp6T09CaEgvZ3RCbkVpZHQ3MWhBZmxTS2Vm?=
 =?utf-8?B?dU9OaTk3b1A1NWd1U2JPZnpzMSsyMzBvd0owWGlaKzRsVXRDRTJ0TEh2T1U3?=
 =?utf-8?B?VDhNejJkdzRrTXdPcmlmditlQTVxNWRjNytGaXdCUWdneW95TWFCaFh5Smsw?=
 =?utf-8?B?YlB1UVVCRE1EMWpNNm9aMHptcis5OUJPZ1AzVEI4cjFLekdoNmNmSGluSkkx?=
 =?utf-8?B?Wm9hZVVnSXJ5NGJSMWx6TVpqTmVCMHFqcFBKWFNhRjJMdmtUK0JSanZGODVu?=
 =?utf-8?B?NzB2M01UQjdTWVdTWFdFdmF4dXJRbUs0L2tvTEVuVmNNczVONUtzU1RYVU5h?=
 =?utf-8?B?aDBzNFRrdHd3a2JJZHRtUSs5MnpBdVRMMTk1b2FrWGUrZ2ErOEhaL1JXY1Rj?=
 =?utf-8?B?N0hUem5CUDBBZ2dUTWhCM21CU3NraUEzU2dIUWlIbzdtN1lLNHJ5Qjhpcy9N?=
 =?utf-8?B?b3FJd3NubXlXbTRoVDc1VFZvK0lVRTJTUmtZeXFNYzdYUDVjSlZ4dDJUNmp4?=
 =?utf-8?B?NWJkK0tlWGdjdTYwQlY1dUFBTzU2dC9ocjlMcnpTTEdGeFRSVkhkVzFiSVRu?=
 =?utf-8?B?UHhZRmcxbXljbVZTOGduVFFnZ205N0hPa0lZVFBEU0lBa0tSZUlNTEVjME5C?=
 =?utf-8?B?R0xHazBZcUdqUnV0QTgxcG80cHFIYk5lWlA5LzRLYWRJaklKU0hCYk8vOXVt?=
 =?utf-8?B?ZGdhUzBnblAycDlYd0VNVHZFbktrT2Z4NWJ4S2xNRTIwUUJnRjFyYlh1dStI?=
 =?utf-8?B?TXdJc1Q5QTVJZGxIZC9GWlFxLytDb3UrMDhsY2VoR1JhU3pLSWRJcmpocjhC?=
 =?utf-8?B?VENWS3VRZExBQmNTSzM1Z3MvS0tZdGVVbzNEWVdsU1hiU0N5and6eWE3bzJU?=
 =?utf-8?B?N1MrRCtVU2xWYTd6WUh2Nmd1dDhScEUrQ2VxT2ZWQ3ZOZWhCeEhROVppZmht?=
 =?utf-8?B?YVJDL24vbmQwTjIvN1B6RXhMVVFHcmRoOWE5cVhIckZ0cDV2RU1OTk83aEM4?=
 =?utf-8?B?NyswdU1VOFRNWGQxL29pWFZhZWxhdGdyUHhqbTdsTTFpV0VMN21jUEpHeVpQ?=
 =?utf-8?B?b0ZYRHBqVlB1WVNGdVpBa1NhZlAxSk83S3BMb21wS1dHZk9kTVdORVYzN2Z2?=
 =?utf-8?B?OWpac1JEbW4ySHBFV2dOSldDNDlSUndyR1Q1Y2huM3dtUUREMnY1eEdSWVZa?=
 =?utf-8?B?MFpiYlZ0WWJVSC9XeU5pcjJQM2x3WmJ2cTZVelJ4KzE0WmV3RlFpbm1KbXlk?=
 =?utf-8?Q?y5rJcBm6ToG1pFxH/76j6xr+21yNst2cpzNkqe6?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 208bc3bc-a12d-4ebd-0fc7-08d978998d96
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 22:38:35.1751
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Xcanp1jXCnHERwII3NG5St0ApF71gcj7huN91/sKCbgaBMqOy9H324t1BAiD8cMxj9ge7+oLauJiVcgpIZgn+Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3352
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10108 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109150128
X-Proofpoint-GUID: BNAjAEOvg4YUanf95RTi76tJAmXNuDMl
X-Proofpoint-ORIG-GUID: BNAjAEOvg4YUanf95RTi76tJAmXNuDMl
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/15/21 3:03 PM, Mike Kravetz wrote:
> On 9/15/21 6:11 AM, zhenguo yao wrote:
>> Andrew Morton <akpm@linux-foundation.org> 于2021年9月15日周三 上午11:50写道：
>>>
>>> On Thu,  9 Sep 2021 22:16:55 +0800 yaozhenguo <yaozhenguo1@gmail.com> wrote:
>>>
>>>> +static void __init hugetlb_hstate_alloc_pages_onenode(struct hstate *h, int nid)
>>>> +{
>>>> +     unsigned long i;
>>>> +     char buf[32];
>>>> +
>>>> +     for (i = 0; i < h->max_huge_pages_node[nid]; ++i) {
>>>> +             if (hstate_is_gigantic(h)) {
>>>> +                     struct huge_bootmem_page *m;
>>>> +                     void *addr;
>>>> +
>>>> +                     addr = memblock_alloc_try_nid_raw(
>>>> +                                     huge_page_size(h), huge_page_size(h),
>>>> +                                     0, MEMBLOCK_ALLOC_ACCESSIBLE, nid);
>>>> +                     if (!addr)
>>>> +                             break;
>>>> +                     m = addr;
>>>> +                     BUG_ON(!IS_ALIGNED(virt_to_phys(m), huge_page_size(h)));
>>>
>>> We try very hard to avoid adding BUG calls.  Is there any way in which
>>> this code can emit a WARNing then permit the kernel to keep operating?
>>>
>> Maybe we can rewrite it as below:
>>                         if (WARN(!IS_ALIGNED(virt_to_phys(m),
>> huge_page_size(h)),
>>                                 "HugeTLB: page addr:%p is not aligned\n", m))
>>                                 break;
>> @Mike,  Do you think it's OK?
> 
> Sorry, I have not yet reviewed the latest version of this patch.
> Quick thought on this question.
> 
> The required alignment passed to memblock_alloc_try_nid_raw() is
> huge_page_size(h).  Therefore, we know the virtual address m is
> huge_page_size(h) aligned.  The BUG is just checking to make sure
> the physical address associated with the virtual address is aligned
> the same.  I really do not see how this could not be the case.
> In fact, the memblock allocator finds a physical address with the
> required alignment and then returns phys_to_virt(alloc).
> Someone please correct me if I am wrong.  Otherwise, we can drop
> the BUG.
> Adding Mike Rapport on Cc:
> 
> This allocation code and the associated BUG was copied from
> __alloc_bootmem_huge_page().  The BUG was added 12 years ago before
> the memblock allocator existed and we were using the bootmem allocator.
> If there is no need for a BUG in hugetlb_hstate_alloc_pages_onenode,
> there is no need for one in __alloc_bootmem_huge_page.

One additional thought.

Architectures can provide their own version of alloc_bootmem_huge_page.
powerpc is the only architecture doing so today.  If an architecture
does provide their own version of alloc_bootmem_huge_page, I do not
think we should/can use hugetlb_hstate_alloc_pages_onenode to allocate
node specific gigantic huge pages.

I think we need to disable this feature for such architectures,
-OR-
provide some method to do architecture specific node allocations of
gigantic pages.
-- 
Mike Kravetz