Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
To:     x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Tony Luck <tony.luck@intel.com>, "H . Peter Anvin" <hpa@zytor.com>,
        yazen.ghannam@amd.com, Smita.KoralahalliChannabasappa@amd.com
Subject: [PATCH 0/5] x86/mce: Handle error simulation failures in mce-inject module
Date:   Wed, 15 Sep 2021 18:27:34 -0500
Message-Id: <20210915232739.6367-1-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C0uTmGwegp7lUNfVC31rIdenzPEjHwErZnRk9UWzFXUP0NvLdysFwEia6ayK?=
 =?us-ascii?Q?0VIOr0ygnnNTjuYyo8rI9rDUAx3bHK5wIdJHT78w2pWDzqgbdX4q8Z/Pg+z+?=
 =?us-ascii?Q?nyE3hdKMTCKGbzCObD+8LV74jUfji3kWKG+u8QJVSBVLXyllRnVkNuukecV9?=
 =?us-ascii?Q?ivL6yNKAqZFYpdmdNe6N0Lw+L3ezDQ7/PW8eAE6V8FQ7dobqeQv5U7Jfw+zJ?=
 =?us-ascii?Q?60IqoKR1yrr6iV/UwqTkDe6g4M7hV3fPxMuogisiwOmDrd//OCcaptWfm9K6?=
 =?us-ascii?Q?Rfun+HZg3L9O81b+aW4ebkNew9KVgPPxwioRbKPQGnuyI1GvNYtf8rdoK47r?=
 =?us-ascii?Q?mySFTMbNCtqp7cnjJmda6YyEo4CxKHJGVAgEVgE88sW4WQ1imtVyzUV3tGdN?=
 =?us-ascii?Q?WYnP0UKg0ii60ccrmqq2vzHatV/TbUMNkHl9w5xkLrreW3Gk/BSnDrUHHE/z?=
 =?us-ascii?Q?lx2Gbtjx6HuYuu9UCv8ON6UyguL0FArMwXUKXT5Pp1hIaG8+grXbOhQIbx8o?=
 =?us-ascii?Q?l0LOOtZ8KwvPrY7q7LgXS4D4BpwNkGjtDqW4vVpJw+DGgvLQXLI5iLUemrjL?=
 =?us-ascii?Q?PxosQZVCMHnD4x4whTPevCBK8p7FQkJkll1w3DL0rFE7d7orIFvtyARmmWdN?=
 =?us-ascii?Q?C3z0M136KIbgHigYtIHr+363nZRjEW8+KNRCi+4D9mtn0ZPzLMmvU6hH1Tsl?=
 =?us-ascii?Q?YXKy1/5zCZQzLFpjwTXn3L+mxLHYNNy0AYaKYOfM9cVdldEtaQ5JCKl7PRdt?=
 =?us-ascii?Q?hnhCVHExV3aoGGxDPGBIDjXpMMUeCkVh2DVGG/nXLHopAqEiqA9xvwq4pkBu?=
 =?us-ascii?Q?qdZ271v6BUUESQYY03s6IHxh8H39WmoBJqyHXYOwB+56aq43j9BmxSUvxhzt?=
 =?us-ascii?Q?nUgAbUwfwhFfnIwOYU7rtw62tvB4g8++yXqueGMN6PmCzoUrzY93UJ58EB0g?=
 =?us-ascii?Q?lj4wWvDmUNc6RHYHAKr1HUTxIoAut31DhpcbVx/MSkoXRvAWEurAeSAQXWqK?=
 =?us-ascii?Q?UtCJKNWtuyXOMAxeDQytvXAPL1M9riuMlLt3ZXifJqITUDdJhmagoNtYFk7j?=
 =?us-ascii?Q?VRdQG9rfAUWyHKwHVSvrpDRvna9CnymQ/UJdxYa3ILyOSYvjDTpuJwmx7kaF?=
 =?us-ascii?Q?jqBF3qWsgDibWyNqCT0a9ZJSbxR95V5pdMIOBE3qhz2I/v5mEu+Ahd4g2x3T?=
 =?us-ascii?Q?m59EG8XWuqFhXXcRsZbi/UQtUkFMwzXXS5oIk8u9H7/ND/tt0brrARXHKpfU?=
 =?us-ascii?Q?5rS8I26eY2pR9TzVxKvWcpgHyxPAPo0GSTkcvC41l0xeMHRJdI6VQImMZWI1?=
 =?us-ascii?Q?f9PSxtZfc3EhUjIgltHRyIhW?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 094285d3-9e38-418d-2990-08d978a07d6e
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 23:28:15.0454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: j9+P+1urjywTKtPoAVe0zxNQ5eXMqOBCN1hKWu0RAMp1f6GgNswVwPus/TH6IL+7u1XQGXrsxJL5ay9VhPduCA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4512
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This series of patches handles the scenarios where error simulation
fails silently on mce-inject module. It also cleans up the code by
replacing MCx_{STATUS, ADDR, MISC} macros with msr_ops and finally returns
error code to userspace on failures injecting the module.

Error simulation fails if the bank is unpopulated (MCA_IPID register reads
zero) or if the platform enforces write ignored behavior on status
registers.

The first patch checks for an unpopulated bank by reading the value out
from MCA_IPID register and the fourth patch checks for writes ignored from
MCA_STATUS and MCA_DESTAT.

The second patch sets valid bit before doing error injection.

The third patch does some cleanup by replacing MCx_{STATUS, ADDR, MISC}
macros with msr_ops.

The final patch returns error code to userspace from mce-inject module.

Smita Koralahalli (5):
  x86/mce/inject: Check if a bank is unpopulated before error simulation
  x86/mce/inject: Set the valid bit in MCA_STATUS before error injection
  x86/mce: Use msr_ops in prepare_msrs()
  x86/mce/inject: Check for writes ignored in status registers
  x86/mce/mce-inject: Return error code to userspace from mce-inject
    module

 arch/x86/kernel/cpu/mce/core.c   |  1 +
 arch/x86/kernel/cpu/mce/inject.c | 80 ++++++++++++++++++++++++--------
 2 files changed, 62 insertions(+), 19 deletions(-)

-- 
2.17.1