Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
To:     x86@kernel.org, linux-edac@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     Tony Luck <tony.luck@intel.com>, "H . Peter Anvin" <hpa@zytor.com>,
        yazen.ghannam@amd.com, Smita.KoralahalliChannabasappa@amd.com
Subject: [PATCH 5/5] x86/mce/mce-inject: Return error code to userspace from mce-inject module
Date:   Wed, 15 Sep 2021 18:27:39 -0500
Message-Id: <20210915232739.6367-6-Smita.KoralahalliChannabasappa@amd.com>
In-Reply-To: <20210915232739.6367-1-Smita.KoralahalliChannabasappa@amd.com>
References: <20210915232739.6367-1-Smita.KoralahalliChannabasappa@amd.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?DdOsrQ/sPozEPdvCxoudWwLim6bzc3VSRSDo25mIo08rh7vxq9kaJ9f6BkVW?=
 =?us-ascii?Q?mXe5OdrJAxRui2OCXCIxOd8P/72xtcQ4NxNDHZ9PmGEUD5/J3eyzjZjI0sL7?=
 =?us-ascii?Q?6ZnMUdygvBAPbEd+D3csPTh3kBCLfdh+IExL8+bQqE4mVvJImItcDTJbg06C?=
 =?us-ascii?Q?hQCN1ZEIkDZf0EawTPETb9tYzgAl0Rc0IJ8oeiw3ghJu0kNTUKx3PT078hcj?=
 =?us-ascii?Q?5xzyzezn4CmIDjlygSjMA5CjoFfyVkTi82OJTv4tjFVFEB+BWFPRb4utDz7g?=
 =?us-ascii?Q?O6988LOB22PzLPVh/W1si21FKjLDlgeyRZyAES/oA/i1s1EcNrcJf+8elO50?=
 =?us-ascii?Q?obcEvKfq4MxEmiAx1dtMiOpoT54m3oGjMocZjSLZY0KFD3xa3DUfq0UVONmK?=
 =?us-ascii?Q?PwMjUUbKC7DPlpyGIh4Q+LP80kj4FMpnqq+LzzJ2Rxff0G8SWzvzHSfG3RuA?=
 =?us-ascii?Q?rLvC9Yo4GACmGPY/ZryKu4fyxNdYcDlWjnrFGC0WAFltHl+oeSXlgoi8RTaS?=
 =?us-ascii?Q?6WoaQTIX6iGR4Curr4OLpzR03/8md6pfyENQAs19PUu5ZMwP/FzmdfJqsRI8?=
 =?us-ascii?Q?SkkDgjF2wQnJcPUWa62wc2IGmdCV/cwQ6dDf/Pk6/MHOdZJs8OBYfdE4AOBx?=
 =?us-ascii?Q?rSQEWhnTKKBhtP6g2EUM1mX7f5ZtO60HW7cwJeAWlETUTtLU4AEDOi2pYaMs?=
 =?us-ascii?Q?O7oPFme04zl6guwuwJ9FJjvsE3NT97WQ919oobnuT1jfYLs5VShP33ohISiF?=
 =?us-ascii?Q?KEQTi+YJbJYZprtzxqlnA+77lS6QqBCD4E9i0VtYQMFKRCseVhPIO8f2znpK?=
 =?us-ascii?Q?2y4ArqaHjXfSarfeg/HT9XmgHN0HnSZzS2KPzyJy4njdovAhdDuaKn4ka+iF?=
 =?us-ascii?Q?bHew1wuju3YbG22anBxrLfKJyu6LGrnf1040bO+Z/RK582hVgMF8ruefHWmu?=
 =?us-ascii?Q?eN2ue/STJyYpIJbmDifIPjc0WrKFu8DscOF8MHu9KTY8TaKieDP1Phba9ANj?=
 =?us-ascii?Q?uH3zDsPjv0SczqA5NwrDccLpfPSQ1ZnlA46d1FBwjZ+9P44i3EqKA25WFrz/?=
 =?us-ascii?Q?TBHAhESCX48SETTkwh7piFtNgytQod7d29KuiW+pJkJHC3tyl7TR9B8EO96b?=
 =?us-ascii?Q?VCbAyE8Z1roExcXAO20dHqcAnMdNHKm2acVsx+PAl2wgSb74HjlryBSam8eG?=
 =?us-ascii?Q?NKvz6iOLmZ7ESA9hLVspw12ULK2rtYjE2wyoHSS4HOwBp2MBGi0aQo6JxrZk?=
 =?us-ascii?Q?04DfvclZS5iz5cDpiRVEDpcvmD9C5mRqvtarW5RrtPEJzTQwW8RUyqIfkwvd?=
 =?us-ascii?Q?MB+MV1aqslwBKJnJkLqKbGbG?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 84436643-b4a0-4cdc-9b4a-08d978a086e6
X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2685.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 23:28:30.4595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Zd778/8LpXh7llUhiHKPCfOJZ9Fgo5FTCjSbHTe5ZMt2Ut7JSbIwV/QYinoTJ9LeK8TliitL1Ywx2ZOXbH5vmg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4512
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Currently, the mce-inject module fails silently and user must look for
kernel logs to determine if the injection has succeeded.

Save time for the user and return error code from the module if error
injection fails.

Signed-off-by: Smita Koralahalli <Smita.KoralahalliChannabasappa@amd.com>
---
 arch/x86/kernel/cpu/mce/inject.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/x86/kernel/cpu/mce/inject.c b/arch/x86/kernel/cpu/mce/inject.c
index c7d1564f244b..0ef9ff921c6a 100644
--- a/arch/x86/kernel/cpu/mce/inject.c
+++ b/arch/x86/kernel/cpu/mce/inject.c
@@ -549,8 +549,10 @@ static void do_inject(void)
 	}
 
 	cpus_read_lock();
-	if (!cpu_online(cpu))
+	if (!cpu_online(cpu)) {
+		mce_err.err = -ENODEV;
 		goto err;
+	}
 
 	toggle_hw_mce_inject(cpu, true);
 
@@ -622,7 +624,7 @@ static int inj_bank_set(void *data, u64 val)
 	/* Reset injection struct */
 	setup_inj_struct(&i_mce);
 
-	return 0;
+	return mce_err.err;
 }
 
 MCE_INJECT_GET(bank);
-- 
2.17.1