Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210903182839.1.I20856983f2841b78936134dcf9cdf6ecafe632b9@changeid>
 <CA+ASDXPC7M-5zYms=bop6=qnWigKHm_P+8ErzfqwFEc91LRV4Q@mail.gmail.com>
In-Reply-To: <CA+ASDXPC7M-5zYms=bop6=qnWigKHm_P+8ErzfqwFEc91LRV4Q@mail.gmail.com>
From:   Brian Norris <briannorris@chromium.org>
Date:   Wed, 15 Sep 2021 16:52:42 -0700
Message-ID: <CA+ASDXPhJGNdS-f+r+haLgAQqmBrF6u9rzcmVZ3pgh9UHxU5zQ@mail.gmail.com>
Subject: Re: [PATCH] coresight: cpu-debug: control default behavior via Kconfig
To:     Leo Yan <leo.yan@linaro.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>,
        Mike Leach <mike.leach@linaro.org>,
        Suzuki K Poulose <suzuki.poulose@arm.com>
Cc:     coresight@lists.linaro.org,
        Linux Kernel <linux-kernel@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Sep 15, 2021 at 4:41 PM Brian Norris <briannorris@chromium.org> wrote:
>
> On Fri, Sep 3, 2021 at 6:29 PM Brian Norris <briannorris@chromium.org> wrote:
> > --- a/drivers/hwtracing/coresight/Kconfig
> > +++ b/drivers/hwtracing/coresight/Kconfig
> > @@ -150,6 +150,19 @@ config CORESIGHT_CPU_DEBUG
>
> > +config CORESIGHT_CPU_DEBUG_DEFAULT_ON
> > +       bool "Enable CoreSight CPU Debug by default
>
> ^^ Eek, I failed to terminate this string, and kbuild is even warning about it:
>
> drivers/hwtracing/coresight/Kconfig:145:warning: multi-line strings
> not supported
>
> Sorry about that; I can submit a v2 if you'd like, or feel free to fix
> up my mistake when you apply it.

And I see you already fixed it -- should've checked before posting:

https://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git/commit/?id=616ac6902c982f03da9d0b1e4f845df0980d055d
[Fixed missing double quote in Kconfig title]

Thanks,
Brian