Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1023112pxb; Wed, 15 Sep 2021 20:10:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPNBjSo1s1iMeEplcA33av7RIgm13d9EetiBFwXb3fo0Ocg2zzt1sl4t5+SRj8bVqK9/Cf X-Received: by 2002:a6b:2c14:: with SMTP id s20mr2638920ios.218.1631761812602; Wed, 15 Sep 2021 20:10:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631761812; cv=none; d=google.com; s=arc-20160816; b=Q3agPH8d7H+qINWU0zKHDl0+AsBQOM8eTw2JL2hfT32JpmzkdYcIaJh8ZM9l+zcUyO b4dYvtWEH10D/I329HDrWBPBlFTS5qsU81U6PWP0AmkFMkC98VToLMlzhBmXVC2GNovG dzbBFgZ3og7TklW7bBDYGyr1RlWTdmRAB2wqQQhFYeRRN0YVm45aL1LHNhAC1X6IvpDB iU8bHMBj9nYrYXFJErUJTMbQgFyFxUCnJ/QIZors7JIGT4lEC3bLW+2nSz4zeyl5vOd1 kC17CxgWx/4dOf0+gBRpdWIoLFlkfbxufXaD9mbyBvk3aU2lPBE7SfjIJ7g6ozixm70m b3IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=50xIwsoASPHNPWZgjUgWDYviRzneCzm3F1Lmsrs0Ux0=; b=FiTtfEx8VYlyUWtmfZCnUYwS1WT+0XpUNUYLmYKzlGfV4h63lNNH1EbrRLp6VkjDvI /xqBSnpsos4Njav4P6IKFyiobVV5PIhJECdFi+hkVatjeYGewp/aJEEl3amxWGlp8blc f//CZY3jHf0tsou/PhPoOMdHB1K+BMgeHt/8RyQFqNPDkNP9n8X53gD5XOPfrBuTp0YL arGsQaQCtW3YgEORCTXWCrLkYPk3KoK30EigJN3zGEyo4SvPOUGCLCtXad5/k/dPcWEJ kvBQMG1AdS8G22MF90jAIVyPHwrtbmVzu3V+UMjo2rEoAYAoAAMOgVWFMCoCpvf+7C5+ RAZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v189si1597377iof.75.2021.09.15.20.10.00; Wed, 15 Sep 2021 20:10:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234109AbhIPDJe (ORCPT + 99 others); Wed, 15 Sep 2021 23:09:34 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:9737 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234059AbhIPDJ3 (ORCPT ); Wed, 15 Sep 2021 23:09:29 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4H927D2h7ZzW2LP; Thu, 16 Sep 2021 11:07:04 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 11:08:06 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 11:08:05 +0800 From: Yang Yingliang To: , CC: , Subject: [PATCH v2] usb: host: ohci-tmio: check return value after calling platform_get_resource() Date: Thu, 16 Sep 2021 11:13:17 +0800 Message-ID: <20210916031317.2871282-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It will cause null-ptr-deref if platform_get_resource() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang --- drivers/usb/host/ohci-tmio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/host/ohci-tmio.c b/drivers/usb/host/ohci-tmio.c index 08ec2ab0d95a..3f3d62dc0674 100644 --- a/drivers/usb/host/ohci-tmio.c +++ b/drivers/usb/host/ohci-tmio.c @@ -199,7 +199,7 @@ static int ohci_hcd_tmio_drv_probe(struct platform_device *dev) if (usb_disabled()) return -ENODEV; - if (!cell) + if (!cell || !regs || !config || !sram) return -EINVAL; if (irq < 0) -- 2.25.1