Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
To:     "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@amd.com>,
        Jiri Kosina <jikos@kernel.org>,
        Evgeny Novikov <novikov@ispras.ru>
Cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org>,
        "Natikar, Basavaraj" <Basavaraj.Natikar@amd.com>
References: <20210601163801.17848-1-novikov@ispras.ru>
 <nycvar.YFH.7.76.2109151657580.15944@cbobk.fhfr.pm>
 <BN9PR12MB505242B95EA964CF0990C006A0DB9@BN9PR12MB5052.namprd12.prod.outlook.com>
From:   Basavaraj Natikar <bnatikar@amd.com>
Message-ID: <9597d27e-6df2-03c3-57fe-e77f0b044d4b@amd.com>
Date:   Thu, 16 Sep 2021 11:29:32 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <BN9PR12MB505242B95EA964CF0990C006A0DB9@BN9PR12MB5052.namprd12.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dXNrcEhlMVVicUhLbU1ZOWZGRENCSHhWWm42Y2R0dFZlQ2U5b2dlZlBFTStS?=
 =?utf-8?B?SHdWV3p2N1VLYmxpcEMzLzZveTFWN09FSW5UckxrMlZxWXJFbC9lbGtySUlB?=
 =?utf-8?B?dGc0c3JpdEZ3eDJEWEt0SDUvUzdhMkw5RnZTRlBDUy9QdWlab3M4UVE1N2dI?=
 =?utf-8?B?R0FnQVVaZndXSTZrMVg4aVJtWGFENUhuS0FMaE10MEZPRkJHZmJEVTZIeGNp?=
 =?utf-8?B?SlkwUVFrdnRQZEV5cm9rVXp4WE1SejhaTFVMQWtMU3V5N291OW1xRUpMZjA0?=
 =?utf-8?B?cEhHd0RzcmNwaHFUcS9oeTNyeWZGU0FDRVhFZXhQTC9ETHlCOUI5bkQydHlG?=
 =?utf-8?B?N0ttT2hOZHpIZHdTT21WM0NTRGptNVhDSUFzZndTR2Rma0JlZ1ZwVi9uaExn?=
 =?utf-8?B?V3BDbVlLVWZGemY1L2JyVEwwY3pLODJxUUtyZ0F6NFZ4ZFRKVGF4YU5zWGU1?=
 =?utf-8?B?a2U3MUdGNDBscThTRmF5eEFuMXFiVjIyUk1qMFJod3dMZUVUSXdDU0FIVHVB?=
 =?utf-8?B?SmV1b25Cdkc4RyszaFN6Nmg3TmhUOXJVYWYvWEdPMFpNWWV0ZC9vS21uTlMr?=
 =?utf-8?B?TGNQOGNKNWlUYldiellRMWhTVWh6VE9pb3dOdktMb2xHNno3TDNqdWhHeVpa?=
 =?utf-8?B?S2taZ2xmTjliNUx4TUc2SlNObW9FVWQzVGpDWEJ5cDVTbnUvWXFQNzJNMnYv?=
 =?utf-8?B?czF6QWlyRUJQbGxsbDZlUXJTZG12anZ2ejdOL2Nqa1BTREpxNEkxaVF3Zml1?=
 =?utf-8?B?Tkg1Z2tnZ0JpL1pETkhRN3o3ampZZC9lZDdtUmROZVZWTHQ1amw5WUFJTU5M?=
 =?utf-8?B?OWxLNUVaYUhkcm1TM2JUazh1T0YwSFR3MmpJNnVkRnppMEdYbTR2K2VaMENW?=
 =?utf-8?B?WUlVSkdWMUc0QmYybUxpQ2lhRE82YlVMNmVKQXZ5MGs0NzBCNFlUOVZVZ3FH?=
 =?utf-8?B?enNNTjFPb2ZFUzlCSko5N3hRTkd1U3QrVVdzYkhjVTF6R21CNG9hbTAySG5I?=
 =?utf-8?B?MThzWkNDMzBTc3FseVNvczdqSUQ3ZWxDS3l6Y2dremc2T2NSdXBkOWxLdG5R?=
 =?utf-8?B?OHpSWktYZ1FWd1NlY2d4eXdCczYzVlNFdXErV3F2TUI0WlpPKy9yejZVdFkr?=
 =?utf-8?B?UEFyL0JSaDROLzNYV1FQY3pqZW1xSTdxcmc1cHpYdm5RVkVFdDRrWW13SSt2?=
 =?utf-8?B?SWRMUUtqVndabkVyWWhkMjBocXdsQzdDWGhiZE9ENm5ES3djd1RhQUM0TVJ6?=
 =?utf-8?B?WDhBK2xOQUFrQzBhdUF4R1Y3QzZmdnZ3U1pmRVlaaTR0RU1JWWcvRWg5QzM1?=
 =?utf-8?B?WWY4VDQ1UlhQWWVyVERwSXBSeG11bUx4VDlDZWVFRGtPdzNnNEVpbGxVNnZP?=
 =?utf-8?B?dGRuRndGUVlVOVhKSDhlNzcrRXh0WTB1T1N2ZjFNdlY3SEZFeHREZGl6WDYz?=
 =?utf-8?B?WXJ0OHR0ZXFmZUE2d3g4RVQvcmhML2Qwb3ZKOUhUYVA3ei92RFRPa2hXRTJ2?=
 =?utf-8?B?S2xnQ1FsUmpia1d2ZTBLL1QwQmFDMmg1OFcyTXBZK1FxWmcvSmJjRFZlRy9w?=
 =?utf-8?B?QUorNy8vRHhiRTVOQ1BBWkhpMjBmRzJDTHgyZmRNbFY5c0ovKzkvOFByKzNr?=
 =?utf-8?B?SjNzOWtRT3BUaEpwNENWL2FEeG1iZy9tZFY3VjRyNFBFaFlnTG9hMEdYbksr?=
 =?utf-8?B?cmJQWWQreXI1eFA3MldVbU5RTFFqUVRKS1RkbWlRejdnZDVFV2Vxd3pxdDVw?=
 =?utf-8?Q?tiOtL8iDDc8hw2/7vaR0DeEM+cIMQKqQxkhXn3W?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ced68b7d-06e3-4e68-f2b7-08d978d72f6d
X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5040.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 05:59:46.1728
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VjEhdFl12YAGPBrt8smK7dE6K+p2CF1mzoF/xqX1UsCKyU+zy00o0sCwHb2bEv8eV+96DyTLJiJ55JK6V3nf7g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB5565
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/15/2021 11:02 PM, Shah, Nehal-bakulchandra wrote:
> Adding Basavaraj
>
> -----Original Message-----
> From: Jiri Kosina <jikos@kernel.org> 
> Sent: Wednesday, September 15, 2021 8:28 PM
> To: Evgeny Novikov <novikov@ispras.ru>
> Cc: Shah, Nehal-bakulchandra <Nehal-bakulchandra.Shah@amd.com>; Sandeep Singh <sandeep.singh@amd.com>; Benjamin Tissoires <benjamin.tissoires@redhat.com>; linux-input@vger.kernel.org; linux-kernel@vger.kernel.org; ldv-project@linuxtesting.org
> Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
>
> On Tue, 1 Jun 2021, Evgeny Novikov wrote:
>
>> devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at 
>> registration that will cause NULL pointer dereference since 
>> corresponding data is not initialized yet. The patch moves 
>> initialization of data before devm_add_action_or_reset().
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
> Nehal, Basavaraj, could you please Review/Ack this one?
>
Patch looks good to me. Acked-by: Basavaraj Natikar <Basavaraj.Natikar@amd.com>