Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1146114pxb;
        Thu, 16 Sep 2021 00:16:38 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJw3wpOhRn/rxVBn0cXyBZfUOHfLJ1Mb988D9+6Q3dTJLWrL7OONOu9ckFL561PN++EM+31d
X-Received: by 2002:a92:c98b:: with SMTP id y11mr2862356iln.205.1631776598113;
        Thu, 16 Sep 2021 00:16:38 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1631776598; cv=none;
        d=google.com; s=arc-20160816;
        b=QeoPumnYbewJRBxqqMG+1HMTqUALzkZHUUCACKXBBSY3MOlZaxrwXmuTDPidoQcLPa
         tU//CAYkEV5sDWq6QqUgyxxhaIFkPxH0pqpGpz4alLp/pf1EZDt97cdnKwyktb+481mD
         +BE4pHYzn+zXYd3utk3t0vGeDg8DvXcnBtz6Lb2a7dhM8UeLMLL3UT7rV7CgsPg+yrVI
         t65xcQM+UFM5aiVS2Ox+c7z+AoDIVsFHMepDpZ058RM/GpefbQ2x2pGJdYTamhYzVYJ9
         sHRGPQvkjDqQyQDJ7uIPnK3lIr9DEJVXZENv1KMo3iD3ZJejczn5fRa/kl+J2hwuOZfM
         oI8A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:message-id
         :in-reply-to:subject:cc:to:from:date:dkim-signature;
        bh=0YJn4USEd0N2vD6kDihrUD5vcq6YAajSNrVRNkNw5P4=;
        b=XTwSpZqKq1a/TpnQ7K4w8VuMtX4pzxZMBecNWLG6RRs33OpJ4RLWIfwpvAgM+rznaI
         4eLrkZKiI47UO/88icSP1EsxCqj4iB3HSmS6e1Ey7v+0iSLp6Xh1u+R+7UxIIh1ncjyy
         wzRl3Q/YWQlX15kEfZbucNYm79T3voZ/YwYZTX+F2XacMWxepF3HWfARdqTUOPbzrzkg
         xxjhlSAVZqtTo4b14fuYvnsyAeIS9hZKGag2JJD7YuU422Q9nyWV9cyTw4L7X3rTZEsw
         JEb15jjEjKRI6tvnDPkibVM0AKwgkXrBONgslIAN1btTQEIYDzLiZO9Zb4JADBwI377B
         Aqaw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=M1rGMdBB;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id l39si2008939jac.108.2021.09.16.00.16.26;
        Thu, 16 Sep 2021 00:16:38 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=M1rGMdBB;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S234671AbhIPHRA (ORCPT <rfc822;lkmlinbox@gmail.com> + 99 others);
        Thu, 16 Sep 2021 03:17:00 -0400
Received: from mail.kernel.org ([198.145.29.99]:42064 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S232254AbhIPHQ7 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Sep 2021 03:16:59 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id E172160F51;
        Thu, 16 Sep 2021 07:15:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1631776539;
        bh=XR0iDHgJpz1GsMhQZUOrZND8ovGzw3mdUlGSBvzw0rY=;
        h=Date:From:To:cc:Subject:In-Reply-To:References:From;
        b=M1rGMdBB/f3uAvoZJYaEMutJ54nUbNMjSsgtlgWtsuNiQZzJaXLCrmOLl+54YWTYb
         IlTlwfWgkmYLNn96xqFdcODcG9Utlor5iSNLSUPnn8/JctcDjP25ImY1Ju8g2e8ZMr
         9FwpM+jk3DR37pi8NrZgCNQbiAHRtmb/uIsdgw8e6xgXxJL/cHdoKTOz2zT0+0P83G
         C3MoaMokvpKG6H4vn/fRjtPoIu/qetwy9w1YKZES/rjnjEGrDGSU7pYKWlTTsGeDru
         QZRXRu3/hG0Ita24VX0h7sfQES5uyOmByW3WuQgOlRNcSQdXaFt4jiJnGRZ1t1UIwq
         m1Y8lI8WWh5VA==
Date:   Thu, 16 Sep 2021 09:15:36 +0200 (CEST)
From:   Jiri Kosina <jikos@kernel.org>
To:     Evgeny Novikov <novikov@ispras.ru>
cc:     Nehal Shah <nehal-bakulchandra.shah@amd.com>,
        Sandeep Singh <sandeep.singh@amd.com>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        ldv-project@linuxtesting.org
Subject: Re: [PATCH] AMD_SFH: Fix potential NULL pointer dereference
In-Reply-To: <20210601163801.17848-1-novikov@ispras.ru>
Message-ID: <nycvar.YFH.7.76.2109160915270.15944@cbobk.fhfr.pm>
References: <20210601163801.17848-1-novikov@ispras.ru>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 1 Jun 2021, Evgeny Novikov wrote:

> devm_add_action_or_reset() can suddenly invoke amd_mp2_pci_remove() at
> registration that will cause NULL pointer dereference since
> corresponding data is not initialized yet. The patch moves
> initialization of data before devm_add_action_or_reset().
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Evgeny Novikov <novikov@ispras.ru>

Applied, thank you.

-- 
Jiri Kosina
SUSE Labs