Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1158260pxb; Thu, 16 Sep 2021 00:40:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTEsiVCvFrdc5Os5MDisQVwzpeJ2TNaajXWB67BM/1tkSItIzeccJ0JC0sCkRma2aAa+D+ X-Received: by 2002:a02:5184:: with SMTP id s126mr3268444jaa.126.1631778021046; Thu, 16 Sep 2021 00:40:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631778021; cv=none; d=google.com; s=arc-20160816; b=Ngv2JH6D8zEzdJQPsSSCkuUyJ9xznY8XqoZNNVvGmnqs5lR8qEiMuBFpLpRqbM31yT uV6QmZ+5u8rLLFNKrZjtlMOLGrTcWWPRRYEmVvm8G0aT/8YOXwNU0yiza0i6DWu0I9uE u/L2WLHyrWzuS3WM+V5SOFJOwqq8/3voXpYD/DOQKYIiS1eh1qS8PqmX3oIEyYyN30Vz gnfePEigFwfTigY+TNyHDvOyJBl5plCW3hHzUZytNxR0bt+5dHG+wwVXNXighuVPDAFa MpmNlaoC8tn0qKvXx9CyMyFKE5lthxb/DsdJCJgd65o2XFOEmsUFJGDIET2OdJCvfNeJ MXrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=dj3GCiRnJAFF2rZYfHYgy0d8GwZnuvqQ5YgXMgMNk7s=; b=hostTpLaIMMyBVfSiTIEVOn9MG/ntZllhdckjbzzHRfmLHv9cQd8XKot1hCC4rEUhU r54Yq+RRhP5wBRCIyhQpoCrhcSn5OmTVroETJUjxDBojJSmIbmn8gw69G6CJiHvMFPvT JjAJRRpVgzjO77WQjwNlx3KYMs5B+N9MrOAIAl24m19rPpQED/iRusR8nKLf9FiDKRRH BvA4VnLRzViCPYYsDQRNlrQR9kyL0e6zmq8GSd3BjgoUzAI9SR2P+xFA9/jCHRLADhaf lPn6uhbYtk9Dj+DFYyVRPwAMyGCbZxQXWp5BVfRNAk9aLZRCmdBmseG5AUkPLptJEZ8u rscQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 65si10458jaf.38.2021.09.16.00.40.08; Thu, 16 Sep 2021 00:40:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234955AbhIPHjF (ORCPT + 99 others); Thu, 16 Sep 2021 03:39:05 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3835 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234935AbhIPHjE (ORCPT ); Thu, 16 Sep 2021 03:39:04 -0400 Received: from fraeml738-chm.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4H984x0ZHjz67mMR; Thu, 16 Sep 2021 15:35:29 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml738-chm.china.huawei.com (10.206.15.219) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 09:37:42 +0200 Received: from [10.47.81.58] (10.47.81.58) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Thu, 16 Sep 2021 08:37:41 +0100 Subject: Re: [PATCH v2] perf test: Workload test of metric and metricgroups To: Ian Rogers , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , "Namhyung Kim" , Jin Yao , , CC: References: <20210916060525.1890638-1-irogers@google.com> From: John Garry Message-ID: Date: Thu, 16 Sep 2021 08:41:17 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <20210916060525.1890638-1-irogers@google.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.47.81.58] X-ClientProxiedBy: lhreml727-chm.china.huawei.com (10.201.108.78) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/09/2021 07:05, Ian Rogers wrote: > Test every metric and metricgroup with 'true' as a workload. > > Signed-off-by: Ian Rogers Reviewed-by: John Garry Note that I also had a local test for pmu events: for e in `$PERF list --raw-dump pmu`; do echo "Testing $e" result=$($PERF stat -v -e "$e" perf bench internals synthesize) if [[ "$result" =~ "$e" ]]; then echo "Event not printed: $e" exit 1 fi done Is there any value in upstreaming this? I could not see same already there. Or else make your new script generic, so that it accepts an argument whether to test events or metrics or metricgroups