Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1254758pxb; Thu, 16 Sep 2021 03:28:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyS6swKX3rRyfBISSY0WQk53Yc56Xh/jTZg2bRoVgfz1hz+KTHprAUsIvAoVkwuLvcHJq0C X-Received: by 2002:a05:6402:1011:: with SMTP id c17mr5783926edu.144.1631788114507; Thu, 16 Sep 2021 03:28:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631788114; cv=none; d=google.com; s=arc-20160816; b=0hvBMyzUBaWIgYEqoik3rCSJLC6G8Q2F9euXegsXETjy0AILcooEZfDHfoKlSIPet1 Axh/E/Kj969YDoAHluUKy5mIoS7jVzWQ1iJJKiTqigsUpOyUigKqJTaNV2n9R2NwU9du cBl+B8nH+NncjZaLNdSxrE0RrTcTImhZ/1267HDNLJxF7f7s2MNKD23FfC0hzDXQNWAh Z78iszTm8bzhA+Y9Mv/xs1OinU/I8tw7N0i+aNeCh7igAN08exlrze4C3ArgSynL1DGw 9N0yGq1/3IXBq4WsLj9ssyRSP5wm5uDzELoZTGmZdNWD14gC9qexd0qK1bM4IrN4/eOZ n3iQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=6S5AMhCNVrlspN/3bjYdeLfuwtE9nTG661txhmEAamc=; b=RSnPy/YEYDW+x+U1+j2SUPDhXMaMwax8Ulqlmc+YE4oFtVSyLX/o2uOkgOB7wIK0lV uQVl1whEMBsZ5n2iDy/WaoLpiwhb+JLGYmwXGp4WHLH9fDJTrrKn6ibYtzM1rGfEl6JB GoHeyDfOZB6l/lt9h4GiIB0Ma8We4tlLuQ4c1uxOoGIDEtARVqq7Zs/FD6t0W9oadBBW C95/gZ32kdR7MYVY+haYkHoDRSCnSygM81lC7kEWvOu/szvPcZmT81uLlaG2sAE5o1sJ ABcNJZBvR89WEM7GjdeT8mJF5VISnab8R24MNcNRqn0fQsX8j1JcTtr4X+C6tG8MrEsY FiaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=jdVf2kKP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y12si2893923edr.430.2021.09.16.03.28.10; Thu, 16 Sep 2021 03:28:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=jdVf2kKP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236186AbhIPK2A (ORCPT + 99 others); Thu, 16 Sep 2021 06:28:00 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:40316 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233913AbhIPK17 (ORCPT ); Thu, 16 Sep 2021 06:27:59 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id D2D293F077 for ; Thu, 16 Sep 2021 10:26:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631787998; bh=6S5AMhCNVrlspN/3bjYdeLfuwtE9nTG661txhmEAamc=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=jdVf2kKPfNvog9XGy1qS+JnSgmqepI47liE/8I+qzTOd4pbJwI0PRtRrH+Q7IcEl3 Q1bqkfMczZEXxPVfRHEjk6zcbSM2vW0qDFQ++rhNjJNPrOimCGlaDct8VnAPK2HyO8 PhXEaBy0THc/U+8jnNyHTyjFYtoLOfKjqnTYRc4Mu4+vSXYVJAlT3W+a+hVOAYnYRL 5vea2+BCPfVUVnnmiZYGIarqVk2HoAjJIOXZzhkuqoCiPC7NHBhqAh7nw0M0XCb0/r PoZL9aLzOA+7anVGhL4U6Oq1wus0vDXEhNyWuXn9DMByq6TAEw+x1foHAJsDRonJxa ChGFRYD70TItw== Received: by mail-ed1-f71.google.com with SMTP id m30-20020a50999e000000b003cdd7680c8cso4898656edb.11 for ; Thu, 16 Sep 2021 03:26:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6S5AMhCNVrlspN/3bjYdeLfuwtE9nTG661txhmEAamc=; b=O/BismoWToOCQAM7BB6GY/iNkhU+T9fZTPu+9NggsTUFvKzQ/5LVedsZ7XWPuK8UyV SQmNLgP7HwJI97LRPi53iLNpMRLrs8CFXU8iubXXKB4fLiJ262zR4b3IgoRAnOuNGxkE CnOaKaWZrOxgGoIC9Ga2mjzNRigz+NYwl/6AOBkwObN8DHxCw2z1Aso1Z63U+/3bgtYo 9XeCGEHzY+IU3zzYBS3b74mPdj25LS6F/NWA0zIzMCxse5+ImQ/191jINdp+wBlIIaDD jfFm3+D6eA02+I1rEDn1Y/9WF8VuCj/D8xCI0rJwNFzipKOFFAdI0eqDGnoNQ2VCabwD n84A== X-Gm-Message-State: AOAM530+fIaodIu7RTkdOyJzio4xkxCtQlHkBsB7nuGo1HZ9A3Wmmzw7 lDgFnFMEjrKmKTLeDhkImq+ZTvR3SmgAya3GY90YHnugMdmhse/dEK82LGk9kbpy754XcgfOCK8 ulr4/KfjYBavTXjtotI4Cxvizg20AbwJEEmK6w2NnHg== X-Received: by 2002:a05:6402:4cd:: with SMTP id n13mr5650688edw.215.1631787998091; Thu, 16 Sep 2021 03:26:38 -0700 (PDT) X-Received: by 2002:a05:6402:4cd:: with SMTP id n13mr5650680edw.215.1631787997971; Thu, 16 Sep 2021 03:26:37 -0700 (PDT) Received: from [192.168.3.211] (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id v12sm1224424ede.16.2021.09.16.03.26.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 03:26:36 -0700 (PDT) Subject: Re: [PATCH v2 2/2] power: supply: max17042_battery: Prevent int underflow in set_soc_threshold To: Sebastian Krzyszkowiak , Sebastian Reichel , linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Dirk Brandewie , kernel@puri.sm, stable@vger.kernel.org References: <20210914121806.1301131-1-sebastian.krzyszkowiak@puri.sm> <20210914121806.1301131-2-sebastian.krzyszkowiak@puri.sm> From: Krzysztof Kozlowski Message-ID: Date: Thu, 16 Sep 2021 12:26:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210914121806.1301131-2-sebastian.krzyszkowiak@puri.sm> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/09/2021 14:18, Sebastian Krzyszkowiak wrote: > max17042_set_soc_threshold gets called with offset set to 1, which means > that minimum threshold value would underflow once SOC got down to 0, > causing invalid alerts from the gauge. > > Fixes: e5f3872d2044 ("max17042: Add support for signalling change in SOC") > Cc: > Signed-off-by: Sebastian Krzyszkowiak > --- > v2: added commit description > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof