Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1256502pxb; Thu, 16 Sep 2021 03:31:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwO2cHexwquMjqMAKcS2acevLeWSZkAw/37+Uvy3xgjeJWFMLJSiH3vzvWQAEIs76+bZMzq X-Received: by 2002:a92:444e:: with SMTP id a14mr3472865ilm.152.1631788305258; Thu, 16 Sep 2021 03:31:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631788305; cv=none; d=google.com; s=arc-20160816; b=bgULDGYToZBeVYLa6H6VIl1lM4xbqguM+L/JIdWmx36e1cr5rqNSRY8GFlEOB+BAU9 SL6lpDARyBY9eFxpv3M4TNeY5MQA9a8SOl+/N3HPEbUr8o7ki+ulOQ0pOHUrMEDX/RmN HBqZhgUuBVwUtZOFZiPFwaLk07cKNN/v9bW13XXEPINq+W3HPbRKj9+0x0sQFgwWvSP/ 5I4FbHlbQZfY/B78WnAuqHxT20M61eFOgeR9aCJlOP+VD1qIWZcrmqzSdgeTr2wkTaG5 nWKiLr3PLWMpVScChDNHFumuVJ1iQY7raFMSu1APq9eqSlYY5LzrViFeaa+Kj++S+JDR lBEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=EXpt8wshiO7ImZN+Zx5zekJn4i6gD7QW4fNVEzzyMB0=; b=P4BodK3yoIOLdwxIFMCBeO4o8GmFLdshCYamSkQ99fH4aJt6Kz7OT7Q2iqVlCMzXcj C/KQUiADVmylYO3rwpte2ZlTo5Q/43CvFXM5JRKAY8s6ViC6OvcPp5uQywihKnJlP+X2 sAEoDpVrNWvERczJr5poPfTcpl14qw1zvvInYF87+C/2PowyxlH/kKQMmCuSZcf5L7wV hWw8FI6rOU4xrFLBnoNsivn4ofcOU7rh4XnkixeZ6kY0koH6QAPWc5EDhN13x8GceFeb aQI/oucFIq7xCEX010AYaVUiailkKw1iSubrp5Ul+zb5+klJjFB9W1E+poicLC6sSR3o WudQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=jdKCZeac; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y10si2460850ion.41.2021.09.16.03.31.34; Thu, 16 Sep 2021 03:31:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=jdKCZeac; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236417AbhIPKbO (ORCPT + 99 others); Thu, 16 Sep 2021 06:31:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233913AbhIPKbO (ORCPT ); Thu, 16 Sep 2021 06:31:14 -0400 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2851CC061574 for ; Thu, 16 Sep 2021 03:29:54 -0700 (PDT) Received: from zn.tnic (p200300ec2f11c600b77f9e345fbfb487.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:c600:b77f:9e34:5fbf:b487]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1E3DB1EC01DF; Thu, 16 Sep 2021 12:29:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1631788188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=EXpt8wshiO7ImZN+Zx5zekJn4i6gD7QW4fNVEzzyMB0=; b=jdKCZeacNO/kKHUWytZdn5Fjo98CAZEQp+DgI7I37Kq2atS39x82DLxp+PzrfJ6w/OMpOx 2kRvyfMEU9NGc0BdDMyQFTyKr41mebgtFFj1rEwSkta4odAJx3N6y0DSrQaVrO5hfk6wCD w9bRZIOCbxUdY5+wJ29B3EVPzm2K9/U= Date: Thu, 16 Sep 2021 12:29:41 +0200 From: Borislav Petkov To: Mike Rapoport Cc: Juergen Gross , Jan Beulich , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/setup: call early_reserve_memory() earlier Message-ID: References: <20210914094108.22482-1-jgross@suse.com> <6cdc71dc-c26d-5c59-b7dd-0eb47ab9c861@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021 at 12:09:27PM +0300, Mike Rapoport wrote: > I think the first sentence about reserving memory before memblock > allocations are possible is important and I think we should keep it. I expanded that comment this way: /* * Do some memory reservations *before* memory is added to memblock, so * memblock allocations won't overwrite it. * * After this point, everything still needed from the boot loader or * firmware or kernel text should be early reserved or marked not RAM in * e820. All other memory is free game. * * This call needs to happen before e820__memory_setup() which calls the * xen_memory_setup() on Xen dom0 which relies on the fact that those * early reservations have happened already. */ -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette