Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210916105122.12523-1-wangxiang@cdjrlc.com>
In-Reply-To: <20210916105122.12523-1-wangxiang@cdjrlc.com>
From:   Bongsu Jeon <bongsu.jeon2@gmail.com>
Date:   Thu, 16 Sep 2021 20:21:32 +0900
Message-ID: <CACwDmQA+wzo06R1kEB-rcz=Td+egF+Kd8+mh46NHnXHK1sOh7w@mail.gmail.com>
Subject: Re: [PATCH] selftests: nci: fix grammatical errors
To:     Xiang wangx <wangxiang@cdjrlc.com>
Cc:     shuah@kernel.org, Bongsu Jeon <bongsu.jeon@samsung.com>,
        netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Actually I asked to fix grammatical errors in the subject.
  For example => selftests: nci: replace unsigned int with int

 And please change the log in more detail and  put a period at the end
of the log.
 For example => Should not use comparison of unsigned expressions < 0.

In addition to that, please send patch version 2 with changelog.
 For example=> [PATCH v2 net] ~~~~.


On Thu, Sep 16, 2021 at 7:53 PM Xiang wangx <wangxiang@cdjrlc.com> wrote:
>
> Should not use unsigned expression compared with zero
>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
> ---
>  tools/testing/selftests/nci/nci_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
> index e1bf55dabdf6..162c41e9bcae 100644
> --- a/tools/testing/selftests/nci/nci_dev.c
> +++ b/tools/testing/selftests/nci/nci_dev.c
> @@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
>                        const __u8 *rsp, __u32 rsp_len)
>  {
>         char buf[256];
> -       unsigned int len;
> +       int len;
>
>         send(nfc_sock, &cmd[3], cmd_len - 3, 0);
>         len = read(virtual_fd, buf, cmd_len);
> --
> 2.20.1
>