Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1291500pxb; Thu, 16 Sep 2021 04:27:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6ODvbe99nhGvY4RgWe+tQlYzEfiAXVN94baZxXVfqjoEHf/bIujtr6J4iHVnHKmFp5C1L X-Received: by 2002:a6b:e905:: with SMTP id u5mr3812568iof.116.1631791643521; Thu, 16 Sep 2021 04:27:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631791643; cv=none; d=google.com; s=arc-20160816; b=KmxeZ5sLI1s44PLOLPGAxfcE9hR6ex1eumfYlhLLjdJZxOWiUkzCE5t+iAPN2NAZ3T /Eo+WUdf3caL59cbzn1oEGqR8U8WsWP3EPPTPzkgrZ/jGKW0gnvRADcJCNhYf60JiZhu kX6YZD4tZl2+x7n0FicAHZ3/gGbE54rR6MEjG+yPTeJa4v34Px5Y9ZeP8NLh6q2uXrO8 8DHb7LDqCXAq6nEPOpBjhuMucxYXEmqpgmDWfhiDyckgTM1WB5bKvO8dBHGWKiOk4o17 b/PGJTdOVfop6eKelBDpVyNPqKFPxCgPAihy6K1J2NGpE7ixnZZ0N21kRD44VNbYShgI 3Yiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:in-reply-to:references :subject:cc:to:from:message-id:date:dkim-signature; bh=DS3mnRRcGXjdmBCBcvU/cxdm6qdEX7sUPpdbKeW8mdU=; b=ks33k3m6s26f/uEvfuIrzk+EARXkcxUxCeLEPgrfuGfKqFv4/IAYA46EqAiFYzFXZD JW557o0ZzGJa2JtTpVqH6uWkOfxobogfb/NN2alL6QWPgvAzyyHCquDqf57CjinysFV0 /KYUAK5zOt4A0lRN6n78taZOiOVs4Vl0fwsiQSZey5ymExCa/tiNuuOA6HtYGag7yPH1 4kBkxQZWDPBOeoauL/h3NyJrH6HKznKEswGC28L1/lhNDC1tkK/7RS0kwjigZxeWRD1R 0I+qe1bQ3dchcBzZhl+FEmzjUftZsoA2p9pSvjdKzI2x5VXSKq8wk6HNjCRkQMJbSUEJ x0/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@heimpold.de header.s=strato-dkim-0002 header.b=o011rUdQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m9si2450345iow.85.2021.09.16.04.27.12; Thu, 16 Sep 2021 04:27:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@heimpold.de header.s=strato-dkim-0002 header.b=o011rUdQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237667AbhIPL1o (ORCPT + 99 others); Thu, 16 Sep 2021 07:27:44 -0400 Received: from mo4-p01-ob.smtp.rzone.de ([85.215.255.50]:19302 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237446AbhIPL1o (ORCPT ); Thu, 16 Sep 2021 07:27:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1631791579; s=strato-dkim-0002; d=heimpold.de; h=In-Reply-To:References:Subject:Cc:To:From:Message-ID:Date:Cc:Date: From:Subject:Sender; bh=DS3mnRRcGXjdmBCBcvU/cxdm6qdEX7sUPpdbKeW8mdU=; b=o011rUdQ2rSK4NGDyeAVP/zGedb+PTsOU1RcNK6bHPUZlytRjZNuhFJiQQo5lbvqrJ SAWZ2buT545/lH7Cl495TX2IBUFrX5bDyl/OP769AfgEtI5IYHKuGGAbjj+ZJCKy1X9e C5suBDob6Yi1hFR6mBNiZWJtPghHUNU1WxWonlZe11DeyIbxhA0G6DwdMJo6hqzCUsly QLU/+Swc6EujJmUw3QPZHezsrxoKwamdKjITxHuq4WMVzDfzsNjmtgBRqtv06fzPQtvE VhxhFen5LueByl4oxSks8VhQ9n0m7Jan8uiYHTYumhOzt97wDH4BOEQSz2X0HH6/YDXr Aa1A== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":O2kGeEG7b/pS1EW8QnKjhhg/vO4pzqdNytq77N6ZKUSN7PfdWTGbO3oK8Gj1qrjlHg/zTQ==" X-RZG-CLASS-ID: mo00 Received: from tonne.mhei.heimpold.itr by smtp.strato.de (RZmta 47.33.1 DYNA|AUTH) with ESMTPSA id R03356x8GBQJ0YY (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve X9_62_prime256v1 with 256 ECDH bits, eq. 3072 bits RSA)) (Client did not present a certificate); Thu, 16 Sep 2021 13:26:19 +0200 (CEST) Received: from tonne (localhost [IPv6:::1]) by tonne.mhei.heimpold.itr (Postfix) with ESMTPS id 64946179882; Thu, 16 Sep 2021 13:26:18 +0200 (CEST) Received: from i5C7537B0.versanet.de (i5C7537B0.versanet.de [92.117.55.176]) by www.mhei.heimpold.org (Horde Framework) with HTTPS; Thu, 16 Sep 2021 11:26:18 +0000 Date: Thu, 16 Sep 2021 11:26:18 +0000 Message-ID: <20210916112618.Horde.UWH1AKpXpmAwqSTq8U1y-WN@www.mhei.heimpold.org> From: Michael Heimpold To: Andrew Lunn Cc: Stefan Wahren , "David S. Miller" , Jakub Kicinski , Rob Herring , Michael Heimpold , jimmy.shen@vertexcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH RFC 3/3] net: vertexcom: Add MSE102x SPI support References: <20210914151717.12232-1-stefan.wahren@i2se.com> <20210914151717.12232-4-stefan.wahren@i2se.com> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: multipart/mixed; boundary="=_BSXR-daGI8uzy-NgKF7qpXC" MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This message is in MIME format. --=_BSXR-daGI8uzy-NgKF7qpXC Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes Content-Disposition: inline Hi Andrew, Zitat von Andrew Lunn : >> +static int mse102x_probe_spi(struct spi_device *spi) >> +{ > > ... > >> + netif_carrier_off(mse->ndev); >> + ndev->if_port = IF_PORT_10BASET; > > That is not correct. Maybe you should add a IF_PORT_HOMEPLUG ? Would a simple IF_PORT_HOMEPLUG be sufficient, or should it be more precise as for Ethernet (10BASET, 100BASET...), e.g. IF_PORT_HOMEPLUG_10 IF_PORT_HOMEPLUG_AV IF_PORT_HOMEPLUG_AV2 IF_PORT_HOMEPLUG_GREENPHY Thanks, Michael --=_BSXR-daGI8uzy-NgKF7qpXC Content-Type: application/pgp-keys Content-Description: =?utf-8?b?w5ZmZmVudGxpY2hlciBQR1AtU2NobMO8c3NlbA==?= -----BEGIN PGP PUBLIC KEY BLOCK----- Version: GnuPG v1.4 mQINBFyFhhsBEADDLoo6Ao90G4vafO0lsguAHUKW27n3w20cPdFy4hBVaVYb2Jti Taqo9xZ+pHoTrN3iBwKGMrf7lWs7fsFF8LqRS0calhZCPQLorbJPoKjMTPwwmmtt WBQcs2H3WmVibHCusYaCp32oGtzVvKLZViKkyyk0brMYVIclMC2fYIaiV+a7wzOt LjAUcqYlYUMT0kdfLdlFHm41S1tYjzxSn/R8t240wbPEuIsGxZY3BGIJJpon0Y9n 1kAGQCpcO+hFD2kGdFOEcitxv9JWV64lA6my4KIJK+yZXJYx/O/adWzGlEFCipbL YaZ1CWqZzocy9C3x0mMZDBUFz3DELPpn6omlm5uYkkf+5pzwmFsPMF+zL+5UMxiU E+ifCIhoLw0fBPyhIfANLKak0R88spknuyQ+V+Ekciy8wgXipgUBbBGplhmkgSls fnoWvi+FtFo+V0baWl8VnbEnB89YlS4lm0z8u9dQOSsmB08D0EXMRyEZKKyAdiNK EZO1AnZEW2FyGZfwGMEmeA5krbVjX1MLx9JstM8Ny6cOW6grFG2NZVIW5cgErYom 5kfB44TSHLIrYvtcf4e8valAwsaPM/LqwFiklOXd0UUp9xqPnPgHQQdgPTKIXOUM OseKRGnRYOfg7KHdFFZlafQp+vAKQ6dHMT5jUc2h7unLcJ+7hMxXAHJNOwARAQAB tCNNaWNoYWVsIEhlaW1wb2xkIDxtaGVpQGhlaW1wb2xkLmRlPokCTgQTAQoAOBYh BLqmVSLI/uwdD5yAIZSCIwN6WR5/BQJchYYbAhsDBQsJCAcCBhUKCQgLAgQWAgMB Ah4BAheAAAoJEJSCIwN6WR5/Ry0QAKv5/uYV8Ou+h2DveXMXboSVJkCs/q4JdnbA sdwEnauwX784ZRxvzRjY9GcQDxWP48HYb+O8Gl0CpJVC5H64Q12djQE84AH7Yliw 0tTvMkqyNDKeEMYhU+r+dOQZ0iZQcQM+muhu1qvFEc+QKkLS3MESkUERkzzccS/D s3uazTlE/O1nEQ40GwoCfNPmQ+xKtgbbjVbVsQtk0zFzLtspZY5OcjSCsq0/kU22 wdA474nZr9Z8/snDDHZabJ2v02GAg8SvT1Krvgd38WWcrbtcW8R5aHH23vBISVTP ja2ApCi039+itv01JUOz+/6TNSlBbgG79RN9ERga0b+jAN5GpBRj6a34J3IVixU8 HyUPQm23/0XpO0hh0TzYXdFqYfy+wntq7Vmxw5UorPm4IGreYH0OlG6QjVD7YdyC 9wr41leVgyfzyZQsFs0+ynx+tqEwfE2B3tgyEKMx/rjyIcHmODmVeOumCd80a1p6 CF5EnROe0+ryNz8oj3Bn5SxKTX1WoVk41EWENjcqvlKHn6AzWw7T998RkPMREMq9 pymM0vJKZW7kq2i7RHi1O6Kkct4EsKNqFD9dNgTn2V1o57Ee3bN4QWjedq+Z3tkx IbaPn79Y94s211+c7QTEoaNBXehUv7toJkyn/wJ5iRCFbVY9CZ2s2zujn68pWm4T cynypHX+uQINBFyFhhsBEADpQk1v7h6vJzJ8WvWL+9lbO/PxCcLegcPZwHOGA2qy pyagVfkRHj76UDZSvsDSV66z/PVF3rlq1hrFf7k5H8lbo9pqaisFWbhxvPx+38gL BcmvAPNQlWn/WqZdzfNIaBsnFzB8sd3mleJw7FliaDHBIBfsAO42y1zeCWLwzBE0 tLmBmiAc2CrHFKPLcKFXdhivmdkzbIqY9klyFGNufdo3o7vKGBa0ByBKs6eV5QRi 8LQlu4VUJbyGDGWHOPvtPoI73yipSiq8JBt6llFIJ8nWLYsKWJLL4VS+GjuYJOGe sWPrQiPY7fDomuGqvxOe+iudK7FypZE19oonN3CIBxN9Kb789zrn3JlpEPLTlLVZ X5bGQXmUMrYunX7nZWQJier1PZeXVtVoyzUJAUJnVWbtS9ijUL02qheihtzC8/CN sn4aBFswX1qzj5uc+9XjxB80iPGSengJMhjQYmdkVznmtvzc6/VgHf4NVBgckgYJ xKmBKmPQ/YzjVIYyedbq2k2+vXODHPpAhRF0be2eTRLk0O2ulH5v5pCFZLRZx6MU oIMmovPuENB3V0SKJN9n+1f0wOec7bicjF2i5LeXnyvjOCJfXU42EStG+B31B7f0 LWwthGkz1sQGOrY/uCDDkZ9HRgNqC3zVrNTLbDprrBUfWSunBjqkM90VBD52lJ32 /wARAQABiQI2BBgBCgAgFiEEuqZVIsj+7B0PnIAhlIIjA3pZHn8FAlyFhhsCGwwA CgkQlIIjA3pZHn87Bg/+L+p0d7iuwY7NdAUkUfS4oH+QiQ1mNdocZ3G/g30rOh0w dL/NzaaISq310auhA95MqIw3SYS9JG+67dteovbRv4TjUJsJ4YVRJzkmAsSqnw8B t2P55DaIDuYziCdL0L4jly22clVLSEFuNr9PJSu9sStptsM7UrdzGej1H1guod16 G5O6ge8LuJ8vQemM/nWQYTN8uClhDAlP81eXk/rVmcnw1e/cWAkvbF3iB1yGKA1e JDZW32vrebniKh+fA34xccgIGre+hfdURA9RQw7qAbMbco4z/1ia1OQiDa3YuqJH gGGWNODOXYey7KnbTUU0PClq+x/Jnj7p4TIjb1aZfTE+Q9oaZbcMbjR7ZeqRHyR1 gHNuyrSmII+JWfhl3p/yTweTTXTA7dTACY+Ru1Zj6v/3B1B44FA3rJvGRxS2ZFEG jALB/4sTxMJcwDKOcsDA9T9mbDlxHqia7Sx8ZXybkGfS+H4rYmjRfj3b+QAOjgS+ 0gqs97bnFU8wArE4Tf0vU2IO9zkhJ/vQLiWPLJPE5WpBXWcOs9dW4pyE/I6QP7+W 6rUjXyUlWXjhyQsqwN+xllgbxMwNCvWfXkQS+wb02su/68oBLcUY+X1Y+O3CBlfk qXXXMt0zBy4xRkjdCiixiJnENAEnG/rR2OF+7NBQlM0Heu2229fI6Oli/0Fo58Q= =B0nQ -----END PGP PUBLIC KEY BLOCK----- --=_BSXR-daGI8uzy-NgKF7qpXC--