Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 net] net: mscc: ocelot: remove buggy duplicate write to
 DEV_CLOCK_CFG
Thread-Topic: [PATCH v1 net] net: mscc: ocelot: remove buggy duplicate write
 to DEV_CLOCK_CFG
Thread-Index: AQHXqpmLU5hIUf81/UamU4A4Gp46daumib8A
Date:   Thu, 16 Sep 2021 11:39:15 +0000
Message-ID: <20210916113914.3mgy3jkwsfiqyg5f@skbuf>
References: <20210916012341.518512-1-colin.foster@in-advantage.com>
In-Reply-To: <20210916012341.518512-1-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?J0sHPq1Os8wbt1H8U3AoXKQwfpGoZCnSFAN95qGCUrmU6IdE/9hHEqCwmlaT?=
 =?us-ascii?Q?D+itWDAiY0nRiHyb+MNJa6A36Ush3Kmo2ib+OFU1IROGFiEKpKxN8pvI5YAt?=
 =?us-ascii?Q?xLC91nLrYWG3C6RMxAl3D7B9NFEFhcC3dBtdRm9sUmIjgOcO5cjD+2Ldp4Fg?=
 =?us-ascii?Q?jVvLgOa3v42xURMR0FMrpymAu34KFKxn21IOibOU6CAoJ2h460/whG7aCHNN?=
 =?us-ascii?Q?qsP3da+Dg80MUS9eXP+zqn03lD6mpGR65gmXgwcZGUINQK8qOrfbz8tL3b3f?=
 =?us-ascii?Q?MSc00ZXlPJwMJemSDsgNa76adYONg+8mspX92JA3IE6dG9TxV7K4boWMT1Js?=
 =?us-ascii?Q?Pk8ah4mRwrkfOXT/Jz1JXwrR0GdjMXmobpyUFiMdU/co/oJXXqIswoS9JIuG?=
 =?us-ascii?Q?p8uQ7/H3w3vWC9BDPj4LbuCPxrmdrzzMhbCN/QUOfLrbJLhlnAhSfoiBATWX?=
 =?us-ascii?Q?q3CGa8TAlG4PbaIr0exbuSWcxk197QzfwDalfXmNptxdkCPOlH5d4Ke/fKRN?=
 =?us-ascii?Q?J+jV+XcKY+S7nYd4vnTpFenXBopVr0LZQuZuFdTcpX1NxoV56CbA0Bs3wEBn?=
 =?us-ascii?Q?SspRuKhSThgulNn1GzRw0hlRdV7Z2T6+K6DrC9U/kS0Mvk3doFsFkdP8DAcc?=
 =?us-ascii?Q?hYCOf7jCyABf/tjbKjfBuy68eTrRApyHgnPPuq4tDPsoD5NaMNGN5Lg11P9w?=
 =?us-ascii?Q?IUy5aPWXox6/0RwLiOFwujaKSUpgfHnALEXh/D3iCrN2tCPCCR0mIX/G+Man?=
 =?us-ascii?Q?ayAswQVGp9xrRKwElF26fzCvL2EqEe7GLTufq0ILoA4XhYAiphM3YAtpR8Ha?=
 =?us-ascii?Q?4puubZDvTwb5uLk9seA5cXkWXSI+/iXaTe/U+66dEE8nXMQ5EektkcvY/L67?=
 =?us-ascii?Q?HbZoNsO0jtAHTfcMMjL3fh/kX2G1lKbYPPlIiKKkYhEE5GWQu1HfKkrM/E/J?=
 =?us-ascii?Q?Ca+hCHv3ypROy8+5n8iOMBVAe2zozE71bgfugTciTT5wSynOj7YzbnZxW63M?=
 =?us-ascii?Q?bUJDT/QRUB9So0PxOKpXnshHHhkpEabS9/Fa7Cna4pT7wf2Na641ckKTHneu?=
 =?us-ascii?Q?WlXxAHe9FNIyXOZWqvL6kgLzDosKn1WtTFweVoiIg71Lm64Ez9AM5oP4WV2p?=
 =?us-ascii?Q?tTK3cbAvWfm+o4RXqrKYcuKOzmh74YH3Mdf+0VdVeYQtz6MHO7eA/Qsg2JUX?=
 =?us-ascii?Q?N8kgOv/9bwfdwMVSHscaLNi9ifunU1eblqx8xI+knYDJ/lOAZG1ypoktEwi4?=
 =?us-ascii?Q?HybT24HedA4MXwBy2V3VWJHncG6YFINvgvL+M83PCF2M7+Etnaat48E5Nw0R?=
 =?us-ascii?Q?I5C01TEfH2x0i1l5KAPqcO/S?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CD85596B90984A4289A448A6A2A8CFBD@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1818ba5a-fca9-42b1-8248-08d979069c76
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 11:39:15.0313
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uLCbkA6ogmeuBJAyWqbus/fGl0t5SFR/p0RVOyrtJHdMOR4ygIJKEQ5mgXzCAq10iPqyC+O38fm5bOcXixsAWw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5344
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 15, 2021 at 06:23:40PM -0700, Colin Foster wrote:
> When updating ocelot to use phylink, a second write to DEV_CLOCK_CFG was
> mistakenly left in. It used the variable "speed" which, previously, would
> would have been assigned a value of OCELOT_SPEED_1000. In phylink the
> variable is be SPEED_1000, which is invalid for the
> DEV_CLOCK_LINK_SPEED macro. Removing it as unnecessary and buggy.
>=20
> Fixes: e6e12df625f2 ("net: mscc: ocelot: convert to phylink")
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>=