Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Colin Foster <colin.foster@in-advantage.com>
CC:     Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 net] net: mscc: ocelot: remove buggy and useless write
 to ANA_PFC_PFC_CFG
Thread-Topic: [PATCH v1 net] net: mscc: ocelot: remove buggy and useless write
 to ANA_PFC_PFC_CFG
Thread-Index: AQHXqpeh6y6SRE8JykW9vsuy+tc/X6umjJKA
Date:   Thu, 16 Sep 2021 11:49:18 +0000
Message-ID: <20210916114917.aielkefz5gg7flto@skbuf>
References: <20210916010938.517698-1-colin.foster@in-advantage.com>
In-Reply-To: <20210916010938.517698-1-colin.foster@in-advantage.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x5fHgbyK0+3mRyHKJW8V4xhKtvhE9LV72Ii0hXhgjPLCLrJre1ZJclBo9AJB?=
 =?us-ascii?Q?MuSSvXQNU8nKGg9JRgCpY0azB13f3cUCQWMg6jQMwkUIhQhCkEcXvZAmZZ9r?=
 =?us-ascii?Q?Bg1Wabx2OdNyS9GlD25kEIeevKvYhksFx47fslD2tWr8JZUenZOM+9Rc2vOr?=
 =?us-ascii?Q?yrc00pIYhiB3QR55LNDeDd1pH6fKluQkDWH3YxiNkm+oa1Ec0YNYOX4TxnYC?=
 =?us-ascii?Q?IHrCTo9WWD1I3yzmDMQfYiwzsFODZCxt07JJih6YkfN1/5Lhz+gqbKMtnRQX?=
 =?us-ascii?Q?4tF/EAWGQzZauNjcAXqFoBEMlWL8z3wUCbkZiKlAnddgIyb+UM7qkS+5mlMI?=
 =?us-ascii?Q?smgyyNXc0VuXWN5hmD1+zpsUh+23tQrffW5mfKVnSbXCDFtjM8KqOwXT/gYu?=
 =?us-ascii?Q?iza7ZJeHAhZVhZw1Dov0m4Vkyf1BFwLzDfiHk/EX5zHma68r5Cbt1891gLx+?=
 =?us-ascii?Q?IOr8Wka4abN36W6gufxxopLmXWNVv5+jaOV9JPoOlm/iCT8H31rifT5CTQK/?=
 =?us-ascii?Q?HyEQwgvhTwDerVj4YksCVOdNPV3MilKk9Y6NLrw+fM4zdPuSojO1fUd6sHnK?=
 =?us-ascii?Q?A5X/zGsmixPRZWGIOPHf9EVbI0GGRSNn0QAiigUETYSwcB7pSN8IIhBY0MvY?=
 =?us-ascii?Q?E9VUQew4S92qnieZxzl5zVRsb8UMlT+ZKORlXvVClbkQ8Hwa2lrmZeYbTjNQ?=
 =?us-ascii?Q?Q9RC1KwhY4cUzkVj5uEBCEsl/IcC1xD9PPL93oEoLJAGMqjUvU9nEma00Y0Q?=
 =?us-ascii?Q?VOhK9/jJ9E8vvDDCI1N8hj7qeUtSgZDngPv0DqPBJI3AXqzqUwAoZxn+fIBN?=
 =?us-ascii?Q?QLsnTacL1ISPHWfmDUSYQjKNtD429Axbsj8DnyIzw1w5aN37sYZv3cI6Nbcp?=
 =?us-ascii?Q?VH1WyF/KYM0ZCIjEqxjtZbVOgx/aUYmR6yIo+gRfOTtOB122AzMlruJAhCNg?=
 =?us-ascii?Q?Z0/WI9Wurifp/i7wpPx5GaIuhyrL/b710LYV+hLHYZLBd1rnW+dEnwdjW18A?=
 =?us-ascii?Q?JvmY/HJHkl3nVNtMmLlE/ARL3SZNO/5JHKIqyvtJ2NwIYj/TuYwD54zHLA/d?=
 =?us-ascii?Q?x7nlC2VKD3NPFsTxO9O9KHyF6u9a47Iyh9TjVifs+nvNj0PvyOrKaLlgTXLm?=
 =?us-ascii?Q?XldOPa0hW2pyGR5M1E0PHWeGdOUH0u6LGwjOelNI2g2vjdsLI00Mp1ofALa/?=
 =?us-ascii?Q?mgyW/0Ri+UN7Wl0zBnjfEcRpom1D0nIJlAM/otRZjQ8pC/Zro6oxogoeXDel?=
 =?us-ascii?Q?nHPeGUZo74uf/YrH3uV4fsYiYg23xydxisysr77mfTAjAIlk+JbSar71VJGx?=
 =?us-ascii?Q?Zc3hKu/GV9MlWGPg9T5YVHk4?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <38C4B60FA475244FBA3F3993BC8A000C@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8d367b1e-e3d1-4e17-91cf-08d97908045b
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 11:49:18.8365
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3idKFQH+zNZYR/kGMbq+DnyM0tAqDaZjeBEs+gn2hRSeMa5Zshe02iYiJiZQJ7y0b/w2mYrfyeAenwkxLFKo4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3069
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Sep 15, 2021 at 06:09:37PM -0700, Colin Foster wrote:
> A useless write to ANA_PFC_PFC_CFG was left in while refactoring ocelot t=
o
> phylink. Since priority flow control is disabled, writing the speed has n=
o
> effect.
>=20
> Further, it was using ethtool.h SPEED_ instead of OCELOT_SPEED_ macros,
> which are incorrectly offset for GENMASK.
>=20
> Lastly, for priority flow control to properly function, some scenarios
> would rely on the rate adaptation from the PCS while the MAC speed would
> be fixed. So it isn't used, and even if it was, neither "speed" nor
> "mac_speed" are necessarily the correct values to be used.
>=20
> Fixes: e6e12df625f2 ("net: mscc: ocelot: convert to phylink")
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> ---
>  drivers/net/ethernet/mscc/ocelot.c | 4 ----
>  1 file changed, 4 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/ms=
cc/ocelot.c
> index c581b955efb3..08be0440af28 100644
> --- a/drivers/net/ethernet/mscc/ocelot.c
> +++ b/drivers/net/ethernet/mscc/ocelot.c
> @@ -569,10 +569,6 @@ void ocelot_phylink_mac_link_up(struct ocelot *ocelo=
t, int port,
>  	ocelot_port_writel(ocelot_port, DEV_CLOCK_CFG_LINK_SPEED(speed),
>  			   DEV_CLOCK_CFG);
> =20
> -	/* No PFC */
> -	ocelot_write_gix(ocelot, ANA_PFC_PFC_CFG_FC_LINK_SPEED(speed),
> -			 ANA_PFC_PFC_CFG, port);
> -

This will conflict with the other patch.... why didn't you send both as
part of a series? By not doing that, you are telling patchwork to
build-test them in parallel, which of course does not work:
https://patchwork.kernel.org/project/netdevbpf/patch/20210916012341.518512-=
1-colin.foster@in-advantage.com/

Also, why didn't you bump the version counter of the patch, and we're
still at v1 despite the earlier attempt?

git format-patch -2 --cover-letter --subject-prefix=3D"PATCH v3 net" -o /op=
t/patches/linux/ocelot-phylink-fixes/v3/
./scripts/get_maintainer.pl /opt/patches/linux/ocelot-phylink-fixes/v3/*.pa=
tch
./scripts/checkpatch.pl --strict /opt/patches/linux/ocelot-phylink-fixes/v3=
/*.patch
# Go through patches, write change log compared to v2 using vimdiff, meld, =
git range-diff, whatever
# Write cover letter summarizing what changes and why. If fixing bugs expla=
in the impact.
git send-email \
	--to=3D'netdev@vger.kernel.org' \
	--to=3D'linux-kernel@vger.kernel.org' \
	--cc=3D'Vladimir Oltean <vladimir.oltean@nxp.com>' \
	--cc=3D'Claudiu Manoil <claudiu.manoil@nxp.com>' \
	--cc=3D'Alexandre Belloni <alexandre.belloni@bootlin.com>' \
	--cc=3D'UNGLinuxDriver@microchip.com' \
	--cc=3D'"David S. Miller" <davem@davemloft.net>' \
	--cc=3D'Jakub Kicinski <kuba@kernel.org>' \
	/opt/patches/linux/ocelot-phylink-fixes/v3/*.patch

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>

Please keep this tag but resend a new version. You can download the patch w=
ith the review tags automatically using:
git b4 20210916010938.517698-1-colin.foster@in-advantage.com
git b4 20210916012341.518512-1-colin.foster@in-advantage.com

where "git b4" is an alias configured like this in ~/.gitconfig:

[b4]
	midmask =3D https://lore.kernel.org/r/%s
[alias]
	b4 =3D "!f() { b4 am -t -o - $@ | git am -3; }; f"=