Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210916115212.24246-1-wangxiang@cdjrlc.com>
In-Reply-To: <20210916115212.24246-1-wangxiang@cdjrlc.com>
From:   Bongsu Jeon <bongsu.jeon2@gmail.com>
Date:   Thu, 16 Sep 2021 21:07:47 +0900
Message-ID: <CACwDmQCbmSo1viWUqUciXUx0jbznPiSj4na+XE2QaD+_B39GWQ@mail.gmail.com>
Subject: Re: [PATCH v2] selftests: nci: replace unsigned int with int
To:     Xiang wangx <wangxiang@cdjrlc.com>
Cc:     Bongsu Jeon <bongsu.jeon@samsung.com>, shuah@kernel.org,
        netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

I asked you two things.
Please check them below.

On Thu, Sep 16, 2021 at 8:54 PM Xiang wangx <wangxiang@cdjrlc.com> wrote:
>
> Should not use comparison of unsigned expressions < 0

Please put '.' at the end of the log and add the changelog.
For example
=> Should not use comparison of unsigned expressions < 0.

>
> Signed-off-by: Xiang wangx <wangxiang@cdjrlc.com>
> ---

Please add the change log here.
For example =>
Changes since v1
* Change commit log

>  tools/testing/selftests/nci/nci_dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/nci/nci_dev.c b/tools/testing/selftests/nci/nci_dev.c
> index e1bf55dabdf6..162c41e9bcae 100644
> --- a/tools/testing/selftests/nci/nci_dev.c
> +++ b/tools/testing/selftests/nci/nci_dev.c
> @@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
>                        const __u8 *rsp, __u32 rsp_len)
>  {
>         char buf[256];
> -       unsigned int len;
> +       int len;
>
>         send(nfc_sock, &cmd[3], cmd_len - 3, 0);
>         len = read(virtual_fd, buf, cmd_len);
> --
> 2.20.1
>