Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] MAINTAINERS: Add Tom Rix as fpga maintainer
To:     Moritz Fischer <mdf@kernel.org>
Cc:     Greg KH <gregkh@linuxfoundation.org>, hao.wu@intel.com,
        linux-kernel@vger.kernel.org, linux-fpga@vger.kernel.org
References: <20210914182333.3903389-1-trix@redhat.com>
 <YUDw0gvgdijpytfU@kroah.com>
 <25d1dac2-4f9f-b5f0-8ce8-b88442deac9d@redhat.com>
 <YUH9dg01Mtk+kO+C@kroah.com>
 <c0630361-69cf-992a-78bf-a1c8335acd28@redhat.com>
 <YUJdts/9kowAen+K@epycbox.lan>
From:   Tom Rix <trix@redhat.com>
Message-ID: <ad209636-a819-5bd5-b643-1cda12201a73@redhat.com>
Date:   Thu, 16 Sep 2021 05:41:35 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YUJdts/9kowAen+K@epycbox.lan>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 9/15/21 1:55 PM, Moritz Fischer wrote:
> On Wed, Sep 15, 2021 at 09:12:51AM -0700, Tom Rix wrote:
>> On 9/15/21 7:04 AM, Greg KH wrote:
>>> On Wed, Sep 15, 2021 at 06:23:16AM -0700, Tom Rix wrote:
>>>> On 9/14/21 11:58 AM, Greg KH wrote:
>>>>> [note, you got the maintainer's email address wrong on your cc: line
>>>>>     I fixed it up...]
>>>>>
>>>>> On Tue, Sep 14, 2021 at 11:23:33AM -0700, trix@redhat.com wrote:
>>>>>> From: Tom Rix <trix@redhat.com>
>>>>>>
>>>>>> I am the maintainer of the fpga/ subsystem for both the kernel and
>>>>>> userspace for Red Hat.  I have been an active reviewer and contributor
>>>>>> on for public fpga/ subsystem for the last year.  I would like to
>>>>>> help out more.
>>>>>>
>>>>>> Since I am paid to do this work, change the status to Supported.
>>>>>>
>>>>>> Signed-off-by: Tom Rix <trix@redhat.com>
>>>>>> ---
>>>>>>     MAINTAINERS | 4 ++--
>>>>>>     1 file changed, 2 insertions(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>> index 04fa4edf100b83..0443d7ab826659 100644
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -7353,9 +7353,9 @@ F:	include/uapi/linux/fpga-dfl.h
>>>>>>     FPGA MANAGER FRAMEWORK
>>>>>>     M:	Moritz Fischer <mdf@kernel.org>
>>>>>> -R:	Tom Rix <trix@redhat.com>
>>>>>> +M:	Tom Rix <trix@redhat.com>
>>>>>>     L:	linux-fpga@vger.kernel.org
>>>>>> -S:	Maintained
>>>>>> +S:	Supported
>>>>>>     W:	http://www.rocketboards.org
>>>>>>     Q:	http://patchwork.kernel.org/project/linux-fpga/list/
>>>>>>     T:	git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
>>>>>> -- 
>>>>>> 2.26.3
>>>>>>
>>>>> Traditionally existing maintainers are the ones that add new
>>>>> maintainers, it's not something that you just submit a patch for hoping
>>>>> it will be accepted.
>>>>>
>>>>> What has changed since the last time you asked to do this?
>>>> Because public and private requests have gone unanswered for so long, it is
>>>> unclear if Moritz is still maintaining the subsystem.
>>> He is, as is evident by the patches I accept from him each merge.
>>>
>>>> The nearly year old xrt patchset has been pending for 6 weeks with minor
>>>> changes to one patch out of 14 needing reviews.
>>> Code quality is not the maintainer's job, it's the developer's, so the
>>> age and number of reviews is not any indication.
>> https://lore.kernel.org/linux-fpga/20210802160521.331031-1-lizhi.hou@xilinx.com/
>>
>> The review is needed because Moritz asked for the changes v8 here
>>
>> https://lore.kernel.org/linux-fpga/YP42zE2ljx4hHj40@epycbox.lan/
>>
>> When the maintainer asks for the changes, they are responsible for the
>> followup.
>>
>>>> The standard release patchset, which needs an opinion has on an api change,
>>>> has been outstanding for 8 weeks.
>>> Have a pointer to it?
>> This was a change you requested. the recent patchset is
>>
>> https://lore.kernel.org/linux-fpga/20210914214327.94048-4-russell.h.weight@intel.com/
>>
>> The discussion around the api change is
>>
>> https://lore.kernel.org/linux-fpga/661d53d0-0ba4-d344-8da0-995a9b612905@redhat.com/
>>
>> In these toss up's if the maintainer does not weigh in as the tie breaker,
>> the patch stalls.
>>
>>>> If maintainership depends on an approving maintainter, what happens when the
>>>> approving maintainer has left ?
>>> Vacations happen in the summer.  I've talked to Moritz many times, and
>>> all is well here.
>> Yes. in the xrt v9 patch Moritz announced late of a vacation with a return
>> of 9/4.
>>
>> It has been 11 days.
> I had a family issue that was unforseen combined with an unusual high
> post-vacation workload at $dayjob when I got back.
>
> I'm still catching up, and will get to it when I can.

I almost never take vacation because of the post vacation workload.

You not having backup is a problem.

Please consider taking the help I am offering.

Tom

>   
> - Moritz
>