Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 16 Nov 2001 16:47:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 16 Nov 2001 16:47:16 -0500 Received: from ns.suse.de ([213.95.15.193]:7186 "HELO Cantor.suse.de") by vger.kernel.org with SMTP id ; Fri, 16 Nov 2001 16:46:27 -0500 Date: Fri, 16 Nov 2001 22:46:26 +0100 (CET) From: Dave Jones To: "Randy.Dunlap" Cc: Linux Kernel Mailing List Subject: Re: [PATCH] AMD SMP capability sanity checking. In-Reply-To: <3BF587F8.84607648@osdl.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 16 Nov 2001, Randy.Dunlap wrote: > Dave- > A couple of minor comments below. > Some bit #defines for would be nice (instead of magic > numbers). Agreed. > > snprintf(buf, sizeof(buf), "Tainted: %c%c", > >>>>>>>>>>>>>>>>>> %c%c%c <<<<<<<<<<<<< Yup. Thanks for that. Those fixes, plus fixing borken indentation I introduced will be in -2 at http://www.codemonkey.org.uk/cruft/ in a while. regards, Dave. -- | Dave Jones. http://www.codemonkey.org.uk | SuSE Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/