Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1353680pxb; Thu, 16 Sep 2021 05:51:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzrvSO/0M3nESmyLWIdgFiqyiJ4qF68HTUK+xHWoi5cRtxvrwH+bpuJIFI/+R4ppvbWXrHo X-Received: by 2002:a92:1306:: with SMTP id 6mr3635290ilt.183.1631796693521; Thu, 16 Sep 2021 05:51:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631796693; cv=none; d=google.com; s=arc-20160816; b=pbE34bkLJKGj8/OZu1+N+bmOlKLNI3E276Bc5o2l9SL6/+fJDcFiL1NS0z72Ht8ZLe Bx/I25NSIWGlAsz4qQBQUdKNaTG562p//Dwfaog3CIDzNXWaEPPNECGctRj9dxf0ScsF BaLvo7naoInKbmkWK1JqwaKwrPKakGah1R8hjG9Nlu76HzKEGMVCbmbDtk5wdKFBe60/ Z5thLQwbz9/z8aoMBNbhRt+aYokBsTix3fbVeGDBsIggZXieWwUVXIsetv7XMg0A8SWT fsv7Kp9nokf0MT/AXMyxCiqLu3bm9OJt/H/Ozhe8+y7If0vOIGXt17lOQ2TFcYp44dtf pKZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=49Dsryiv3dcLfpmVKNAA9Sv+OZpWhSmz8iP/O9CxmMg=; b=mjnfXIkEMOhG7FuSbCAjcHG2QhAxF1ZRGFO09MPz1eFWtxvAeFa6O58eyRzkikuIRq l8+clliflbfCmES+ZVWJXKht8S3OVRgKHulzHYwl4h/2SmiM6kfPdbVxT7Rkhrlv8TFg yrGCU7T3cGAX7iemrwOi93hyaWlmwXQywGwLdzdctJe14T9sNiJaIkkEX128n5WLAAUT A4Ae+oUFpigRGqnffiCh7/QIcNcnXE/bG0/KQMW9+JkyPgxS/rZ3+8FnFlUo2o6K4Tc5 ClLe4RDvAc1qFkChpTUgrQ5lLxmwpPGFcZZMVgjx4XB6vzzYNc+xMwtzhqztfilpHQPf R3Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XXjHWzQI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m22si2099197jaa.52.2021.09.16.05.51.21; Thu, 16 Sep 2021 05:51:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=XXjHWzQI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239654AbhIPMvX (ORCPT + 99 others); Thu, 16 Sep 2021 08:51:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:57410 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239623AbhIPMvW (ORCPT ); Thu, 16 Sep 2021 08:51:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631796601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=49Dsryiv3dcLfpmVKNAA9Sv+OZpWhSmz8iP/O9CxmMg=; b=XXjHWzQIRoCEm25f6xHRWTnGOPcFWkwHVNCz/tGMlYbzLhy3D9BLqs87siNGhuVE7mJR9J zZzEi+J9/4rWqanqmClUcBOrI2IxEVYK4eLzYmOQvDNXt21ziuHZ9pHh/vdtTqJwBmMQ7m M8xDR46IO9PoRcDybSi3GyZDTTDEwOM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-mQK3Q4erOR2RNLBVC9E4LQ-1; Thu, 16 Sep 2021 08:49:58 -0400 X-MC-Unique: mQK3Q4erOR2RNLBVC9E4LQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CD94B802934; Thu, 16 Sep 2021 12:49:56 +0000 (UTC) Received: from T590 (ovpn-12-89.pek2.redhat.com [10.72.12.89]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC3925D9CA; Thu, 16 Sep 2021 12:49:48 +0000 (UTC) Date: Thu, 16 Sep 2021 20:49:59 +0800 From: Ming Lei To: Yu Kuai Cc: josef@toxicpanda.com, axboe@kernel.dk, hch@infradead.org, linux-block@vger.kernel.org, nbd@other.debian.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com Subject: Re: [patch v8 5/7] nbd: clean up return value checking of sock_xmit() Message-ID: References: <20210916093350.1410403-1-yukuai3@huawei.com> <20210916093350.1410403-6-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916093350.1410403-6-yukuai3@huawei.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021 at 05:33:48PM +0800, Yu Kuai wrote: > Check if sock_xmit() return 0 is useless because it'll never return > 0, comment it and remove such checkings. > > Signed-off-by: Yu Kuai > --- > drivers/block/nbd.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Ming Lei -- Ming