Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     vbabka@suse.cz, geert@linux-m68k.org, akpm@linux-foundation.org,
        ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com,
        dvyukov@google.com, maarten.lankhorst@linux.intel.com,
        mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        intel-gfx@lists.freedesktop.org, linux-mm@kvack.org
Subject: [PATCH RESEND v3 1/3] lib, stackdepot: check stackdepot handle before accessing slabs.
Date:   Thu, 16 Sep 2021 23:35:33 +1000
Message-Id: <20210916133535.3592491-2-imran.f.khan@oracle.com>
In-Reply-To: <20210916133535.3592491-1-imran.f.khan@oracle.com>
References: <20210916133535.3592491-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wrdvudNLl22+ac2H6GB3SHXGypOMQD5FabrvuGTAosqJfrskdyccqIO+FVfc?=
 =?us-ascii?Q?UBrgtYSWdZcAyO0s0SL6eQuNR0g+nG0ed/9vVTS3V0z5VGZ16YPidXC+Vo0a?=
 =?us-ascii?Q?RR+FSR6uZH0tnm57MTPBl2tbBBHL2FKMtC7nCFDw+SbJyo85XVTl9IhI4N+x?=
 =?us-ascii?Q?iGaSKIgQlG7I+b08aPjRZM1XK+hfll5aTNO3hJUS7PyPjXQEcwNNQd4xeOV7?=
 =?us-ascii?Q?ujhGvvLDe2usJJn3dp2+tOh/HD9lSlTNsixTJP0lbxNxTAfnEt9UfrAoTiJz?=
 =?us-ascii?Q?ac8DZA36Z2T1ZyQeS01pWPriyyzo+flIkWHdT906I/lDI+EERwxSZlBeLcEL?=
 =?us-ascii?Q?WQ8TY5fvituC5o0k95myvM7fYNo8y+LBKypxR/COM/QEwo7H0x6tIzpaUE6J?=
 =?us-ascii?Q?NUyz4TBqZAmQKCoP4F0wE68kjad62EsVigPxiJjFi6Uzkmc/ZY8izWshxHy+?=
 =?us-ascii?Q?V3muWENAj2E1UBNKt4CkgArlgxRHr9IjcEtqfVZG5EVuw46ECXzbfDL846si?=
 =?us-ascii?Q?WLKQW1RAA9aoF3uuI5cd4KQbynW32OXwg8WLYfwyYdaoRzK2kS7wQy3RYTkn?=
 =?us-ascii?Q?82fjImvfH5Tk/TfzzPsd5gxC5XW1VrYoPi+FN0b4OnZ+GXwXP+b6FuZSCHBF?=
 =?us-ascii?Q?VFjAoNHBGSMNvuoLCreb7KNfdkuCCDA94XpL/kQ3+f1vKolTLDAmyYcf3BoZ?=
 =?us-ascii?Q?uH8kgwVkiFHb+7JgEptWL7sOKb8ZMuBnJQiC+654QdcWWJTNXnjYVhKfWrmT?=
 =?us-ascii?Q?HLorGB1AzqjGkiJO5ZzIKQdQovudq5Gl8K2BIzjYrPo4u4Wm87sN//0lBhLd?=
 =?us-ascii?Q?KAv+lPN8qzSPtj9qVB8TiZ0kzR3AVZIKOtjfpmfpzw6O00d8CTNrExCEvwzw?=
 =?us-ascii?Q?BYT4BUsddeNxTP2gVdMlL6ZSUizX7O4lyuY0u2rT4GRrGtakJkQywLuPcwRY?=
 =?us-ascii?Q?Yo61U9LUpLQHpZnsG77m328iedvF4eRZEXetgmBHnR4ePFgo0UEwbKpX/mJf?=
 =?us-ascii?Q?ua2CU1zjqutESLuedUzdO4ZYRF9q37qWMmaDYfaMfQXQcPJ6+qaLLFDMUZXt?=
 =?us-ascii?Q?Ak+Ffq9O8xi5Y67dZdn2u2vrGw9CX4bS/iteGYRZY0O+JVzvXG9jcqhJ0RYM?=
 =?us-ascii?Q?fci2bdt1SAly3KuyuQuxhllc1s6b8VaDwoeqCfR42wUj5zMkFVLG9ngf+oUe?=
 =?us-ascii?Q?z+9yzsXMZlwiqm8LBterA7F/fDm+SIyDiLi7RQTsM46jVh+z8R+hKMdFbrUe?=
 =?us-ascii?Q?5vCVAz4DTPgQgw+iRDLq3NdWbl63cZBZWDeSkwKdwbZH4/jdEZSDXjH95GxH?=
 =?us-ascii?Q?jLPZWjguD14UZ8Y2ffOp9laW?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ddff57d1-2431-4e74-12a6-08d97916e3c7
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 13:35:47.0557
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Vy0GT21oIPZsB50L47U3t0v1l7L4Gph8UC3KVmwW5nXjErstNHUxqdmroWVZ+WgfzV/EVOTHb0rDNYVa08FVDg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5553
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10109 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 malwarescore=0
 adultscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109160086
X-Proofpoint-GUID: 3r-gevJr2KQdOdpNGk70154A6UhEbidF
X-Proofpoint-ORIG-GUID: 3r-gevJr2KQdOdpNGk70154A6UhEbidF
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

stack_depot_save allocates slabs that will be used for storing
objects in future.If this slab allocation fails we may get to
a situation where space allocation for a new stack_record fails,
causing stack_depot_save to return 0 as handle.
If user of this handle ends up invoking stack_depot_fetch with
this handle value, current implementation of stack_depot_fetch
will end up using slab from wrong index.
To avoid this check handle value at the beginning.

Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
Suggested-by: Vlastimil Babka <vbabka@suse.cz>

Acked-by: Vlastimil Babka <vbabka@suse.cz>
---
 lib/stackdepot.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 0a2e417f83cb..67439c082490 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -232,6 +232,9 @@ unsigned int stack_depot_fetch(depot_stack_handle_t handle,
 	struct stack_record *stack;
 
 	*entries = NULL;
+	if (!handle)
+		return 0;
+
 	if (parts.slabindex > depot_index) {
 		WARN(1, "slab index %d out of bounds (%d) for stack id %08x\n",
 			parts.slabindex, depot_index, handle);
-- 
2.30.2