Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     vbabka@suse.cz, geert@linux-m68k.org, akpm@linux-foundation.org,
        ryabinin.a.a@gmail.com, glider@google.com, andreyknvl@gmail.com,
        dvyukov@google.com, maarten.lankhorst@linux.intel.com,
        mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie,
        daniel@ffwll.ch
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        intel-gfx@lists.freedesktop.org, linux-mm@kvack.org
Subject: [PATCH RESEND v3 2/3] lib, stackdepot: Add helper to print stack entries.
Date:   Thu, 16 Sep 2021 23:35:34 +1000
Message-Id: <20210916133535.3592491-3-imran.f.khan@oracle.com>
In-Reply-To: <20210916133535.3592491-1-imran.f.khan@oracle.com>
References: <20210916133535.3592491-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PtEAU187fu+/0W2gJFPJB68US1Q/mShYGjElkxD11pj4s50+SrAOqrZVS+R9?=
 =?us-ascii?Q?xf60QkLFw72Tp6vBZlAMvd0SWeCHyvKsm0DFay4a2AwzKIyz6OREcoZtzSzG?=
 =?us-ascii?Q?LikcnHIz/xXehi+6KXR0o3M24kZwvyDWFVCRXNOIBMcjmeH0W1huU333kPRv?=
 =?us-ascii?Q?PBIkqVA6wSHuOZayVVkD2idz90TXyAaFYX4QpNwGY9hKU7znxZKf6g5wBB0c?=
 =?us-ascii?Q?QI89qrOxUYSWwqiQ9oeGgBmLMHEO/68Nh/K9v79dtI7Wbmx/EAlBom9/jCpF?=
 =?us-ascii?Q?5Ppl8dTCD4SHgSXULm/5XzHM/GQW9H/yrcedJW3cAZmi4YS9eRdoNK3M2vDa?=
 =?us-ascii?Q?GKODoQ+H01ZVQ9lLwUKhVPsNJ6EerfomOQELQgpDMKEw5IqN+jeb972AvEuz?=
 =?us-ascii?Q?saVt1TGuTfMLIukKvKnxeIg5nT4nXVpyVg2Mhhaj5WjlykYkFnmEmjXUDSW+?=
 =?us-ascii?Q?RG/MHxvcJNuY9LsQJHHieJSkCz6gLo4duQ5RBLSbfD2NRNxMyjzEq+G83AcO?=
 =?us-ascii?Q?KyAHC1qn6BDWZeUb67NVacT4BQzZaHYCiV2NW2scQQA4h1O9jN4c+EYXJ8NA?=
 =?us-ascii?Q?iyERD3602TSABK5QupLc+V1afhT0xi0jdW+otT5gVwCkUhxBj2IaaVBfeUhT?=
 =?us-ascii?Q?ooKxMK372/QZ7BkrwNt0um16f4UZth4kE0JdGbzj7ejpqT1N6G8oQl1q4mGe?=
 =?us-ascii?Q?ryCT6Y5GAkNsWbhb325vVl8gabhf9GU+FZCaT7qmHzF2NY9BoeqC8QnQuRhK?=
 =?us-ascii?Q?3Ge30RmbFcLKGMV+fCmh5ioLa9j0ttbM/sCxl2gKQFP8rGS/WdPLHFZ+w5Vl?=
 =?us-ascii?Q?gmVm/YKD5zr1by1DComZyX6DUb2KDwxsCIci9ru8FuUgYePbDEFSh3sIxZsQ?=
 =?us-ascii?Q?SARdz3b66radLnvIj5clveLGyjCL+D9p5e/cWdUji42M/4W7x9SEi93Zabky?=
 =?us-ascii?Q?ESZn5J38ckdPljVYYTbtS9VtmqXHtN8gmaB/mOENhZZPYpbLIZJNKRLWxIam?=
 =?us-ascii?Q?GchnGNVLpgJUymBQBfgVRxB7nN6n3Ksl2WY5DUwRyO2yqrARhFlp7f+fZ9QW?=
 =?us-ascii?Q?PEDm5plJoZxMXKz5NdEvzjXHX/MHnPfAy5++GxRPEtvRsChRN2vjm2uu7Lw0?=
 =?us-ascii?Q?DR862I9Uq+VsrOaVmpDB4rDbZc0e4wVyu6+v9BsfTv5OLpGitKAw5j5/ry8f?=
 =?us-ascii?Q?hfA7f2GYNbdP6WEZJIJRNcXHoVZePRg9EFVw65+FXdjEGJTlM2NvCMt3DpGr?=
 =?us-ascii?Q?AgsaAyxvYOff39O6ZT6uKKdnJoxy3c6MXySAOY73FQ9ArviO04fGuZJKMBl3?=
 =?us-ascii?Q?Mhd+ZzpnMFT22vyqxZ2rwUSi?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 76386376-b021-4bfe-9bce-08d97916e6a5
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 13:35:51.6993
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: I6XpVfrWld3wDGQZqLYlfp66viGkf0R6wcpfGzioFeW6rijcW9fDtNhXo0dnAEGM3YMZDjGbgQX0HvTIpb4xOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR10MB5572
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10109 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109160086
X-Proofpoint-GUID: 0aRCC4A6EcNd4V9Tz7sex4gGDkYD4kzC
X-Proofpoint-ORIG-GUID: 0aRCC4A6EcNd4V9Tz7sex4gGDkYD4kzC
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

To print a stack entries, users of stackdepot, first
use stack_depot_fetch to get a list of stack entries
and then use stack_trace_print to print this list.
Provide a helper in stackdepot to print stack entries
based on stackdepot handle.
Also change above mentioned users to use this helper.

Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
Suggested-by: Vlastimil Babka <vbabka@suse.cz>

Acked-by: Vlastimil Babka <vbabka@suse.cz>
Reviewed-by: Alexander Potapenko <glider@google.com>
---
 include/linux/stackdepot.h |  2 ++
 lib/stackdepot.c           | 18 ++++++++++++++++++
 mm/kasan/report.c          | 15 +++------------
 mm/page_owner.c            | 13 ++++---------
 4 files changed, 27 insertions(+), 21 deletions(-)

diff --git a/include/linux/stackdepot.h b/include/linux/stackdepot.h
index 6bb4bc1a5f54..d77a30543dd4 100644
--- a/include/linux/stackdepot.h
+++ b/include/linux/stackdepot.h
@@ -19,6 +19,8 @@ depot_stack_handle_t stack_depot_save(unsigned long *entries,
 unsigned int stack_depot_fetch(depot_stack_handle_t handle,
 			       unsigned long **entries);
 
+void stack_depot_print(depot_stack_handle_t stack);
+
 unsigned int filter_irq_stacks(unsigned long *entries, unsigned int nr_entries);
 
 #ifdef CONFIG_STACKDEPOT
diff --git a/lib/stackdepot.c b/lib/stackdepot.c
index 67439c082490..354fe1b62017 100644
--- a/lib/stackdepot.c
+++ b/lib/stackdepot.c
@@ -214,6 +214,24 @@ static inline struct stack_record *find_stack(struct stack_record *bucket,
 	return NULL;
 }
 
+/**
+ * stack_depot_print - print stack entries from a depot
+ *
+ * @stack:		Stack depot handle which was returned from
+ *			stack_depot_save().
+ *
+ */
+void stack_depot_print(depot_stack_handle_t stack)
+{
+	unsigned long *entries;
+	unsigned int nr_entries;
+
+	nr_entries = stack_depot_fetch(stack, &entries);
+	if (nr_entries > 0)
+		stack_trace_print(entries, nr_entries, 0);
+}
+EXPORT_SYMBOL_GPL(stack_depot_print);
+
 /**
  * stack_depot_fetch - Fetch stack entries from a depot
  *
diff --git a/mm/kasan/report.c b/mm/kasan/report.c
index 884a950c7026..3239fd8f8747 100644
--- a/mm/kasan/report.c
+++ b/mm/kasan/report.c
@@ -132,20 +132,11 @@ static void end_report(unsigned long *flags, unsigned long addr)
 	kasan_enable_current();
 }
 
-static void print_stack(depot_stack_handle_t stack)
-{
-	unsigned long *entries;
-	unsigned int nr_entries;
-
-	nr_entries = stack_depot_fetch(stack, &entries);
-	stack_trace_print(entries, nr_entries, 0);
-}
-
 static void print_track(struct kasan_track *track, const char *prefix)
 {
 	pr_err("%s by task %u:\n", prefix, track->pid);
 	if (track->stack) {
-		print_stack(track->stack);
+		stack_depot_print(track->stack);
 	} else {
 		pr_err("(stack is not available)\n");
 	}
@@ -214,12 +205,12 @@ static void describe_object_stacks(struct kmem_cache *cache, void *object,
 		return;
 	if (alloc_meta->aux_stack[0]) {
 		pr_err("Last potentially related work creation:\n");
-		print_stack(alloc_meta->aux_stack[0]);
+		stack_depot_print(alloc_meta->aux_stack[0]);
 		pr_err("\n");
 	}
 	if (alloc_meta->aux_stack[1]) {
 		pr_err("Second to last potentially related work creation:\n");
-		print_stack(alloc_meta->aux_stack[1]);
+		stack_depot_print(alloc_meta->aux_stack[1]);
 		pr_err("\n");
 	}
 #endif
diff --git a/mm/page_owner.c b/mm/page_owner.c
index d24ed221357c..7918770c2b2b 100644
--- a/mm/page_owner.c
+++ b/mm/page_owner.c
@@ -394,8 +394,6 @@ void __dump_page_owner(const struct page *page)
 	struct page_ext *page_ext = lookup_page_ext(page);
 	struct page_owner *page_owner;
 	depot_stack_handle_t handle;
-	unsigned long *entries;
-	unsigned int nr_entries;
 	gfp_t gfp_mask;
 	int mt;
 
@@ -423,20 +421,17 @@ void __dump_page_owner(const struct page *page)
 		 page_owner->pid, page_owner->ts_nsec, page_owner->free_ts_nsec);
 
 	handle = READ_ONCE(page_owner->handle);
-	if (!handle) {
+	if (!handle)
 		pr_alert("page_owner allocation stack trace missing\n");
-	} else {
-		nr_entries = stack_depot_fetch(handle, &entries);
-		stack_trace_print(entries, nr_entries, 0);
-	}
+	else
+		stack_depot_print(handle);
 
 	handle = READ_ONCE(page_owner->free_handle);
 	if (!handle) {
 		pr_alert("page_owner free stack trace missing\n");
 	} else {
-		nr_entries = stack_depot_fetch(handle, &entries);
 		pr_alert("page last free stack trace:\n");
-		stack_trace_print(entries, nr_entries, 0);
+		stack_depot_print(handle);
 	}
 
 	if (page_owner->last_migrate_reason != -1)
-- 
2.30.2