Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] platform/x86: amd-pmc: Check s0i3 cycle status
To:     Sanket Goswami <Sanket.Goswami@amd.com>, hdegoede@redhat.com,
        mgross@linux.intel.com
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210916124130.2581-1-Sanket.Goswami@amd.com>
From:   Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Message-ID: <1787c8b1-b539-a619-b7b5-58ca829baa57@amd.com>
Date:   Thu, 16 Sep 2021 18:29:52 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
In-Reply-To: <20210916124130.2581-1-Sanket.Goswami@amd.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Wjlzb0hVMHZtWTJTOGt6eHlhbXlsV0dhdUIyNGR0dDF4MUY5ajBNSzIybC9Z?=
 =?utf-8?B?eG95YkVEbWJPZWd4QzVvV1lBTEhNR2xXZjJ2YmdoM3gwUGNsanlQOEtZRCtV?=
 =?utf-8?B?aVBtcy9rVkVobVZ3RmZieTA2VUJqQmlrZ081di9RbkxBOUJOT3dreXhqUVVR?=
 =?utf-8?B?cmVyVGxTTTR6anZ0emVEY09EVzM0anZvNExEdEIyOTlYdVhFWisvYW1walFp?=
 =?utf-8?B?TGFCVWNmcGNONStTVlpkZG9xQmkvRWtEMUp2WWx0K3lzeFUzQThUYUwrK3l5?=
 =?utf-8?B?b3JEcVNVNlpXSFkrZ2FiR3BRYTAxcnlRZ3JnSUVYWFAxUk5zNWNWUnNSSmRz?=
 =?utf-8?B?MDAvd0IwSGVRTllIWllrdGVqbitnSkxTRWc1S3dWOWRycXlQcTV2UHJSZnIz?=
 =?utf-8?B?VmwxQlFja3lLWWJYbUtURk5XOUx5WmxRYnh6TzFjOUtQdWltcGM4UTg5Nyth?=
 =?utf-8?B?eWJWSE5WT3NzK0IrejhzdWxDVHYxUVpaQVpDd1ZNREVjeGVkTDkrTXVLWUtt?=
 =?utf-8?B?aEl5ekFHMXd4Yy9uSUd6cGNCQjVQTm1GWGRjeG94Q2s2TG11M090bWQzdlow?=
 =?utf-8?B?RHhjQkl2NVl5NW5JcVFlWXBXS1UwU0Y5ZEJrMGpzZVRtRXhHQWQ4aXNoYjZK?=
 =?utf-8?B?QnFhbEV1WC8vRDlsYnpaSDNFYVZ3cUZaWkZ1V3BUcU50aC9qZ3BZYlJYYUlr?=
 =?utf-8?B?M2xBKzVXdlVhWGY1d2lIUktVNWJnTnZyMFJWTmM5RVZWOVVJUmpidGhwa1VS?=
 =?utf-8?B?ZUpJZnM2TG9xTUdtTlhqM1ZPOTN6MUtkaTAyVThHTEhSOHhhN0ptRDNKTnZZ?=
 =?utf-8?B?YTBwd3RReXBzdHpwclRjSHhzcCt3RGlQQ1FZZFJmMk81bllrRkk1bE9XNGEw?=
 =?utf-8?B?R3dIQWwxM1VPNi9NVGdWUy9SZ1JYRFp3V1VLSlNLdVo4T3o1c01DeFRWaCtO?=
 =?utf-8?B?MzRSSEF2N09jajd4enBNYitISXZIUnREQyt0YS80WmlnS1lRaDlrL204c21y?=
 =?utf-8?B?ZjhwUFZhdU5GUko5Z3FRdzJIN3hlNzBOUnJTZktkQzJwbWdZY29CVkVTS2dn?=
 =?utf-8?B?UlNFYjkwREVaOEkrYS9LckdpaHZFbUsxNVlWS2FQSTNsMjBOWGdZLzhCd0Nn?=
 =?utf-8?B?L3FMSDFjWitGdGFSWHFFSWpINEJlK2Yza3dGeFNFeXJPSHZSL093ejc5NHls?=
 =?utf-8?B?Vy9HRzdKTEhaZFgyT1pFaEpRd2cvZUJMenQ0Vkh1MzQ1V1h3ZjlCZXBCVnZX?=
 =?utf-8?B?TFNvd1hSaUJreHlLZm5iVGszeVUvcHMwU0tyR3ZRZTNzL0h0QWZGRnU1ZmJ0?=
 =?utf-8?B?SXFOQVFPMGVYNWx3S2dyNGdmcHEwQjFjcGxhTm91Qit6d1ZHc2hZTCtVR29z?=
 =?utf-8?B?b01QTkQwOTduQ0dmOHBKSDloWUpLOG9sSzZ6MldjVWtsTlk5SS8wd1ZxOFNC?=
 =?utf-8?B?ak5xUnUzQVZXc3FPU1UrMW5oS0dQelJxM05VY0NCbDBzQ1VKZDFyMnhvWDJ1?=
 =?utf-8?B?N3Q2dXhxelpKU3pObit4Z3d4cTU2TWthVVpadGVVQWNkd3lPNndXdEszRGZa?=
 =?utf-8?B?SFBudnB4czh6cWhTYW1lZzdWTjBuVVhRMGplWU1QZkI1dmdHMklIdUltTk9m?=
 =?utf-8?B?L3dKQmlQcHVDVkU3SkNBY3kwODdmcW5vQWVPT2hKK1RmTDVia0dpQ1puRjN6?=
 =?utf-8?B?MVlEaS9WZkh5elppRFZmUlk2TFJnaXc1Z2xlelcycE1nTFZHZXBJaDlGNWxa?=
 =?utf-8?Q?Wi/soHLgZQuLW4kd30GTQ2SrQmVgR0Fx7frhPnF?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bf9ac9e9-a888-4812-2192-08d97911e638
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 13:00:03.5261
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TTq1lUMoJBf7KBkaQlWBWsTUwWKB2FX7qnB91qGlp3SyAMQEI+4xQJZO+uqFjGDeFllGWTg7mK+V/uYJ5/9Ozw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5254
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/16/2021 6:11 PM, Sanket Goswami wrote:
> As the PM firmware returns the status of the last s0i3 in the smu_metrics
> structure, the existing name "s0i3_cyclecount" seems to be a misnomer.
> Change it accordingly to "s0i3_last_entry_status".
> 
> Signed-off-by: Sanket Goswami <Sanket.Goswami@amd.com>
> ---
>  drivers/platform/x86/amd-pmc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c
> index 0c970f613e09..91c1f1c6c929 100644
> --- a/drivers/platform/x86/amd-pmc.c
> +++ b/drivers/platform/x86/amd-pmc.c
> @@ -141,7 +141,7 @@ static inline void amd_pmc_reg_write(struct amd_pmc_dev *dev, int reg_offset, u3
>  struct smu_metrics {
>  	u32 table_version;
>  	u32 hint_count;
> -	u32 s0i3_cyclecount;
> +	u32 s0i3_last_entry_status;
>  	u32 timein_s0i2;
>  	u64 timeentering_s0i3_lastcapture;
>  	u64 timeentering_s0i3_totaltime;
> @@ -170,7 +170,8 @@ static int smu_fw_info_show(struct seq_file *s, void *unused)
>  	seq_puts(s, "\n=== SMU Statistics ===\n");
>  	seq_printf(s, "Table Version: %d\n", table.table_version);
>  	seq_printf(s, "Hint Count: %d\n", table.hint_count);
> -	seq_printf(s, "S0i3 Cycle Count: %d\n", table.s0i3_cyclecount);
> +	seq_printf(s, "Last S0i3 Status: %s\n", table.s0i3_last_entry_status ? "Success" :
> +		   "Unknown/Fail");
>  	seq_printf(s, "Time (in us) to S0i3: %lld\n", table.timeentering_s0i3_lastcapture);
>  	seq_printf(s, "Time (in us) in S0i3: %lld\n", table.timein_s0i3_lastcapture);
>  
> 

Looks good to me.

Acked-by: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>