Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1478704pxb; Thu, 16 Sep 2021 08:17:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0SukIvxcvK6nFUWPLyEiUP1SJ3SaZ8ycokTkJ41iFafau91uX7VEuusyVNPvFbsvbYSgg X-Received: by 2002:a92:c9c8:: with SMTP id k8mr4519670ilq.51.1631805468356; Thu, 16 Sep 2021 08:17:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631805468; cv=none; d=google.com; s=arc-20160816; b=cFuR0mXr2ayrBGzHBydILZtoe2+O3d4CXcwdDtfhO2/SR0ys8OKs8KWmtBcExU2L0M /b2BgF5n04dBRAlnSNja3NmP74+PkUFb+Jt6FtooS/DOMatpmVDrpjjk4+dUZkU9DMo+ SLvfTR8GSC0sSrNEK87nitNAD6t+Gbibj4S80Ao74Ly+eMZmsMZgarZACHC/TdJhgPnr c3ZGctKLRNum8imHJ1HnfRJaRhQVBd/IA0e1WMkCAJ3dOKmJWhq8b9BZgr1R3Qt+0HAh HKjzxR2Avj/hzvB8UzWv9cF2FC5/wlCI8l9UleZ8YeKTVAgUSVsR1YTmT+Mav7VDHgLv +dbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=sXPKIv1Z5blwcAQur9L48AooSj2mfgTEzoX9n61thXY=; b=YcuWGuqDLRb5g4T0f7mnBu3WOmR1q/hyCkKnWNRLcs63OTTUAksi7a/X50vMwG5njm /Cr/ltQA0GDC6ZFK6Rq0eznAhoGJe3/leUrmrfG+G+HkX+WCiOSgUdkyFk/baQ1+zvUV 23Ecsus1uhaiFCTLKYJ+abb0neNi0qMh/rpbylD+jFa8VwmE/JMuhzfQruYowi/m3H3k bhNkM4Xoy7/4KldslwOlFrV6j4Ui4ZnnrLfzu45qxwbp1537vylB+jXDC8OMIG6mY724 pbwLWvF7nIvn21ELlSOfblpdRPjzYCEmvFUex14moNJnpY4naOd34ZL0E+6XAU6Y0dih i46Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=otlLfJpa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v2si2633003iot.49.2021.09.16.08.17.35; Thu, 16 Sep 2021 08:17:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@canonical.com header.s=20210705 header.b=otlLfJpa; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238647AbhIPOmh (ORCPT + 99 others); Thu, 16 Sep 2021 10:42:37 -0400 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:52704 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238671AbhIPOmf (ORCPT ); Thu, 16 Sep 2021 10:42:35 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 7A61F3FE09 for ; Thu, 16 Sep 2021 14:41:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1631803273; bh=sXPKIv1Z5blwcAQur9L48AooSj2mfgTEzoX9n61thXY=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=otlLfJpaMdoB8RAvk4PlL2sJvbDgrcXli09EPpALNJ6w7LRceUN2wddUWfcNu2S6K tjb0vXQv7fapBaUQUfrLHU/owfH/TQP5du1HURCNBuB3mTY91XUo5urcFFe8MNT/vl qlRsScIYbCFJYfLwi84ed22Agun2LHqr9bcsgL4FLmwySt6C+iToFIxqujksDr3zCI j2KJ/nq95MgMKrBJZEQ4N7vhzEqY7h//zukc+Mii7dI7+O8MnJE07XRSN4MumguBUe 1FrHFdJhEaZ0Dcm8JqqIlEhLuVDFg7Rr0lhjy/gXGLK4EpvlSofRKZSLaMwlldaQQB X9aXGzZqQKXnQ== Received: by mail-wr1-f70.google.com with SMTP id x2-20020a5d54c2000000b0015dfd2b4e34so2518955wrv.6 for ; Thu, 16 Sep 2021 07:41:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=sXPKIv1Z5blwcAQur9L48AooSj2mfgTEzoX9n61thXY=; b=1it67HCqr+u1vpFghqYAezN6KHhdAOCFCQQoL3Z64aJwqpp0/2PHeTCscLfAhk/o+k YOremzul4HlbBQT3LLWTdonsLZjwsUaFLwIgL3KT4bwafrSYZzfbUmvD9vEzAtD/1aSt nzxxbf+ANw2Z5wcaNetIQ+iDAdkxLpvj/bFswvXdIy+P6NRDj4UxmJ/5JrMQCcocBpAe 0kJP1NLT1VbnyaHx8EjVFYW8LE9PSXhKPb4e1mkW692TU0NOkq/Zi67B7g3tptN/xlI4 WtmNudlEdIllt/tSAXnX/KV7HGHF8Fr181p01S8P0YXwj7yfEHgwimpiYJfyyVKYL8TG Ofow== X-Gm-Message-State: AOAM532aGQD566+4OQBOrD+1x+YfMz2WWy6/HJ1ffGoEfQnCgk9d2OMe HsRR1iFQhKC+FUkEr3X1mJx6wGowCTSoEQlCjLmdgUuS9MYsJQYZmJNa8JR/o2tmLOkDfFCahPn MyvwJFcdV7CZT+Btd5qssP8B/D7JYoVPRKJyGYiQVtA== X-Received: by 2002:adf:eb02:: with SMTP id s2mr6626645wrn.294.1631803273237; Thu, 16 Sep 2021 07:41:13 -0700 (PDT) X-Received: by 2002:adf:eb02:: with SMTP id s2mr6626629wrn.294.1631803273061; Thu, 16 Sep 2021 07:41:13 -0700 (PDT) Received: from kozik-lap.lan (lk.84.20.244.219.dc.cable.static.lj-kabel.net. [84.20.244.219]) by smtp.gmail.com with ESMTPSA id u25sm7741432wmj.10.2021.09.16.07.41.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 07:41:12 -0700 (PDT) From: Krzysztof Kozlowski To: Chanwoo Choi , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Liam Girdwood , Mark Brown , Marek Szyprowski , linux-kernel@vger.kernel.org Subject: [RFT][PATCH] regulator: max14577: Revert "regulator: max14577: Add proper module aliases strings" Date: Thu, 16 Sep 2021 16:41:02 +0200 Message-Id: <20210916144102.120980-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 0da6736ecd10b45e535b100acd58df2db4c099d8. The MODULE_DEVICE_TABLE already creates proper alias. Having another MODULE_ALIAS causes the alias to be duplicated: $ modinfo max14577-regulator.ko alias: platform:max77836-regulator alias: platform:max14577-regulator description: Maxim 14577/77836 regulator driver alias: platform:max77836-regulator alias: platform:max14577-regulator Cc: Marek Szyprowski Fixes: 0da6736ecd10 ("regulator: max14577: Add proper module aliases strings") Signed-off-by: Krzysztof Kozlowski --- Not tested. Please test/comment. This is an RFT also because reverted commit said to fix autoloading issue which I even reviewed... but really it should not be needed - alias gets duplicated. --- drivers/regulator/max14577-regulator.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/regulator/max14577-regulator.c b/drivers/regulator/max14577-regulator.c index 1d78b455cc48..e34face736f4 100644 --- a/drivers/regulator/max14577-regulator.c +++ b/drivers/regulator/max14577-regulator.c @@ -269,5 +269,3 @@ module_exit(max14577_regulator_exit); MODULE_AUTHOR("Krzysztof Kozlowski "); MODULE_DESCRIPTION("Maxim 14577/77836 regulator driver"); MODULE_LICENSE("GPL"); -MODULE_ALIAS("platform:max14577-regulator"); -MODULE_ALIAS("platform:max77836-regulator"); -- 2.30.2