Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1540145pxb; Thu, 16 Sep 2021 09:31:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzcgkpquOUZVf3XCL210YLsOwOjfz2l2JHsIf7Lea62L/3kFmsCv8D8CNwY7cW4mrQsHX1h X-Received: by 2002:a5e:8d04:: with SMTP id m4mr5082392ioj.149.1631809808658; Thu, 16 Sep 2021 09:30:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631809808; cv=none; d=google.com; s=arc-20160816; b=jWOjDy+1Nbvpvs6k2+LTVWBlvHRcOxASXjTCu+wvfBFpYSsdzVJo1BTRFgT/MyLTa/ +Ld1TmlQz+wzZD78YH7LEHcV/NG25jztEhskGk2cA+w4nkei1gYi/Z7MzHakrlsB6d4s bkZegVcKli0EWUi14OE3zzNsHDFeoTwtqtRvj3ivrqUBqTcTY83fi1GOv2UCzpxJ3p+x oghs8kvbL1HfmcBwA8HOF91JX1iP9R2IfISXyWISZnUhH4E9AEmXCQXiRMN6q5wpOzQE m11kX2aWN8iwac0TYwEMoJZbgyrNvxnaxF2p7+vIz/ujiFhRmBcJ1Q5zGfErQSU4dQRO ZnGw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1GuYFlnzwURiXq+nncd8G18YDO/LQTALfG1k7qp2w/c=; b=P45mehLjdLh+z/HEWro/zhHBxnYF063dlMyRTpPN91n+lV+HU/ZH9VbaDJKl26ba1g +Y4bimFIAMqBpXoJor6HbTE1BLtrIYFXpIVEzzZWERWGiWJIt+0d23oCMrNpSfXIWTfr R84onL08+1MbSIpWTTiiSNhL9REFsNw4abrDdttP92h6SHcZpY4re+D85VGFnsbrdcKR pQd/zt4UF0FK9DSzLkWdnXSyBfOoj79/voP+nz0oAJeEBWM7laXPcNmVw2KutTNgpbyb 7EPCl3f50dee7NV6eC29x+dvprpIweUPixm2SFKcHdEcGpo06BfsGd/wkozHtKAoLdPo oZ+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bkaDilMs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n38si2943423jaf.72.2021.09.16.09.29.56; Thu, 16 Sep 2021 09:30:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=bkaDilMs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242718AbhIPQ33 (ORCPT + 99 others); Thu, 16 Sep 2021 12:29:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:54974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241183AbhIPQPT (ORCPT ); Thu, 16 Sep 2021 12:15:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1162613AC; Thu, 16 Sep 2021 16:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631808675; bh=QoClUXnsgUsdkKIUK3S7YihV40s5FkTGnHPGa3PGaME=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bkaDilMsJ9f1doBP2lnXeoVAmjGR0KElIcSMnjy3GtLrzRk4xiaoekXiQFw1+u++b GKiJMe5cHSh5k3db8dcsez8hTB67nQSD4wok7fndSuihh4mIFInP/xhR43YB+y43oc H7fL7rvR/g2SvufnDcKbGrrQUfGvs0UY8pNPVUzU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oak Zeng , Christian Konig , Alex Deucher , Sasha Levin Subject: [PATCH 5.10 148/306] drm/amdgpu: Fix a printing message Date: Thu, 16 Sep 2021 17:58:13 +0200 Message-Id: <20210916155759.101621605@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155753.903069397@linuxfoundation.org> References: <20210916155753.903069397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oak Zeng [ Upstream commit 95f71f12aa45d65b7f2ccab95569795edffd379a ] The printing message "PSP loading VCN firmware" is mis-leading because people might think driver is loading VCN firmware. Actually when this message is printed, driver is just preparing some VCN ucode, not loading VCN firmware yet. The actual VCN firmware loading will be in the PSP block hw_init. Fix the printing message Signed-off-by: Oak Zeng Reviewed-by: Christian Konig Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index aa8ae0ca62f9..e8737fa438f0 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c @@ -120,7 +120,7 @@ static int vcn_v1_0_sw_init(void *handle) adev->firmware.ucode[AMDGPU_UCODE_ID_VCN].fw = adev->vcn.fw; adev->firmware.fw_size += ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE); - DRM_INFO("PSP loading VCN firmware\n"); + dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); } r = amdgpu_vcn_resume(adev); diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c index fc939d4f4841..f493b5c3d382 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c @@ -122,7 +122,7 @@ static int vcn_v2_0_sw_init(void *handle) adev->firmware.ucode[AMDGPU_UCODE_ID_VCN].fw = adev->vcn.fw; adev->firmware.fw_size += ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE); - DRM_INFO("PSP loading VCN firmware\n"); + dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); } r = amdgpu_vcn_resume(adev); diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c index 2c328362eee3..ce64d4016f90 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c @@ -152,7 +152,7 @@ static int vcn_v2_5_sw_init(void *handle) adev->firmware.fw_size += ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE); } - DRM_INFO("PSP loading VCN firmware\n"); + dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); } r = amdgpu_vcn_resume(adev); diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c index c9c888be1228..2099f6ebd833 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c @@ -148,7 +148,7 @@ static int vcn_v3_0_sw_init(void *handle) adev->firmware.fw_size += ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE); } - DRM_INFO("PSP loading VCN firmware\n"); + dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); } r = amdgpu_vcn_resume(adev); -- 2.30.2