Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1542413pxb; Thu, 16 Sep 2021 09:34:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMsSEeO+5Vo0XmGLKpaRqCnGxGhz3bbboprJ4oEL7UbGxPvNgztRzP32PUop4gmp9nOwCk X-Received: by 2002:a05:6638:3046:: with SMTP id u6mr5098493jak.35.1631810061472; Thu, 16 Sep 2021 09:34:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631810061; cv=none; d=google.com; s=arc-20160816; b=TlS/rdL9/i7w706FjB+A8ZHehf2a1gZPd+S3fCIuSjsD88ZEvSrdEsuW7Mx3pYUb5j Pyr8BJys/9P8V4IrfzM5QE2MEf0ITSB/Ie4doUh94EmzczLlZnh+M4BPEfAHoVDMsCXk h3ms98+NKVYM4mIB83RHaKg02/ZjmYyrneEIUV7sp82Ccjo+qxRVNpmPiw2MCbxes9tp AK/4yQKxUCOv01NQUe9sF8nd2DbDAQcauR0W9kFTQA+ddzt+sqsFoQCjtkfKCXK+cTZ1 cuxbdjKZpzTJGGChLUoKdZS1CeyRCwakoLsjY8WHY4LlyZhklQHPs+0xCD4BXjpBxRLv 0hQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6cPNXD7P/Vh3TgqaY0BczumHKqSDYLrVV50813RqSos=; b=mvoQ2IBCBsTP0aZxo1UOyZRK9a4P+pg+KGr9XiYkeJaQ9A3g7aPjU8XqZMZmr23Iih oyqXwIs/4FQsYXJk/Rl1iYWhxp6Yu+HjQEDx5egGQJNwEEWupPk5CxEuhmFyWGa1wv+e YvVGOByoam97QzOdEjnPmuh93OqVWcQEaYi9O5L6KbH4IdDkWVHjQOZI+cTtJIJuNZ9E JcdVG6PceReqSfbkhnjDyG7GW7cu3L6c7uwIK5UQ3zenrSCQUT62xRx5Jlz0wh3cPulA npZijvVSWw6+B0ZFu6qfnAAojTBtDGhWdM5bnyza/Q8m8gcf5RKl8hzw8gelhf9ybWdf UnGw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=d9BGWFrL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n16si3925770jan.32.2021.09.16.09.34.08; Thu, 16 Sep 2021 09:34:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=d9BGWFrL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241186AbhIPQdK (ORCPT + 99 others); Thu, 16 Sep 2021 12:33:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:37000 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241262AbhIPQYu (ORCPT ); Thu, 16 Sep 2021 12:24:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1C17613D5; Thu, 16 Sep 2021 16:16:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631808988; bh=lKfQLl80sJAtRksVLfOVG9Ax5WTP8K6CA8bju2R/rjI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d9BGWFrLqMNc+0+KSgj9gZ3jFjpk9IGkwkM0fsos0SU/Diwb/6go7uN/aityEARtZ dcDXcitMyN1tyNetcn0BfHbwYIUmG/uyLWWxp/yeBp3aXN/+3AJOsHpI7ZXpNdxUtb HzwuM5P6V2kx0y5ohVPnOt6dsBUuM34GVk4bj8hA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, David Heidelberg , Rob Clark Subject: [PATCH 5.10 297/306] drm/msi/mdp4: populate priv->kms in mdp4_kms_init Date: Thu, 16 Sep 2021 18:00:42 +0200 Message-Id: <20210916155804.220512364@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155753.903069397@linuxfoundation.org> References: <20210916155753.903069397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: David Heidelberg commit cb0927ab80d224c9074f53d1a55b087d12ec5a85 upstream. Without this fix boot throws NULL ptr exception at msm_dsi_manager_setup_encoder on devices like Nexus 7 2013 (MDP4 v4.4). Fixes: 03436e3ec69c ("drm/msm/dsi: Move setup_encoder to modeset_init") Cc: Signed-off-by: David Heidelberg Link: https://lore.kernel.org/r/20210811170631.39296-1-david@ixit.cz Signed-off-by: Rob Clark Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c @@ -397,6 +397,7 @@ struct msm_kms *mdp4_kms_init(struct drm { struct platform_device *pdev = to_platform_device(dev->dev); struct mdp4_platform_config *config = mdp4_get_config(pdev); + struct msm_drm_private *priv = dev->dev_private; struct mdp4_kms *mdp4_kms; struct msm_kms *kms = NULL; struct msm_gem_address_space *aspace; @@ -412,7 +413,8 @@ struct msm_kms *mdp4_kms_init(struct drm mdp_kms_init(&mdp4_kms->base, &kms_funcs); - kms = &mdp4_kms->base.base; + priv->kms = &mdp4_kms->base.base; + kms = priv->kms; mdp4_kms->dev = dev;