Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1548365pxb; Thu, 16 Sep 2021 09:41:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyF59Kawhfoq391gNC2v4LW6cuQ5KwRa+vi1pq8Ep0MGipRLVRBXi4w/G7ByLNVAUOoZEWE X-Received: by 2002:a17:906:b052:: with SMTP id bj18mr7539935ejb.55.1631810471057; Thu, 16 Sep 2021 09:41:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631810471; cv=none; d=google.com; s=arc-20160816; b=Pw0g73+JJsWjJBx3ObJsABnurN/bBLZbsUQfL7UyVnK8UhmlXf8SbAhTJGwhvXIujv 4q+Wn4HHTTyta/hf+xzffubHwy51ifamnY9gj/rIXzy5t9tHLAtWAwbjWzW05yZ5OxrG 7PVIGYz8aDh0FriNnes1hxN0OeEkMvUBmihZA0wPpdpxA0/vKvM1BW9RWZY5JXw7G//F cnOABES5lkXpZHGCaJqbeK8lXxanLu4c0MzAifaXFDZRi05uVnZhIRsp81H7bAJh8nWx VDWpZkAjSnfGr3vm6ccj2+nzfGmI1jbc7VGbP9cdp24qOMnVxjckAHxwEsGhml+PBkmE 1Lvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=auG0NQNpY7lFr1KloZKGaPxy9eDQEGWC7U8HQoYRpCA=; b=BzGWAczMs4sZrmmSC2b0IcH3Tnh+W4l+uau/0XntRNpcHw9eYJG/WgzFVRx/K5Rdwn 3n+8gQ9XzLK4VFTSKowyhhtDybGJNliqR70Fi7Z3IO5QS8wcsG578t8kr1grXp8YCmDl N0KoxtuSNVWvABNMo2nEaAwWlPT9Gqy6kIagGHpk56E1JzoZHRqC9DMl+ivM6Yo7vq4W I99vHxgx+3HPu2uJ+M1KjME8Y8w9xnB6LnJxCzvViuJaUU1YLfPRHCKJigMwZc8Odzq+ 8/aYqvmh8/dNGpuKM/gOL6y8g/qecLnD5xa9F3hAZy2muDOPWliN03txHNuvZ4a1HEep SBkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZvAT4VMX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 6si5214626eje.339.2021.09.16.09.40.44; Thu, 16 Sep 2021 09:41:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZvAT4VMX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244853AbhIPQjw (ORCPT + 99 others); Thu, 16 Sep 2021 12:39:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:44760 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243445AbhIPQba (ORCPT ); Thu, 16 Sep 2021 12:31:30 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 28095613CF; Thu, 16 Sep 2021 16:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809170; bh=d0fHBIfx08XKWD8DTM9jPJ7oQy9BeJaZM42sdC6BiCM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZvAT4VMXb02HDnTu6K9ZnGCix3Arhmg+gJOhSz7CmV6SDWZB9KTzhYXM3c+zNWmoJ B4eMFgZDJ14PMT8HLBevkrJ7DLPIW0EjflKqsRPRflLcSFZKnJlGgv1YBdhC7lprdt iqJQEzPPAdiMFQ195vSY3S56YMysu8BQ2ozvaENs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pavel Begunkov , Jens Axboe Subject: [PATCH 5.13 056/380] io_uring: fail links of cancelled timeouts Date: Thu, 16 Sep 2021 17:56:53 +0200 Message-Id: <20210916155805.890592498@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pavel Begunkov commit 2ae2eb9dde18979b40629dd413b9adbd6c894cdf upstream. When we cancel a timeout we should mark it with REQ_F_FAIL, so linked requests are cancelled as well, but not queued for further execution. Cc: stable@vger.kernel.org Signed-off-by: Pavel Begunkov Link: https://lore.kernel.org/r/fff625b44eeced3a5cae79f60e6acf3fbdf8f990.1631192135.git.asml.silence@gmail.com Signed-off-by: Jens Axboe Signed-off-by: Greg Kroah-Hartman --- fs/io_uring.c | 2 ++ 1 file changed, 2 insertions(+) --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -1307,6 +1307,8 @@ static void io_kill_timeout(struct io_ki struct io_timeout_data *io = req->async_data; if (hrtimer_try_to_cancel(&io->timer) != -1) { + if (status) + req_set_fail_links(req); atomic_set(&req->ctx->cq_timeouts, atomic_read(&req->ctx->cq_timeouts) + 1); list_del_init(&req->timeout.list);