Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1554419pxb; Thu, 16 Sep 2021 09:48:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzwvetFLfHP5n8qPGgvhlDbs174c8F61nuJ/nzpt7nmaPwhrfmLLnXtLxgspysdyqOqY2Kb X-Received: by 2002:a6b:2bce:: with SMTP id r197mr5117122ior.212.1631810891623; Thu, 16 Sep 2021 09:48:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631810891; cv=none; d=google.com; s=arc-20160816; b=DXTDQ8Z80WDA/tN6UUM6emaqg2hQwye0HiBrKPCcfA5k78PSZRGAy5Pnte2Vi4Z5BB ifRicpmdTN8y3VZlTVkPBdTq7V3yp45ws84Tednq9OMxACF0rPNNIeZlI5mOClDzYrOk 8pqK79qO76G3CLs+bSAmKGK47L536JBGin04aQwjAN86vk4YZA8WM7tE/F0bnlF0rgc6 gzmWZkPvzBXYhhKWLwiAjYGZQMldXMfdAoqEn/UWlOsGu66w4EdD9qmgEzUH1XiqacGB CObz8Rz5f0UxP+m4M7uMZjQC4HHb/pz6kTg45QzMr7IAoMSVwwtWu9okh6wcmvuI9Yem 9DWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=ArZhYJu5hcPx/s+UVK5HEuxwnPcr9hv89oRTgYZITbA=; b=pLXIT8H2e6NEYziQzbZAw3YanchzjYpST4+1xZsSssYZVmjikKXBlIPx2eTn8ifloo D9AEgibCByTh/sS9RRGdBlCX8v1rNAnpUUdqq4z7fbq9HahlQ0EzFyUC02GJBjQr5EYr wCRgjxOCBI8Bn4Z4QQr33pthxQ0T5ETyuQBMdDiwoG5hYB2+zB7SIi8JT+Kc2ErfPIr6 iZgUv45K0RDXnI+jDscd7x3rHjhlJlP/gFd/n1OXRUW9QznRFLhTzcfr5+Jh6WkwarxF rAU7hye/h7xKY7kY7tLTj2bEZIciO1Eds6nGKaZvAZTBmD7+WIfRqDK4JUz5pqqEf0jX aSdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y28si3102526iot.48.2021.09.16.09.47.58; Thu, 16 Sep 2021 09:48:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244719AbhIPQrl (ORCPT + 99 others); Thu, 16 Sep 2021 12:47:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245686AbhIPQmF (ORCPT ); Thu, 16 Sep 2021 12:42:05 -0400 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 546B6C0613E8; Thu, 16 Sep 2021 09:14:11 -0700 (PDT) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQu1Z-004kaR-Ej; Thu, 16 Sep 2021 16:14:09 +0000 Date: Thu, 16 Sep 2021 16:14:09 +0000 From: Al Viro To: Michael Schmitz Cc: linux-m68k@lists.linux-m68k.org, Geert Uytterhoeven , Greg Ungerer , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] m68k: leave stack mangling to asm wrapper of sigreturn() Message-ID: References: <08183665-f846-0c5e-a8c7-d0a65e78a3da@gmail.com> <48dafad1-4f0c-4ab7-792c-b34a81d26799@gmail.com> <59a44e17-bff8-041e-b704-2b1d97601ce7@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59a44e17-bff8-041e-b704-2b1d97601ce7@gmail.com> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021 at 05:02:22PM +1200, Michael Schmitz wrote: > The only question that remains is whether the third patch can also go to > -stable. Most of my testing was with all three patches applied, I can drop > the third one and retest if you're worries the third one is not appropriate > for -stable. Up to m68k folks, really. The current mainline mangle_kernel_stack() is, er, not nice and the entire area is delicate enough as it is (witness the bugs dealt with in the rest of the series), but strictly speaking the third patch is not fixing any functional bugs.