Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1557194pxb; Thu, 16 Sep 2021 09:51:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzphEMzoVIBf6WQdTHP9w3U/28wXZoqXsf7mRCObSgDD+2Ppeo6DTHDvqH6vb7iy9rGvP2q X-Received: by 2002:aa7:c9d6:: with SMTP id i22mr7680568edt.307.1631811109936; Thu, 16 Sep 2021 09:51:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631811109; cv=none; d=google.com; s=arc-20160816; b=Jwrcy3VeN8m9uN1Edo5IyXzNvDbYHiw6kIwKqEtISmqIi6l9LMkw08LTNLbPV/qLvD 4F75MTbgwJiU/aKQx+5mBxxLhdgq4iSTpqaarGbfSSkoFs9ir1XsnK2wmztPOGmSxpfy XNtwxfgSnkhu7m5g+VdmiGd13Zqlo6M/U6bTdHcKIK+LC+dmIu0lMysPPtg99DJ+nXzb SnujqJDNxpjsb3qvJnU3ODyIf9YNCMdndkNVJJus9Rd0Kwg/BXImdy1FaeHyq1PwkC39 hZ3171GcF3ixlo/D19iLxHUCps5bn20eC7E3WkY0a3F6eN1N7iOArcORYcTAAo1w6j7M FitQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=AKIZx/OZNxoDf9uUYSQsj/NRz6HoLjDXTQ7idsPylNY=; b=qmCGvt3Pj4y1irKSFxj6g/owL2hgGNDn4dFSYqH9SXWin8ueei1ne9ycFGNMFowmOf MdnSW11q3PQhRPIkxYHXu8+TZw2G9bApC0jen8wMFXt/VybF4INc3mwAP+O4F+Boh0mQ xRN0xb3tpdt8VBmfvIEI9FUqkOvJP95hgI1HxaJ0nDvAafpLJC9w7Sp2X1UwRZNypHUV h6ZHezC56KvinQbqGer/qmrwZprBkpjCbdqZ1Fimo5iu3GJtsernTfqiu7OHJMK7wKt9 qzSbH4JXtZIPHKcGQy/jkugRKqzELXuo1EhVrSZNsctYPB6NBF2iJ8N+uDZZ8wdkeAVD 6+0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Yss6P1hf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi23si4165303ejb.186.2021.09.16.09.51.23; Thu, 16 Sep 2021 09:51:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Yss6P1hf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345334AbhIPQuG (ORCPT + 99 others); Thu, 16 Sep 2021 12:50:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:59206 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343682AbhIPQoD (ORCPT ); Thu, 16 Sep 2021 12:44:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 204AB61A3C; Thu, 16 Sep 2021 16:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809523; bh=vJf/hOLRbSjBB5md0JjqiGgNpfTuhUqJ4jPhXj65f/0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Yss6P1hfe79OEUxAmINU7lKdfh0+qcqmVrNqOPU4jtKrgUUJ4L/aiIH0w5xXgNedZ ssDagslkaEYcE4TpHHjHIIXi2a1d46cGkOunjAE6E4o8iAcpjBi4/xHQ5X/FVU1iJp +UZQmyfbdHAe4pUsJPgXS87QhQ/HCsNczxkYVSKM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Yang Yingliang , Mauro Carvalho Chehab , Sasha Levin Subject: [PATCH 5.13 186/380] media: atomisp: pci: fix error return code in atomisp_pci_probe() Date: Thu, 16 Sep 2021 17:59:03 +0200 Message-Id: <20210916155810.405291990@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yang Yingliang [ Upstream commit d14e272958bdfdc40dcafb827d24ba6fdafa9d52 ] If init_atomisp_wdts() fails, atomisp_pci_probe() need return error code. Link: https://lore.kernel.org/linux-media/20210617072329.1233662-1-yangyingliang@huawei.com Reported-by: Hulk Robot Signed-off-by: Yang Yingliang Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/staging/media/atomisp/pci/atomisp_v4l2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c index 02f774ed80c8..fa1bd99cd6f1 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_v4l2.c +++ b/drivers/staging/media/atomisp/pci/atomisp_v4l2.c @@ -1763,7 +1763,8 @@ static int atomisp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i if (err < 0) goto register_entities_fail; /* init atomisp wdts */ - if (init_atomisp_wdts(isp) != 0) + err = init_atomisp_wdts(isp); + if (err != 0) goto wdt_work_queue_fail; /* save the iunit context only once after all the values are init'ed. */ -- 2.30.2