Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1570249pxb; Thu, 16 Sep 2021 10:07:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6NUSHRJyJYfVcMgimiq2hPYSR1yevhlf53U9SL0O4QEaWTCLxPI/EqT7/kkpkrA0453Vx X-Received: by 2002:a17:907:2639:: with SMTP id aq25mr7559870ejc.138.1631812029821; Thu, 16 Sep 2021 10:07:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631812029; cv=none; d=google.com; s=arc-20160816; b=Z2g7qzSZd3Y4HeciKOjpNO9kTICQtphhf/KQF8Rm29rJ+8Hi5IY0APLDSCcovEc2gI JvvZqxfAY/q2kzDaS+8mnBKKsum2Tb5N98MjcJQunSGE/FUWC0l5G6nVSxmglNhkiIfT tP/Tzf0bcaRMUgOEGl4a75objjHh21+2lPFdg9CXfPxXR1H/cCBA2FVM9m8GnlFJGC+z N7N+Th2bqU7XCDx3wCjvYTlp80Ez1j5SQF4qZj6+H9lFnzHmnaKw2yla4E0qDQLcf0sF iiqANXCxRmq0Et5sRCG4Von1AoPdmO0KgrH1GfocvZ3Z9oC4tjh2bs9qDzONxo6WC0f3 eUBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1haNIml6KMT/qD2TqrLbLA88bZLsu1yOW2NJaBx5eRk=; b=ly28yx2dDnuht1CoIl38xmYDRePeRYeDajOhW4YAocB5txlj24m+06fScHR7EyGC0Y OQqIV2/zL9MHq1qCIvOZ5vMq6oM332T8ssxjLVDgNVcvG29h15jRierLv84a0Ou4E1Q0 eAjUfq8mhjtAue1SHhE+l3Sipn+wAv7cGTGstSKL7SvfjOH6gLJcGidYlndEDFDNT/RN fy6ZAh2DfbMfEmGPsz0y7ab/yc2mDEIBA8xMkJ7Oq2jUP+0aKlUlhqcPS6NK755lHPIG FS3V/RDI1qCFdpJJpysfjtNp4+VFyrTzNkeIe+TPCaZg31LnfPK1XvFFnIhrHCrXrAn6 Eunw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CuU6bc4L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bl3si4171667ejb.204.2021.09.16.10.06.43; Thu, 16 Sep 2021 10:07:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=CuU6bc4L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348044AbhIPRBY (ORCPT + 99 others); Thu, 16 Sep 2021 13:01:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:51936 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346408AbhIPQyu (ORCPT ); Thu, 16 Sep 2021 12:54:50 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 39EC061130; Thu, 16 Sep 2021 16:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809826; bh=rzXuxzwfo0rUa+MXxZD9zmqtGv25AxQYRDc7PVfMWU4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CuU6bc4LuX8aIhdwgOJKLY0VyhD02L4s/e76xEMt5skJSDtqcA00Ia1rkk8rspRmM Mu2JO77nez/asojrOCnA0lJVxpldb9CGMifnAOUsmnuF2z8MFotSsz4m56TWl4WdcX UVzkHzeVyTFFAeP4nA+87PknpZhQQkR/CbbVB+hM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "J. Bruce Fields" , Chuck Lever , Sasha Levin Subject: [PATCH 5.13 280/380] rpc: fix gss_svc_init cleanup on failure Date: Thu, 16 Sep 2021 18:00:37 +0200 Message-Id: <20210916155813.603825829@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: J. Bruce Fields [ Upstream commit 5a4753446253a427c0ff1e433b9c4933e5af207c ] The failure case here should be rare, but it's obviously wrong. Signed-off-by: J. Bruce Fields Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin --- net/sunrpc/auth_gss/svcauth_gss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/auth_gss/svcauth_gss.c b/net/sunrpc/auth_gss/svcauth_gss.c index 6dff64374bfe..e22f2d65457d 100644 --- a/net/sunrpc/auth_gss/svcauth_gss.c +++ b/net/sunrpc/auth_gss/svcauth_gss.c @@ -1980,7 +1980,7 @@ gss_svc_init_net(struct net *net) goto out2; return 0; out2: - destroy_use_gss_proxy_proc_entry(net); + rsi_cache_destroy_net(net); out1: rsc_cache_destroy_net(net); return rv; -- 2.30.2