Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1604183pxb; Thu, 16 Sep 2021 10:53:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxzcfTaQ08y74Q6vnCscJKuWCrwwWau+qH5r/hkXDMEw3I8C2A1RsIqHELphPvNBvR7xnaK X-Received: by 2002:a92:da4a:: with SMTP id p10mr5014800ilq.13.1631814796906; Thu, 16 Sep 2021 10:53:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631814796; cv=none; d=google.com; s=arc-20160816; b=drZh2RLEHnf/yIIjELLtfP//w3zXU8s/brHaXb9AM/GI2nxVGhY4fA0n/y+4kxtWJf DDHVMOiJ0zdMr3GCzWrjsvedRzSSFNVUXj1xbCKXz6EDIssI1BgOALxXLNS4X7GxsPGo f6Q12+GjcHpWneFULAPooAqSU1F7TE3PueJA5U2pqQ0DC9dCLQVM+JkA6RzUStF5o4dM m6Gk/Jk+7jhNsQlaO1tnV+8/WFQ0O4Gr/3R6GZYrkXgQ8YlSZ1dpw+NJxTPHNUzHr4ds 58teOG/g+8OvAMN0UXY1cXPV9R1niJBcazWk+yhBQ09guUz2M3Y8SoMQRV2qtfhurJWS xJCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=CImeVdEJWARFJNW+J5rIL4fwX0S5hR8mv2ZAiSi+8Xo=; b=LxeZS0RlE8Kg2FwJA29rzcOJg3xeKCl+UQEh9XAin50FsR80SDnQBiAM2cAnVaZWGh gSR6OQHEgF8Z/ncAwYFg/04m9UfLkiXENfjySvNpX/3gtHZA4Au3m5fflXNgvzPgsrBN a3ilSWruRlsRWGSg9b8bVZX2oMFfX6s1pipW4HbQiCZCTDp9ByIbDH0IGxeoZLCruxNQ i9zMg4y0py2HjoiVF4lFW1k43ZdqR3qnwZWVFL8r1jZGvRJcNw8KT8YevYsmcqe4Wnsn SbgsBEfk6SwX9sgdbHsmsDVRBLF26Y8puACVKG8XHw4w2w2JNVLBpDSN5wj2YCNfCEb9 usTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h5si3829014iol.44.2021.09.16.10.52.41; Thu, 16 Sep 2021 10:53:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356952AbhIPRvP (ORCPT + 99 others); Thu, 16 Sep 2021 13:51:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:57082 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355821AbhIPRmK (ORCPT ); Thu, 16 Sep 2021 13:42:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E059460FDA; Thu, 16 Sep 2021 17:08:27 +0000 (UTC) From: Catalin Marinas To: will@kernel.org, Dan Li Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC]arm64:Mark __stack_chk_guard as __ro_after_init Date: Thu, 16 Sep 2021 18:08:25 +0100 Message-Id: <163181210192.884883.7181525441852917097.b4-ty@arm.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <1631612642-102881-1-git-send-email-ashimida@linux.alibaba.com> References: <1631612642-102881-1-git-send-email-ashimida@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Sep 2021 17:44:02 +0800, Dan Li wrote: > __stack_chk_guard is setup once while init stage and never changed > after that. > > Although the modification of this variable at runtime will usually > cause the kernel to crash (so dose the attacker), it should be marked > as _ro_after_init, and it should not affect performance if it is > placed in the ro_after_init section. > > [...] Applied to arm64 (for-next/fixes), thanks! [1/1] arm64:Mark __stack_chk_guard as __ro_after_init https://git.kernel.org/arm64/c/9fcb2e93f41c -- Catalin