Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1605532pxb; Thu, 16 Sep 2021 10:55:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzA5hzx/zTML5QdX69ADrZbSP/9vzTNV+krIJsvhKdEWaUUoeoK194eEDTy4ct9NUzTVDcL X-Received: by 2002:a92:c8c3:: with SMTP id c3mr4710745ilq.165.1631814931614; Thu, 16 Sep 2021 10:55:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631814931; cv=none; d=google.com; s=arc-20160816; b=D9IT6GoWDnf76jT3gcMKiIr6oIgECa7EByc4ddpLv5Qhcsv8yAqzn7UvecE5Lsbrxn cw6Vpw+4w1KliVOVmIVUkfq7zTorv8FuVPJIj5EFkB2kpM2CzLCg8uq1dEkyz51CUi9O fYGAZZlmQtNIzhVEkVqxoxYPJQ296IufbFS4JFAkwTclFK4GQyyq1kiDcEjEOovp8h1N jeAe3EpnL0W0QkU15QfmTfM/NE7EPuqzSOSIu8ONyPsohBEtLBz/5UUWhYqCnje/v6f5 mwtmoylCk+I5PZpLvub3Ten1ofT4JjHF2QIQ3G/joIjOUwhvs0Ux6X94HWSNCJhtAm+d WjBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=tiqX7dnBSpraIxKgwlGElCJ7y3YLSYI9MnLnrLWRpJg=; b=O1/m5c0toAG5lt1y7zt8R+fGWusPiPN8hWCqmrpU7Gv60KkxkgmQcFkUapSS6WJS9Z rCCFyfwdqX4jqld0AHCp/KO6pCbu4Kd8aCgXy4kCFfa3bDR2ewJFvNTIM0OF/C22FcZ3 rcsYJCQMYPvGFjs5OTGWZrwfJp+mHB4XBpxjAZkTjP81v95kvfWSAGO7STNh497bREPF aaat6q4OCBDauDH6IdqUr1wzWbezk1SW+mkOiyWi5mb15bR9bUK/N8WC2gVzukHhi/+B GamnsKdbMtofuBJNno5Pi/7++0jJZhUSgTqYhZMXpMRsDQ7R27x+OHqanz0+GvMXp8Wa 7tVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=iNlOkaj3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h15si3428647ili.51.2021.09.16.10.55.20; Thu, 16 Sep 2021 10:55:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=iNlOkaj3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345588AbhIPRyF (ORCPT + 99 others); Thu, 16 Sep 2021 13:54:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37790 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358314AbhIPRwz (ORCPT ); Thu, 16 Sep 2021 13:52:55 -0400 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E38D0C0613E6 for ; Thu, 16 Sep 2021 09:33:51 -0700 (PDT) Received: by mail-pf1-x42d.google.com with SMTP id c1so3496177pfp.10 for ; Thu, 16 Sep 2021 09:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=tiqX7dnBSpraIxKgwlGElCJ7y3YLSYI9MnLnrLWRpJg=; b=iNlOkaj31rhWycqF0fbB4UX7Nr3By3h2mdYTW1OCnx4iArZusdd3Dj4q57ZJaDUbY/ 0ZLarEKWdS0JjcAIZBFSM8JH2VAybQolk28ufoXN/e24Azz/3Gz2yw0+MGqry6ZxjVZi 7xaJDfS9utb4FJgwLJkMqz6baFRdwHbC11oGKBJvH0Z7oe/3NsZAtZLAxpKorbDT+kUL y4FELIhKoUd4Sqgie3qzEpfiNY3/KDxAXfphaoVl/YKDGxLHzIIJUtvNvXQWcycGip3E +hWkYdXbqZoK1Wp9/+9VvpU9wDKCARsoRqA9h7/48EoLWSU6W61m11ZEviIAiur0nzI3 ssFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=tiqX7dnBSpraIxKgwlGElCJ7y3YLSYI9MnLnrLWRpJg=; b=R+OAaVMA7xMDCa50L2shZo2WonzCZpOVUeuMWf6g8HchANqZrH8kGIPqQy/GCu7FZM mOU1O/mvfPiwtgwMMbgLZgpt6xXu9J4+Do28EgVcH5TCAzHpgSB33nwZ+MEe13epqDnH M8GZh6HVIEO7G8W9zNMFYDT2bEo49J200GBeolyzJC492whixntAs8NuIvNj63V6aSoN 5R5gyiK3uYwIQnoXEJrAg40WHt0ZrO1WrVy66xGy20zxaBMr/wH1JE9Ii/MBO9cSe+5P H2hTphAwS9G4QAhjrz7Z13zL4MJeU9jjr9aCSeOPF9QUl/hRrp/MMgTTyh3MYXqtutq8 1oVw== X-Gm-Message-State: AOAM532QPCYYKGOCE8sAVvT9ykhFsGHBPOUTWhNrzYimRYJLpeOAK/ly mjzydwh34RNQxKhfqqlHRf3ENjabVoqC9w== X-Received: by 2002:a63:7e11:: with SMTP id z17mr5668827pgc.436.1631810031271; Thu, 16 Sep 2021 09:33:51 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id z17sm3564469pfh.110.2021.09.16.09.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Sep 2021 09:33:50 -0700 (PDT) Date: Thu, 16 Sep 2021 16:33:46 +0000 From: Sean Christopherson To: David Edmondson Cc: linux-kernel@vger.kernel.org, Wanpeng Li , Joerg Roedel , kvm@vger.kernel.org, Paolo Bonzini , Vitaly Kuznetsov , David Matlack , Borislav Petkov , Ingo Molnar , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Jim Mattson , David Edmondson , Joao Martins Subject: Re: [PATCH v5 3/4] KVM: x86: On emulation failure, convey the exit reason, etc. to userspace Message-ID: References: <20210916083239.2168281-1-david.edmondson@oracle.com> <20210916083239.2168281-4-david.edmondson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210916083239.2168281-4-david.edmondson@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 16, 2021, David Edmondson wrote: > Should instruction emulation fail, include the VM exit reason, etc. in > the emulation_failure data passed to userspace, in order that the VMM > can report it as a debugging aid when describing the failure. > > Suggested-by: Joao Martins > Signed-off-by: David Edmondson > --- Again with the From: caveat, Reviewed-by: Sean Christopherson Thanks for doing this David!