Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <4c709b29-2f1c-aa64-409c-62bcd058f81c@amd.com>
Date:   Thu, 16 Sep 2021 10:34:24 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH] drm/amd/display: Reduce stack size for
 dml21_ModeSupportAndSystemConfigurationFull
Content-Language: en-US
To:     Harry Wentland <harry.wentland@amd.com>,
        amd-gfx@lists.freedesktop.org
Cc:     ndesaulniers@google.com, torvalds@linux-foundation.org,
        linux-kernel@vger.kernel.org, arnd@kernel.org,
        alexander.deucher@amd.com, christian.koenig@amd.com,
        Xinhui.Pan@amd.com, nathan@kernel.org, linux@roeck-us.net,
        llvm@lists.linux.dev
References: <20210914210508.10627-1-harry.wentland@amd.com>
From:   Leo Li <sunpeng.li@amd.com>
In-Reply-To: <20210914210508.10627-1-harry.wentland@amd.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bTYydzhxeW9qWWg4KzJlMjJ2SDZEcHhuOFN0bjJVUEphNS9iUktEQzhMcFhD?=
 =?utf-8?B?Q1Z4WjEvandja29sc29mS2Z4NkV6dlpyRTZRU3U5aHZkWmpwNVRKSTJJTmNL?=
 =?utf-8?B?UWp3dVU0YlYrT3h2WkF2OUkvdzZ0emdFU240UlRPaFZXU2I2NnFRQjJ6YUJr?=
 =?utf-8?B?VGV5TEEwS3gvaWdoaStSTzk2RVFRbXRGMG1yODVuZnNkWVFLT25zYUxPSDV3?=
 =?utf-8?B?bXVpQ0p2ejhhQ3Ric29ZVlhuTGtMWVh5eU1qTHNsY1dsOUZveUlsbmZObkF1?=
 =?utf-8?B?RWk4RnJrenh1TzJOZitiSGsvZU90Yk9PT0xKSXQ4OVBka1YzMzdFVCt5V1F5?=
 =?utf-8?B?dUM0cGJUQnN3eENWajB4d0NWdzRyUW5nZmtVdEd4bm45N2RiUVBSZXRRWFc2?=
 =?utf-8?B?RUdPMkYvL3lqb2NtRTdmRUN1TUtxNlpBUWtTNXJRbzZiQjFjYnFSRy9MUlB4?=
 =?utf-8?B?d1RlK2hEZ1p3WllsK3BrUjFPOE5LY25XVmV1Q2NXcmN0ZlRHZHFycHdTeUFI?=
 =?utf-8?B?ZW9EUC9JRndRcGVtcDV2ZDBOR01jRGJ4MXJ0OUs3QzQ4c1o2YllGNWlUOG1n?=
 =?utf-8?B?R1pTUFo2UHdyTGdKa1RPalVpZURTOEg5cnBkNnppdHpWS0hyMCtvUzBGOHUz?=
 =?utf-8?B?clQ3cW16dVdsaTFDQ1dwanF0bmxIbjlpY2hRWDRUR0dWa21aRWpGQmU0ZjNX?=
 =?utf-8?B?OFhGY2V3SjE5eFJIOVZoZ2JSMGpCZmNlaU1TRnh0RDlnZWpEMStWVHpwbVRr?=
 =?utf-8?B?ay93UFV4eXRReDNJVEN2YU52ZEVUWEJQOXZLRURzUlZ0aFdmV29vdFF3WEtq?=
 =?utf-8?B?emExc3BoREVKbFBFWkRod21YL1VJNmUyYy9EYmlpUkVBMHFabHl0QVk3amhv?=
 =?utf-8?B?SHgxK2hUckNZeERWcFZaOXFrbER4aGFRaEM1OVhNbHBJVTRzK3BYQXp5RnVC?=
 =?utf-8?B?UStmQk1EUlNKZlBpOHZDNUswdkIzd1ZsUVMveTlSdG0zMW1lOVFpaFR3NTVy?=
 =?utf-8?B?eE5UcnBkc1RQeVpGZ044UGpoblpoY05ZWHRJUWhXOFJVYTVZOU1QNkl4STRi?=
 =?utf-8?B?NFU3WTJ2aGdpQW13SVl5UDhzSFhIZHpaS3pRZkFvT3pXd213THYxZ01nK3RO?=
 =?utf-8?B?RzRHblI0Y1IwWGtrdzM0WTFTTDlFMS9oYzIrYWRHcnZpS0RGc2ZranZLTFR6?=
 =?utf-8?B?U1FobXVqdCtib1hrU1JIVlEwUHBMUUNXUmh2NnUzQXc5T1RpNkNScGNaNDdB?=
 =?utf-8?B?Y0dNcWFmODBtNjJBOGFOaVo1dExpRzVHNkZMMVJjbXlmL2ZvMjd3emh5M3JG?=
 =?utf-8?B?M0U4QzBOdTlGdlBnY205YU81N2F2OFZoUzdWZ0hyU1gvOHFBb29CYW1XWVpu?=
 =?utf-8?B?Z0g1QVFwNnpRSndDbm9URE5XZlBNaVNhbE1LTlZ4T0tFQmFvdHl4ZlZaYmtJ?=
 =?utf-8?B?bTJFZWlDQ0pQV1Z5TTVlVmV1elZIRm0zRVV4YzdDbFJVR0Y5am1tRkVFcXVH?=
 =?utf-8?B?TzhJMFlNaEtDZno4UU13NzR5M3R4eEYzUW84WStSYkdJcEZrU2gydFlEZ2hE?=
 =?utf-8?B?eVRyZkt3LzJPRWlZYXBxOE5WQWRrd1Izc0VpTzhFVHdSaE5EWi9CcTBsQi9V?=
 =?utf-8?B?NU8yN2VDcXVhTEFYRHVzOXBDWndQdVI3bEdjYm80Sm8vb1BLNktQVDJGUUUw?=
 =?utf-8?B?dWprbk5JdDNXWkRXOG1DTkRUcm10VmMxa21XNFlSTVVWV2QwbzJvSWtyUEFa?=
 =?utf-8?Q?/oL/bJ2EOh+1AUysMXIkgqID040pMQfCZaSEYew?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d69b4d11-257e-4170-c174-08d9791f1622
X-MS-Exchange-CrossTenant-AuthSource: CH0PR12MB5300.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 14:34:27.4597
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4x5uNZn8pkHfPH96yBune4lxWpf2vFqeDXzNHypgSHh+FvbIATVNFxWpXR1teljn
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5169
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 2021-09-14 17:05, Harry Wentland wrote:
> [Why & How]
> With Werror enabled in the kernel we were failing the clang build since
> dml21_ModeSupportAndSystemConfigurationFull's stack frame is 1064 when
> building with clang, and exceeding the default 1024 stack frame limit.
> 
> The culprit seems to be the Pipe struct, so pull the relevant block
> out into its own sub-function.
> 
> Signed-off-by: Harry Wentland<harry.wentland@amd.com>
> Fixes: 3fe617ccafd6 ("Enable '-Werror' by default for all kernel builds")
> Cc: Nick Desaulniers<ndesaulniers@google.com>
> Cc: Linus Torvalds<torvalds@linux-foundation.org>
> Cc:amd-gfx@lists.freedesktop.org
> Cc: Linux Kernel Mailing List<linux-kernel@vger.kernel.org>
> Cc: Arnd Bergmann<arnd@kernel.org>
> Cc: Leo Li<sunpeng.li@amd.com>
> Cc: Alex Deucher<alexander.deucher@amd.com>
> Cc: Christian König<christian.koenig@amd.com>
> Cc: Xinhui Pan<Xinhui.Pan@amd.com>
> Cc: Nathan Chancellor<nathan@kernel.org>
> Cc: Guenter Roeck<linux@roeck-us.net>
> Cc:llvm@lists.linux.dev
> ---

Reviewed-by: Leo Li <sunpeng.li@amd.com>