Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     Colin Foster <colin.foster@in-advantage.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        "UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
        "David S. Miller" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 net] net: mscc: ocelot: remove buggy and useless write
 to ANA_PFC_PFC_CFG
Thread-Topic: [PATCH v1 net] net: mscc: ocelot: remove buggy and useless write
 to ANA_PFC_PFC_CFG
Thread-Index: AQHXqpeh6y6SRE8JykW9vsuy+tc/X6umjJKAgAAzO4CAAAEcgA==
Date:   Thu, 16 Sep 2021 14:56:38 +0000
Message-ID: <20210916145637.yu63cf3mzkkx2eg2@skbuf>
References: <20210916010938.517698-1-colin.foster@in-advantage.com>
 <20210916114917.aielkefz5gg7flto@skbuf>
 <20210916075239.4ac27011@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
In-Reply-To: <20210916075239.4ac27011@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YQxbASJ6l/dAcRzgsxsR4eEUWxOLIAptWXQncffWg8QVqHGlMM5KF16o8EaI?=
 =?us-ascii?Q?wfMzBf5DSaUOu3AOBGv4i4EIr9GgaMYUDBOvnwwtbOynSsw+JMu5nQl25jWP?=
 =?us-ascii?Q?U0DVsqKs4/rVMqX3Z4vuYBvcz+tjM23xneGbOfJZmZPGTD9AHgPd8KQNf2zJ?=
 =?us-ascii?Q?zfgyVT4Z1XZO8CiB9zQvlGQ8QhXTD/roLekGHBAaL1PmITzNKoEM6ZDDZmhK?=
 =?us-ascii?Q?cqlZUYct7HK/IkotoMRvgwY9314X+A7a/qDOuoamlzN4fIhY0kn49glAkfT4?=
 =?us-ascii?Q?IiuFDhH3unVHrt9+OeBM0ADYgUQlqFcKbJRHPzxQo6LMV/ZRGhORJKqNJAqQ?=
 =?us-ascii?Q?n0as1S5mSdy59ginieEWQgRZwRyO0DRr66AdRWoTOIIAUnCda3iWSsG6Tnzo?=
 =?us-ascii?Q?uvc2opaaexEpM6i6+ELb/p/jm8eI/W3gEXYuyc1cwZyr5h65RnfXvWORbvHr?=
 =?us-ascii?Q?U3I5KeoY5RIydPTLdQ3uPjvoQl7RPVs9cYS4oPVztwqnc0VSZN9CU9CV/N34?=
 =?us-ascii?Q?RvPnlUkkz+NU+NKB4Jbhr21q33CE3odEycQCI3wXV5DMw+ZYzEGcQxjEguFU?=
 =?us-ascii?Q?tBSpws7Uo62qxA1PQy0dy+GVRD1fp92PUsumYTPzDsgePhk8IO0Z1sZZAeP+?=
 =?us-ascii?Q?jTJPjOkIl5HPOVW0nP+BBA66q6sFV7u19wgAhaHhybbf1fAZ18kMz6BaN18N?=
 =?us-ascii?Q?y5IFlWmw0wD5QRW+DPhYQ7pMFX98rT5OWOEPBE9f0mOpaA6c6fXsdV3TwddU?=
 =?us-ascii?Q?ZbxUdgVHAfcfsC93lF+TDClyVh3tNGvJA+c15O1cES8Gj4OCMQh/SGmICOmq?=
 =?us-ascii?Q?tQt7Slp6LZfTJQXzpm/USGMdRsNYIUU4TZbIeKSYz1qWU787QcBioT/GMXmn?=
 =?us-ascii?Q?DVkAg5GqimOQMTnmjVPs5m23C2wPuy0RI+Boe6rjy+2f4DJPqfASeugM1z5g?=
 =?us-ascii?Q?j4zv5TSsT2pXCXMUx5PuoWWmFbERvPEg7N6/Ce/OjYPg5/Cuj8QL4Gf2TLd5?=
 =?us-ascii?Q?Po1uHTeCOHlJCrgqEMqcDO1r0V3YPZse+V9xgIIULmsDljkzhsoHS8Pw0WCr?=
 =?us-ascii?Q?i4rV0Bj3J5wuDnUtTGVodkDF4Mo5z3pkX8cr3+RO0zdSBM2PjdFmaeO0C/Nv?=
 =?us-ascii?Q?vTYDVMEoF7fDJnF3M3wZWvtUR+TRPhM3ykdmJ5MSTVmmKoPqf1LbRHLNHy1C?=
 =?us-ascii?Q?fp/m2l9i4FrTx1xu/03TZWPJF9sTfUKfLz5oO2Oi67t9cwydqG5EiYZa0awH?=
 =?us-ascii?Q?CGAa/CZVa+gaEZgPDXcQTyw+GAKokiv6wi/0STCaxOToYSYzAXJoEUsIob+N?=
 =?us-ascii?Q?PI2kFIrTpy2zJAO3m7w1AmQlii0U1iHXh1Vl+jVnFPEJTw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D2D0D2197E2293489DF0B7B750BE8E01@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 73b16e82-485f-4b8e-7e68-08d979222f78
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2021 14:56:38.0631
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Rvz6bnLDhSZSUrYCfbzcMAkDoml70PLT2EGOWqmZuB6qa7Y1WDJY+ggTBvgmQa0hdalZaxGLhDVdh4Z+QhEfNQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3710
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Sep 16, 2021 at 07:52:39AM -0700, Jakub Kicinski wrote:
> On Thu, 16 Sep 2021 11:49:18 +0000 Vladimir Oltean wrote:
> > git format-patch -2 --cover-letter
>
> Nice instructions, let me toss this version from pw.
>
> FWIW the patchwork checks don't complain about 2-patch series without
> a cover letter [1]. Having cover letters is a good rule of thumb but
> I thought I'd mention that 'cause unlikely anyone would realize otherwise=
.
>
> [1] https://github.com/kuba-moo/nipa/blob/master/tests/series/cover_lette=
r/test.py

In my certainly limited experience I have found out that forcing
yourself to write a change log and a cover letter makes you think more,
which is sadly sometimes needed.=