Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1696478pxb; Thu, 16 Sep 2021 13:14:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwsO8+Rwgm0JrcrVOK+xgvNH+l1S7G0il0oVaejLAo6pJtlataMX8kAL60UWqaaUtE5t5lh X-Received: by 2002:a50:da82:: with SMTP id q2mr8648516edj.86.1631823247665; Thu, 16 Sep 2021 13:14:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631823247; cv=none; d=google.com; s=arc-20160816; b=BwOZzMt3HANGw6lVI6XOEvILYosFe+GG+u6n04xBprlWqSVKb5tvRRbBGwhgPqqosc PTWbbMGIavbFxKC/BRIn6xPFZLGNiZO0qnNfQQJbCiOzn0El3OPK2578UyUvrx/bsgtv GzIex5JbB1m1IrTZXdVYBPx1CZW1LhNq9HDICAhxukVVgsf6Ie9RZfqS95tjkIiyRf0D yygr8Jk/lkljSR4oWzqnPwL2jllSuRb5XvY4Xc9I+0oI7TKZuY4stKIW+yIjEzen3YMJ JispNnzeCp0Z8B6jVCIMOO+s2bv5DBNTxOZYyBtdFZ6GTcgNyj2NkpaoXXcYZt9BAALr 0usQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=HC5ex2ZCi2/5t/c5pdMMrsrUsGv8Y27Os6oY0nZglbk=; b=OQPjxAgGJEPw/KpNyz1NEJuc1RzAcUGyi3ZMPdaticd8i7Ojy68DovT9jxBI9KEYUx MrxIn/YMpbY0EXp0DbEmx8BbZDjudzhIOLZFCBCdeSKkDljtlICS1XgKSoYJLlocVj1H mLh0rVMyHWd2uDGfWi2yFbGTHafmGAAhkHs21GcNlFoBW43RiPNwX2RC+fzSGu8We/x1 tYntTLj1A59GMFhj4RkR+DmBqcqPq6ACClprsP48Po/PHlzr9mnB8L6GJ78PzyFpRwoM /mGmEIhWeFQdV2WK26tbjENmJ84Do9Pw8ADY7JTuMK9GNiweuW1qNRqDTHuSKqNTZ7+W zUKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ym4mqdmD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c24si4479596edn.26.2021.09.16.13.13.44; Thu, 16 Sep 2021 13:14:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ym4mqdmD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241964AbhIPQXh (ORCPT + 99 others); Thu, 16 Sep 2021 12:23:37 -0400 Received: from mail.kernel.org ([198.145.29.99]:53832 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234505AbhIPQNK (ORCPT ); Thu, 16 Sep 2021 12:13:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B2BDC6135A; Thu, 16 Sep 2021 16:09:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631808584; bh=Yx1TcV1rUcO7Y+UbDLBavVff84x7trPkV3uk/7cKoCs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ym4mqdmD9wLlsLo8jiGumvR025WJw0dE9LUcgkwZyRoIIOWx/Kb651S9KPslAjOZm qXep/fF7zogljCr2nKOD0HtIgFt12fncndfx0VAabpJ3LfigiP6c0ge+sIU2zFxGQd h+GfDtgs59SR59vq7RDxm+jXOU+Za1KxWJ1+CM7U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chao Yu , Jaegeuk Kim , Sasha Levin Subject: [PATCH 5.10 103/306] f2fs: fix unexpected ENOENT comes from f2fs_map_blocks() Date: Thu, 16 Sep 2021 17:57:28 +0200 Message-Id: <20210916155757.583127379@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155753.903069397@linuxfoundation.org> References: <20210916155753.903069397@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chao Yu [ Upstream commit adf9ea89c719c1d23794e363f631e376b3ff8cbc ] In below path, it will return ENOENT if filesystem is shutdown: - f2fs_map_blocks - f2fs_get_dnode_of_data - f2fs_get_node_page - __get_node_page - read_node_page - is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN) return -ENOENT - force return value from ENOENT to 0 It should be fine for read case, since it indicates a hole condition, and caller could use .m_next_pgofs to skip the hole and continue the lookup. However it may cause confusing for write case, since leaving a hole there, and said nothing was wrong doesn't help. There is at least one case from dax_iomap_actor() will complain that, so fix this in prior to supporting dax in f2fs. xfstest generic/388 reports below warning: ubuntu godown: xfstests-induced forced shutdown of /mnt/scratch_f2fs: ------------[ cut here ]------------ WARNING: CPU: 0 PID: 485833 at fs/dax.c:1127 dax_iomap_actor+0x339/0x370 Call Trace: iomap_apply+0x1c4/0x7b0 ? dax_iomap_rw+0x1c0/0x1c0 dax_iomap_rw+0xad/0x1c0 ? dax_iomap_rw+0x1c0/0x1c0 f2fs_file_write_iter+0x5ab/0x970 [f2fs] do_iter_readv_writev+0x273/0x2e0 do_iter_write+0xab/0x1f0 vfs_iter_write+0x21/0x40 iter_file_splice_write+0x287/0x540 do_splice+0x37c/0xa60 __x64_sys_splice+0x15f/0x3a0 do_syscall_64+0x3b/0x90 entry_SYSCALL_64_after_hwframe+0x44/0xae ubuntu godown: xfstests-induced forced shutdown of /mnt/scratch_f2fs: ------------[ cut here ]------------ RIP: 0010:dax_iomap_pte_fault.isra.0+0x72e/0x14a0 Call Trace: dax_iomap_fault+0x44/0x70 f2fs_dax_huge_fault+0x155/0x400 [f2fs] f2fs_dax_fault+0x18/0x30 [f2fs] __do_fault+0x4e/0x120 do_fault+0x3cf/0x7a0 __handle_mm_fault+0xa8c/0xf20 ? find_held_lock+0x39/0xd0 handle_mm_fault+0x1b6/0x480 do_user_addr_fault+0x320/0xcd0 ? rcu_read_lock_sched_held+0x67/0xc0 exc_page_fault+0x77/0x3f0 ? asm_exc_page_fault+0x8/0x30 asm_exc_page_fault+0x1e/0x30 Fixes: 83a3bfdb5a8a ("f2fs: indicate shutdown f2fs to allow unmount successfully") Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/data.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index cfae2dddb0ba..70a91c47f72f 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -1550,7 +1550,21 @@ int f2fs_map_blocks(struct inode *inode, struct f2fs_map_blocks *map, if (err) { if (flag == F2FS_GET_BLOCK_BMAP) map->m_pblk = 0; + if (err == -ENOENT) { + /* + * There is one exceptional case that read_node_page() + * may return -ENOENT due to filesystem has been + * shutdown or cp_error, so force to convert error + * number to EIO for such case. + */ + if (map->m_may_create && + (is_sbi_flag_set(sbi, SBI_IS_SHUTDOWN) || + f2fs_cp_error(sbi))) { + err = -EIO; + goto unlock_out; + } + err = 0; if (map->m_next_pgofs) *map->m_next_pgofs = -- 2.30.2