Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964842AbWLMKlS (ORCPT ); Wed, 13 Dec 2006 05:41:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932664AbWLMKlR (ORCPT ); Wed, 13 Dec 2006 05:41:17 -0500 Received: from nz-out-0506.google.com ([64.233.162.225]:3425 "EHLO nz-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932661AbWLMKlQ (ORCPT ); Wed, 13 Dec 2006 05:41:16 -0500 DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=RL9HHOk+afpRDUDZMDGY0JCc/CZ5rY3kiqiIRKbRLjCOaxQFhrWyd/vj7FvBg4j64djJmu5uIpGbfnmKjVeHtzyM8I6c2lA3Kb+GHS5FD7wo0nKk6cLHwzSyKHfoxRiJL5O8Z5w1X0wD6v7ZKuHxZVPC+VkoVctY4YkjPGY2oFI= Message-ID: Date: Wed, 13 Dec 2006 10:41:15 +0000 From: "Catalin Marinas" To: "Tejun Heo" Subject: Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops Cc: "Jeff Garzik" , linux-ide@vger.kernel.org, "Linux Kernel Mailing List" In-Reply-To: <20061211132625.GA18947@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20061211132625.GA18947@htj.dyndns.org> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 913 Lines: 23 Tejun, On 11/12/06, Tejun Heo wrote: > piix_init_one() allocates host private data which should be freed by > piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() > while merging, leaking 4 bytes on driver detach. Fix it. I tried your patch last night but the leak is still reported. I need to investigate further and put some printk's in the piix_host_stop function to check whether the freeing really takes place. What I can't follow is where the ata_port_info.private_data (port_info[] or ppinfo[]) in piix_init_one gets transfered to ata_host.private_data (the "host" argument) that piix_host_stop tries to free. -- Catalin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/