Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1782142pxb; Thu, 16 Sep 2021 15:46:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyUUfHFw1esmNm0EB4fvsQH+ORpiFCPov0BT2nNegmBhO/dlnB/SsOfWeijWdnjPyprvvgU X-Received: by 2002:a92:6b01:: with SMTP id g1mr5493369ilc.251.1631832359844; Thu, 16 Sep 2021 15:45:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631832359; cv=none; d=google.com; s=arc-20160816; b=O63DMmLJEVYL6aY1N1WJEACRNfQh4EidohRS6NGuglD7qCAhjC6dvUJpmqGMr2r06e ItXIEl//SppVV1sAhP93UY0nIG4GN9gX2BhD4fPyu4gU0C39kG2UUMBq+jNbCIKp9saN 3q+VPkFSX5CP1pWUxOs986I/iv4uDZltCP+Q3n7quxnJT+KFArUmKraGY7Xz82gkHR2v 9TIwDEQ/yUT/qHOoeli/iSZY6UJ+i9M3/QHZOzBm4jFXHhOPZ6ud5vROHQPKpbrTBjiI SAhinIbUk5WSmuxMApnruR9MteSGCorX9DLcsw/3XJMBdmEsooIBsmqPm9g8B3oqVgp5 sZow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4Dmzil+ikolotlkBJRE7mCwUmVwYeUL5/BCxdpgNnDU=; b=j/zrky/eFUStKNGhAtkX84KFU007WEMyjmLk6YPmkhzEd5Zs2HKwmWesPbVxSQDWj+ GTwxQmx/MKj9VbpgKn21jD/Nv4Ukd1mVJpv4kV+s0ZpU48yLtyq0oNS9/oLqHS7HALc3 rydjUPTWqK5vM+tXpRRW9+O9wG9OvwGFCrKErdxvG6tdI6zhIzLGICNlQXK1/jlRtoiZ Xvb1TL9IaJYlD3wQRAo3RRz+2XHBGULDKncmilMhgEVe5IlQT9lv3flvbWpI8j8bnkx+ hbcLJ2nnQCzcAiBH5ukrdJyX/MAjUuAb1GBjKfxyVqVD2JnsKTlKnD6NKizMJk2GEjY4 +rnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lC9fUk7u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n22si3842354ioo.36.2021.09.16.15.45.47; Thu, 16 Sep 2021 15:45:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=lC9fUk7u; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344018AbhIPQo3 (ORCPT + 99 others); Thu, 16 Sep 2021 12:44:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:51468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243371AbhIPQhS (ORCPT ); Thu, 16 Sep 2021 12:37:18 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 34CD7619E8; Thu, 16 Sep 2021 16:22:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809333; bh=FEvJQsQzQ8BGENlzAqreD/BRTp+4O8RnuRYbpVdzgKw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lC9fUk7ugLua+12obShcsFZJzZ+GecrXjK4w9xNaPQleoLAe+7FceDaVhPEan4QVH gWpJ2S9tsuRjCp9Kjf141w40Zo/FVsT4aS1wY1tKdsNf0nxsGbJO3juc+BhZJ1PWEG eV+o73VfPXwdVJ1XzZJtWANHsbIrUUVLUmO1nNeg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Alim Akhtar , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 5.13 117/380] scsi: ufs: ufs-exynos: Fix static checker warning Date: Thu, 16 Sep 2021 17:57:54 +0200 Message-Id: <20210916155808.017710085@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alim Akhtar [ Upstream commit 313bf281f2091552f509fd05a74172c70ce7572f ] clk_get_rate() returns unsigned long and currently this driver stores the return value in u32 type, resulting the below warning: Fixed smatch warnings: drivers/scsi/ufs/ufs-exynos.c:286 exynos_ufs_get_clk_info() warn: wrong type for 'ufs->mclk_rate' (should be 'ulong') drivers/scsi/ufs/ufs-exynos.c:287 exynos_ufs_get_clk_info() warn: wrong type for 'pclk_rate' (should be 'ulong') Link: https://lore.kernel.org/r/20210819171131.55912-1-alim.akhtar@samsung.com Fixes: 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs") Reported-by: Dan Carpenter Signed-off-by: Alim Akhtar Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/ufs/ufs-exynos.c | 4 ++-- drivers/scsi/ufs/ufs-exynos.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index 70647eacf195..3e5690c45e63 100644 --- a/drivers/scsi/ufs/ufs-exynos.c +++ b/drivers/scsi/ufs/ufs-exynos.c @@ -259,7 +259,7 @@ static int exynos_ufs_get_clk_info(struct exynos_ufs *ufs) struct ufs_hba *hba = ufs->hba; struct list_head *head = &hba->clk_list_head; struct ufs_clk_info *clki; - u32 pclk_rate; + unsigned long pclk_rate; u32 f_min, f_max; u8 div = 0; int ret = 0; @@ -298,7 +298,7 @@ static int exynos_ufs_get_clk_info(struct exynos_ufs *ufs) } if (unlikely(pclk_rate < f_min || pclk_rate > f_max)) { - dev_err(hba->dev, "not available pclk range %d\n", pclk_rate); + dev_err(hba->dev, "not available pclk range %lu\n", pclk_rate); ret = -EINVAL; goto out; } diff --git a/drivers/scsi/ufs/ufs-exynos.h b/drivers/scsi/ufs/ufs-exynos.h index 06ee565f7eb0..a5804e8eb358 100644 --- a/drivers/scsi/ufs/ufs-exynos.h +++ b/drivers/scsi/ufs/ufs-exynos.h @@ -184,7 +184,7 @@ struct exynos_ufs { u32 pclk_div; u32 pclk_avail_min; u32 pclk_avail_max; - u32 mclk_rate; + unsigned long mclk_rate; int avail_ln_rx; int avail_ln_tx; int rx_sel_idx; -- 2.30.2