Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1795597pxb; Thu, 16 Sep 2021 16:07:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyfVNsQ98jW6QOcPWwmPi3iSm32AL0OGup3ReotvLul5xtyu8Ldzb5XrrYqAnioDiCSd6xv X-Received: by 2002:a05:6e02:551:: with SMTP id i17mr5718023ils.281.1631833658981; Thu, 16 Sep 2021 16:07:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631833658; cv=none; d=google.com; s=arc-20160816; b=rpOso8LIQR4y2d7gLM7NEPgTMRpmXXyycEf/iD97h+MIo7OYxWrlyZN+w9nXZCVHZE +CkSPZkF8+5vl1OWxDSQm2P5WD3IsQctm2BqS6nuhT7jg0BNWGxbIgvdQKXT7wlqfJjk IZg7aK0TTVHm4yMHjf/cd6FRVCbV8WWFp6OrEisKq+gqNwQ9QGtKDZyGffq52DY4xdIj ToCv1+S9+VW3kF3BWL96ospgOjmQsQwSTZCj6AEb3v7t9Seb8Xeu9iEwvscaMS6o/1bT ag377IVvY8rOfsCa/D7n0DR4IvvKOl63bDRzexu0ScHfwLhJnuWnraan8Di2UwJ3YPLb F4GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hNN6Kw/0E0+Tznzij7ugY9fxI6c2+rFdfcUBBHamzII=; b=O6bRshMOsMy5oqS7wEiiVX8+YMPBqdZsOQ+WEuIfLqJxPuCPQE6e8Jx3w8HYQuQSmn pm9fRvSJHyYNisa8O49aikl3pAbp+VjYf5cmuOQoquHbuYdaogTKeGvWX38Rzy6bTiyt R/qhNH8xLkzcZgQ9tKISS+eq5OypJY4inrOApaCUcvdU1Y/BzJQ6qVQ+3FpLOgRY6Cz3 XIQsQXh+7fJImzi/SrVr69VVCZtJDrK/jEjnJ+y9PrlJdV9v8FdFcl2c2ZVrFlKrk3Mr yiqSOlcBoP4Mjr2NmlgBp4WugE1va/RcMfJlezOu7Z/yX9dwseMeJbRUqIutjfy91+zN arGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Pkdq2LfI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o20si4631571iov.71.2021.09.16.16.07.27; Thu, 16 Sep 2021 16:07:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Pkdq2LfI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242757AbhIPQrV (ORCPT + 99 others); Thu, 16 Sep 2021 12:47:21 -0400 Received: from mail.kernel.org ([198.145.29.99]:51976 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242085AbhIPQlt (ORCPT ); Thu, 16 Sep 2021 12:41:49 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1B9FC61462; Thu, 16 Sep 2021 16:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809454; bh=35atDnHr5kKPvD7ZRVCpmrxJQhwkKsyZnBkWc0xcL9g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pkdq2LfIeyxtVwpurPYLECt39Qqkck4W6JzHE81f0UceAqoZI7zi0ANHGDODyRPbY b0KaS0bWpqeHF8HoQp1Z93radRrM4O4oCAg4+DNVxBhHlCYg8c5yawRQOpcfeQfM4D L7goJIDn9GGplC91iwyGQwSnzwtP1HmDbYXRNQuM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zheyu Ma , Sam Ravnborg , Sasha Levin Subject: [PATCH 5.13 160/380] video: fbdev: kyro: fix a DoS bug by restricting user input Date: Thu, 16 Sep 2021 17:58:37 +0200 Message-Id: <20210916155809.527412826@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zheyu Ma [ Upstream commit 98a65439172dc69cb16834e62e852afc2adb83ed ] The user can pass in any value to the driver through the 'ioctl' interface. The driver dost not check, which may cause DoS bugs. The following log reveals it: divide error: 0000 [#1] PREEMPT SMP KASAN PTI RIP: 0010:SetOverlayViewPort+0x133/0x5f0 drivers/video/fbdev/kyro/STG4000OverlayDevice.c:476 Call Trace: kyro_dev_overlay_viewport_set drivers/video/fbdev/kyro/fbdev.c:378 [inline] kyrofb_ioctl+0x2eb/0x330 drivers/video/fbdev/kyro/fbdev.c:603 do_fb_ioctl+0x1f3/0x700 drivers/video/fbdev/core/fbmem.c:1171 fb_ioctl+0xeb/0x130 drivers/video/fbdev/core/fbmem.c:1185 vfs_ioctl fs/ioctl.c:48 [inline] __do_sys_ioctl fs/ioctl.c:753 [inline] __se_sys_ioctl fs/ioctl.c:739 [inline] __x64_sys_ioctl+0x19b/0x220 fs/ioctl.c:739 do_syscall_64+0x32/0x80 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xae Signed-off-by: Zheyu Ma Signed-off-by: Sam Ravnborg Link: https://patchwork.freedesktop.org/patch/msgid/1626235762-2590-1-git-send-email-zheyuma97@gmail.com Signed-off-by: Sasha Levin --- drivers/video/fbdev/kyro/fbdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/video/fbdev/kyro/fbdev.c b/drivers/video/fbdev/kyro/fbdev.c index 8fbde92ae8b9..4b8c7c16b1df 100644 --- a/drivers/video/fbdev/kyro/fbdev.c +++ b/drivers/video/fbdev/kyro/fbdev.c @@ -372,6 +372,11 @@ static int kyro_dev_overlay_viewport_set(u32 x, u32 y, u32 ulWidth, u32 ulHeight /* probably haven't called CreateOverlay yet */ return -EINVAL; + if (ulWidth == 0 || ulWidth == 0xffffffff || + ulHeight == 0 || ulHeight == 0xffffffff || + (x < 2 && ulWidth + 2 == 0)) + return -EINVAL; + /* Stop Ramdac Output */ DisableRamdacOutput(deviceInfo.pSTGReg); -- 2.30.2