Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1797986pxb; Thu, 16 Sep 2021 16:11:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzPcHoCWRVAkuKxVmg141Tn4aHZLtrJJfwEE0RoM9uazMjXbuXw6+Y3ckp0dJxWOSbzJ2ry X-Received: by 2002:a50:d5c1:: with SMTP id g1mr8897948edj.296.1631833876069; Thu, 16 Sep 2021 16:11:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631833876; cv=none; d=google.com; s=arc-20160816; b=BRpREXsnKfMuzT0KgDMGujBsUG5eZIQbz0KJKN9q/ZiTVjPpuI9vRKTdJhqWWXaTeA Ey2GAFohjW+q3WmvILJ/l549K2BtvmtPX8z7vDaHmDxJvJnut+chDff6Z4YRHzGZ3GBi hUcuAekoc0Y52nAG0RHcGM7TqOvkcuK8a9sXS0H1l6xG0zBqMuYdVE2RcyPa3xXNh6v2 guLkYB2Syo/mjhdgTZFMa1JHp735Je7+aRSIcIB+TBsQqZ7vZqxniZ37TcVLRiUOjVVs ameM04hdhlvnBj25lvti2P7qxQ7Syx43Ml/6l+DrazGAFSNGfMLt1+OOOREZTP+alK+R 4zbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TTJQ8DJi7KFbxPms1YkMmnk5TOuAJbcUEY/GVHlCjG0=; b=PIFlZ2ewSH/FtKzzBJ91VlD6Kj2elm8u2ZdK7oK3LlmrJyMlF4SRzbbuoD2Sgl5EFw Qtue5bKyiNVQu/dXS4gua56FHq8mFwV6AMf/R9sRPlpl7QKRt6i0TYhC5VBF3YfhJi/N TIMgj77ACD9oj50Z9WwwObCLvW8cWjkRtsK4QW0nnw376sCVn4Z4t31eeJEqo8PdxCVW 67AP6QPxeMfsSp9Zs3jpvydg4XQlxiIWEaSMF/I2/oTgf0XqbVV9uu3YmHNVbZKFkCiK Rbe03IXLUYI5hpDfVv5KxxM16dYM0lcXreKe8VtqidFD7A4O4juTCdwYKhe9+5Na5fWj gJRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XS8nZWnu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ec20si918297ejb.166.2021.09.16.16.10.51; Thu, 16 Sep 2021 16:11:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=XS8nZWnu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344900AbhIPQtX (ORCPT + 99 others); Thu, 16 Sep 2021 12:49:23 -0400 Received: from mail.kernel.org ([198.145.29.99]:57216 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343976AbhIPQoX (ORCPT ); Thu, 16 Sep 2021 12:44:23 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9B0EC613B5; Thu, 16 Sep 2021 16:25:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809532; bh=9uEK5ch/0koadmm5ISQP1eZBugoE4KpaKxYwact33jU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XS8nZWnuo8hm9fdCf+ep8uOiSZJcaocnnbKXcVM8oYA8A6zNk+apYPuz7kHsqUD7a ZDfN0gHbu6svZQ6xTCYlp2LJpvPOpeXehf1pOj6NxRSsCN5Q4Yz9yCoPT+jlfw62QM JRdsn2UKzaTqmjdB2feb1jcel/avKjZ855lINEL0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Oak Zeng , Christian Konig , Alex Deucher , Sasha Levin Subject: [PATCH 5.13 189/380] drm/amdgpu: Fix a printing message Date: Thu, 16 Sep 2021 17:59:06 +0200 Message-Id: <20210916155810.501101374@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Oak Zeng [ Upstream commit 95f71f12aa45d65b7f2ccab95569795edffd379a ] The printing message "PSP loading VCN firmware" is mis-leading because people might think driver is loading VCN firmware. Actually when this message is printed, driver is just preparing some VCN ucode, not loading VCN firmware yet. The actual VCN firmware loading will be in the PSP block hw_init. Fix the printing message Signed-off-by: Oak Zeng Reviewed-by: Christian Konig Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c | 2 +- drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index 27b1ced145d2..14ae2bfad59d 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c @@ -119,7 +119,7 @@ static int vcn_v1_0_sw_init(void *handle) adev->firmware.ucode[AMDGPU_UCODE_ID_VCN].fw = adev->vcn.fw; adev->firmware.fw_size += ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE); - DRM_INFO("PSP loading VCN firmware\n"); + dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); } r = amdgpu_vcn_resume(adev); diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c index 8af567c546db..f4686e918e0d 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_0.c @@ -122,7 +122,7 @@ static int vcn_v2_0_sw_init(void *handle) adev->firmware.ucode[AMDGPU_UCODE_ID_VCN].fw = adev->vcn.fw; adev->firmware.fw_size += ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE); - DRM_INFO("PSP loading VCN firmware\n"); + dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); } r = amdgpu_vcn_resume(adev); diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c index 888b17d84691..e0c0c3734432 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v2_5.c @@ -152,7 +152,7 @@ static int vcn_v2_5_sw_init(void *handle) adev->firmware.fw_size += ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE); } - DRM_INFO("PSP loading VCN firmware\n"); + dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); } r = amdgpu_vcn_resume(adev); diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c index 3b23de996db2..c2c5c4af51d2 100644 --- a/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v3_0.c @@ -152,7 +152,7 @@ static int vcn_v3_0_sw_init(void *handle) adev->firmware.fw_size += ALIGN(le32_to_cpu(hdr->ucode_size_bytes), PAGE_SIZE); } - DRM_INFO("PSP loading VCN firmware\n"); + dev_info(adev->dev, "Will use PSP to load VCN firmware\n"); } r = amdgpu_vcn_resume(adev); -- 2.30.2