Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1801846pxb; Thu, 16 Sep 2021 16:17:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzKjkyRFRXX5yG/Gcp78NW6Jm6IYQSPvuoEBiaKn/WkRYjUEsJaPFBginP3XBQ89UlwPoW X-Received: by 2002:a50:c006:: with SMTP id r6mr9069581edb.289.1631834275139; Thu, 16 Sep 2021 16:17:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631834275; cv=none; d=google.com; s=arc-20160816; b=xX9TUTpWeDSDgJeCJ2BWlIj3QMpRY4xPfhAfyN3QSyABY+8ROaR6Faj6K9OFwhBP1H qJ1BgNig1vhgJBhQlMZ2fYPBONjP0ya5Z1pNsXwkhzlvzoUS2auoKnlAy4fvC+jkCabd s1ZikMYY1NpveXZZobYTs0kRlgIBK+QXPb7osITbf6GAGls8DXh273FZWsgIux36OQkw gAdk7FaxGV5TBFLPzFr0VaCT9ITT//d24N47jA3p0QzsNZHqadAzpzwrypz08nB3G5XI 4pBZC5sdJQ1a9ZM+PRWTmW2ep8rAwZMKMDAkeZ1Sx2zpf+VWj3sYTC29W6IEaGgaqI6x vtTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=09qUc6WuwStcCvWtd5vEtYVbM5xLVo1Q/dO3mAcv//I=; b=acN40TxItb2VQ2SU2EPnqpfrHCacdqwBV/GqTdyxDJcloL2gJm4CVNMZ+MQBPcSkNu okXU7zysPUaEvVgkKhp+X/ugz5kXqMjX8InVlsoLLxbWzr3G4ZMr2G9mxbCbB1Ndzt2h tpM/shj6gvb0bFv6IOn2Zklw0rV/z0QDn5wthAzuySjjtFNfFWhOaYPtBdwQrSGAebpP UDFraBGI67j08RBov+pcPdcps6NSMjrCtssVjd2Uosp5EE/2TYqPC0PcCYOktf+LD6F+ egUPELaLGvi6GdGL/AbvyOHFzqIq/xdi69tTjzgdlT6WOEQtZJkQcEx2PDZ9pMojPOat OVkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Lp9IDGKr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kl24si5365479ejc.190.2021.09.16.16.17.31; Thu, 16 Sep 2021 16:17:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Lp9IDGKr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243393AbhIPQ4f (ORCPT + 99 others); Thu, 16 Sep 2021 12:56:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:39406 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240638AbhIPQvn (ORCPT ); Thu, 16 Sep 2021 12:51:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2056A61A84; Thu, 16 Sep 2021 16:28:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809726; bh=sYydYxRyDsnWxhv0ACQkOPeeGjMFpExS/qG7QDvFyBU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Lp9IDGKrCHwFHRMA/nID7lKDk2ZK2sSDt12Fc0mOHBVFtYV5uMn8M8nBoIARlw5YN STMDsPzcSrY0tTM/Ahb9L33NblhcRPZiuuU2qNM/KhBcvLx9s0LUK4QQ6nw/LGXTTN yNssFk2FI3eTYT6viGPQZATaVUNQxaJqMtZv76YE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, kernel test robot , Dan Carpenter , Eran Ben Elisha , Moshe Shemesh , Saeed Mahameed , Sasha Levin Subject: [PATCH 5.13 261/380] net/mlx5: Fix variable type to match 64bit Date: Thu, 16 Sep 2021 18:00:18 +0200 Message-Id: <20210916155812.956220743@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eran Ben Elisha [ Upstream commit 979aa51967add26b37f9d77e01729d44a2da8e5f ] Fix the following smatch warning: wait_func_handle_exec_timeout() warn: should '1 << ent->idx' be a 64 bit type? Use 1ULL, to have a 64 bit type variable. Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Eran Ben Elisha Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c index 9d79c5ec31e9..db5dfff585c9 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c @@ -877,7 +877,7 @@ static void cb_timeout_handler(struct work_struct *work) ent->ret = -ETIMEDOUT; mlx5_core_warn(dev, "cmd[%d]: %s(0x%x) Async, timeout. Will cause a leak of a command resource\n", ent->idx, mlx5_command_str(msg_to_opcode(ent->in)), msg_to_opcode(ent->in)); - mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true); + mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true); out: cmd_ent_put(ent); /* for the cmd_ent_get() took on schedule delayed work */ @@ -994,7 +994,7 @@ static void cmd_work_handler(struct work_struct *work) MLX5_SET(mbox_out, ent->out, status, status); MLX5_SET(mbox_out, ent->out, syndrome, drv_synd); - mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true); + mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true); return; } @@ -1008,7 +1008,7 @@ static void cmd_work_handler(struct work_struct *work) poll_timeout(ent); /* make sure we read the descriptor after ownership is SW */ rmb(); - mlx5_cmd_comp_handler(dev, 1UL << ent->idx, (ent->ret == -ETIMEDOUT)); + mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, (ent->ret == -ETIMEDOUT)); } } @@ -1068,7 +1068,7 @@ static void wait_func_handle_exec_timeout(struct mlx5_core_dev *dev, mlx5_command_str(msg_to_opcode(ent->in)), msg_to_opcode(ent->in)); ent->ret = -ETIMEDOUT; - mlx5_cmd_comp_handler(dev, 1UL << ent->idx, true); + mlx5_cmd_comp_handler(dev, 1ULL << ent->idx, true); } static int wait_func(struct mlx5_core_dev *dev, struct mlx5_cmd_work_ent *ent) -- 2.30.2