Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1802162pxb; Thu, 16 Sep 2021 16:18:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKTalFnRJGf2cqRs4xdQvWDUP5qH7Q2jsNArA5Gnz15gg7/8qN68SSvh8HdiUtQJcCMrJJ X-Received: by 2002:a17:906:aeda:: with SMTP id me26mr9037811ejb.83.1631834306440; Thu, 16 Sep 2021 16:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631834306; cv=none; d=google.com; s=arc-20160816; b=rTJTRvKtPsvyCXCCsKZSyhm+UHtp7ccUVBJwQeuN9sLK1l0BviyNr2bPeNJK93svge hznKEhXUcdnNUoKG4hXSxZq/tU0vfX2MQHz0ZlyjpaImhtXgz84BB0ATdhcTXlrXv5Xc 9rQvCP6A8tBdPtxM9jg2yvPr8rFhrXxfKUdPpw6BpU9abvJtXUbYPEmPymhaWwDZRKLM Muu6wIXgAylG8U+gMPImpzmMfBiUwJ5irqdurtOFfxuKGmBbVmY98txDuj7klKC7uTxV GLe6CtzsuP0cDaLAXcSvThKaGMKLMJ0xme7K/8QVEmAgRVZF8HbbI9BvKa38DRhU1Us9 8CdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oc5++N+YcrMsd59b1gAiqHTFhVobhMA43W1bGrU2fjc=; b=uMO6bfNarNxZcFaO0/mM3l2T3AkE1p2NxKrLzEHYm51wbe4KzFfD0TV8sX9JdndvDY xHnNoxH7Ctar+zB0q7pf65grrPWzgpFYY7ZOHyCd30iTtIWT1ilQlE4+sKW8JgTM64HG rB3N937CgrStRK2xh7GzBeyc2GLRcLdnLxkj+3mz51Xv11y2gPln2QWWmTVyoktMi6M3 +9UPNvSK6n6vMff2EGJixAkPcNHhQYOURMJuw65zjUKbat4FnBSbiNo+VEH40/9cEnKi 6GX0mw/pvFLhryBRCU5AK8JBq08QNfhgoWqIVXaEAnx3t1SLQb+NaFfz9pjEU89DZ586 JUPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=e2q45D5C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gb4si222983ejc.246.2021.09.16.16.18.02; Thu, 16 Sep 2021 16:18:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=e2q45D5C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346842AbhIPQ4R (ORCPT + 99 others); Thu, 16 Sep 2021 12:56:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:39404 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240656AbhIPQvn (ORCPT ); Thu, 16 Sep 2021 12:51:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E987361288; Thu, 16 Sep 2021 16:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809729; bh=taatuuLuDBoBSsvAWC34YtQ3EAR1kJj2dTPwEIz+LIE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e2q45D5CRXLGzBlu8Z1qa/6ubayHJN/YJaLVxMFxidMrH3197ZOIXtTkJEMQZnSEk wRVgG70LhtTS0DQGMdNtHQ+fF/LxuVNJasPTGTGecum3/QFPXlOAeZwCeccGB3qxBN CFAdXv9mrIGWy9x8rhnYufy8v0gkauKkvPMblvO4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, TOTE Robot , Tuo Li , Alex Deucher , Sasha Levin Subject: [PATCH 5.13 262/380] gpu: drm: amd: amdgpu: amdgpu_i2c: fix possible uninitialized-variable access in amdgpu_i2c_router_select_ddc_port() Date: Thu, 16 Sep 2021 18:00:19 +0200 Message-Id: <20210916155812.987786448@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Tuo Li [ Upstream commit a211260c34cfadc6068fece8c9e99e0fe1e2a2b6 ] The variable val is declared without initialization, and its address is passed to amdgpu_i2c_get_byte(). In this function, the value of val is accessed in: DRM_DEBUG("i2c 0x%02x 0x%02x read failed\n", addr, *val); Also, when amdgpu_i2c_get_byte() returns, val may remain uninitialized, but it is accessed in: val &= ~amdgpu_connector->router.ddc_mux_control_pin; To fix this possible uninitialized-variable access, initialize val to 0 in amdgpu_i2c_router_select_ddc_port(). Reported-by: TOTE Robot Signed-off-by: Tuo Li Signed-off-by: Alex Deucher Signed-off-by: Sasha Levin --- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c index bca4dddd5a15..82608df43396 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c @@ -339,7 +339,7 @@ static void amdgpu_i2c_put_byte(struct amdgpu_i2c_chan *i2c_bus, void amdgpu_i2c_router_select_ddc_port(const struct amdgpu_connector *amdgpu_connector) { - u8 val; + u8 val = 0; if (!amdgpu_connector->router.ddc_valid) return; -- 2.30.2