Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1802164pxb; Thu, 16 Sep 2021 16:18:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyFtO/3CxEm4SnijsO01RHiJEuTwRfpnBWAmuOSLYuITHBdpg/ZN95jjfDrVcFZENSnn5vn X-Received: by 2002:a17:906:144e:: with SMTP id q14mr8686082ejc.19.1631834306695; Thu, 16 Sep 2021 16:18:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631834306; cv=none; d=google.com; s=arc-20160816; b=N7PYV49QG9+1USothptsUdr9wtPQWwkVeUSJ1sw4QtoVKpOK3KjZ8cDolaVxRMjbhA GWg66n0x6XfIulqV3h+xerYUtI91NZv7mw2g6NKfKCRbr3dQBr2cHXdEOeiQhN8FHMcg xMDCSkrdQmGXN1hYtj57NdCRw+w3BCan099dJmZuS+ao7PgnG89+dkcKZuCnsX2OMTYv EUVypsXLdtQivsp1qRdeynxSKYabvlBC5BVL/3o48TL2ZX1NF9ieMMqVKNLeeNrRHqJ3 hUXNQPAWj5jE3l2LdAdHMoDndERIIIf3vcLIVWYOc34GjzyNON2TkGPaTYUyUgu4/9l3 SNiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=DBOSfe+dEroBf/0tw8QVLVJXX6VL6QpGZYNrxniNEz8=; b=XygYcqkFtc6tZu/TwGOmmpHZZqKoOP5uf02zxS5wzm7exPON5VrXhUiktm+XiVCza+ JVQHfNY/gmN6OADIpsOYgI5ZEfnqHF4g037zf54O6CBKBIOKpNquHjo5/WnUP79Eh8dt bawtWNGDmyK3ejH5G3Vn+og/x2FbcXIcbFC4sABCgIOtkU7X+7ZZRlS2X9+cUjAFm15h alS6JjFS2vFyuo0zINZYOMn3HqsX2MLGAw04g88CWJ4rSbKG6CHWM5FlZ7sgPPdfTx66 oriVUtpmlzPC8hH0QBKQ5gsYe5ulXM8mhp2Q6bEM1r0nkn4K/Ooq9R3tlmbrjJQ02++G FlhQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Z3LZk/jY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 26si5126981ejl.648.2021.09.16.16.17.58; Thu, 16 Sep 2021 16:18:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="Z3LZk/jY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346794AbhIPQ4I (ORCPT + 99 others); Thu, 16 Sep 2021 12:56:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:38630 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345915AbhIPQvB (ORCPT ); Thu, 16 Sep 2021 12:51:01 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DF2D361A82; Thu, 16 Sep 2021 16:28:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631809721; bh=JcKEbqG4ljzAwAQ/lX3iUIJsq4CBhbZUDu34o5T0zxY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z3LZk/jYVxThpsTDHAWoKgJ8CWHS5YrO92HDUO+owKfdqx5czVGtxnuXt9xxiAA8H pQpPwx+XcBXn1VwlXJrJH+Nv6LPsd9chPRLnTWboA0RDcO2YDowF+EUG3WykTO9wmU HW3m0UjylF0bI3GO8yHNHFhjPGjIihFRcroV8a00= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Kuogee Hsieh , Stephen Boyd , Rob Clark , Sasha Levin Subject: [PATCH 5.13 259/380] drm/msm/dp: return correct edid checksum after corrupted edid checksum read Date: Thu, 16 Sep 2021 18:00:16 +0200 Message-Id: <20210916155812.891561348@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155803.966362085@linuxfoundation.org> References: <20210916155803.966362085@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kuogee Hsieh [ Upstream commit 7948fe12d47a946fb8025a0534c900e3dd4b5839 ] Response with correct edid checksum saved at connector after corrupted edid checksum read. This fixes Link Layer CTS cases 4.2.2.3, 4.2.2.6. Signed-off-by: Kuogee Hsieh Reviewed-by: Stephen Boyd Link: https://lore.kernel.org/r/1628196295-7382-6-git-send-email-khsieh@codeaurora.org Signed-off-by: Rob Clark Signed-off-by: Sasha Levin --- drivers/gpu/drm/msm/dp/dp_panel.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_panel.c b/drivers/gpu/drm/msm/dp/dp_panel.c index 9cc816663668..6eeb9a14b584 100644 --- a/drivers/gpu/drm/msm/dp/dp_panel.c +++ b/drivers/gpu/drm/msm/dp/dp_panel.c @@ -272,7 +272,7 @@ static u8 dp_panel_get_edid_checksum(struct edid *edid) { struct edid *last_block; u8 *raw_edid; - bool is_edid_corrupt; + bool is_edid_corrupt = false; if (!edid) { DRM_ERROR("invalid edid input\n"); @@ -304,7 +304,12 @@ void dp_panel_handle_sink_request(struct dp_panel *dp_panel) panel = container_of(dp_panel, struct dp_panel_private, dp_panel); if (panel->link->sink_request & DP_TEST_LINK_EDID_READ) { - u8 checksum = dp_panel_get_edid_checksum(dp_panel->edid); + u8 checksum; + + if (dp_panel->edid) + checksum = dp_panel_get_edid_checksum(dp_panel->edid); + else + checksum = dp_panel->connector->real_edid_checksum; dp_link_send_edid_checksum(panel->link, checksum); dp_link_send_test_response(panel->link); -- 2.30.2