Received: by 2002:a05:6a11:4021:0:0:0:0 with SMTP id ky33csp1899643pxb; Thu, 16 Sep 2021 19:33:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwGcXSQzKIiXylKcvvqb6Eg3o65cMDEMdw6aWslM7ddmwOtE318vZl3G9UPT3UKWi+HDpDt X-Received: by 2002:a05:6e02:1aa6:: with SMTP id l6mr6078886ilv.231.1631846011473; Thu, 16 Sep 2021 19:33:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1631846011; cv=none; d=google.com; s=arc-20160816; b=mUuVaI62iHgLjC3ricUWb020MRlr8EMIsI4qhI31vkgZSl0sFFGUVMNUAAQSBZz6r2 tYc7/KPGbVwN6IJmf0DVC68h7xHuKd35Hc4XRCnWq6y+nkrCP4muJaK54rQHSB/YD7u/ uXM3q1KPCydlLwmHG1V4pQ1uAm9AXZfEZxKo9FNb+dshLAGu90rhr4pIOPbwauj+riJY gR9UerpBxGTAGYp4iLaC9iGOWlL9SUCcpV+c22tEblG+E9QFMjP4thK1/TQb+PGbBQ3O GepL6Pv9jH+CHpCH1zMecEVT8qHX6ET+JLq92Jd1dzi7O9OOB7hxDTXrjR7oYCqYP7xU qeDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=NS/aq0EzE2zKCwFYeyw7hs6g7Xyd7iPtXoAVpYnQViw=; b=u49QkrUUsbSJgmW/4vXXrv2NR6c3PVjEB+6RXG23tHdBtF87VWcyAk3MppwgW7X0fY f9n3hCupo0Y/SG2iSKCziSYD3YsG7cVlBIAbXO6l4AIX6fL6630ra5Sd2X1BrNOtAV3S oZwQ6j0JjMWJSSujvmQ1GikFQAvOG9o1m3sY4V3SpH89wQ5hAJe6UpsUcHcDaLsG57rt yrqtZMyYv8DJxR2HYvR7VjBKU2y3/L92FXUbFmbg9KZRlLGLPa11bWoB9CX/Sh8OBSsu 2gD41Bm97ej1/7h72ehyysGmE7O00PyOBqbKsL9o6mxSSR1kl2hlHOHZHvDdqtT+7+aU njKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=f+1TLM1N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si4117059ilv.158.2021.09.16.19.33.17; Thu, 16 Sep 2021 19:33:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=f+1TLM1N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346216AbhIPRRp (ORCPT + 99 others); Thu, 16 Sep 2021 13:17:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:35904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350442AbhIPRJw (ORCPT ); Thu, 16 Sep 2021 13:09:52 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DB81A60F23; Thu, 16 Sep 2021 16:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1631810230; bh=OK4ZQDL9/nYBHBOcJhCqJzFMKg0XTQfeJIoi9CV2PyU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f+1TLM1NMoFeNWVAjBKyjJHDS3DOoSnzsIbnWHHfmAHU0+z7ugs6FFU2xYWPd/5ow qxa0gfLlA8at7Tup7Am2oaI4g2ZLrIPp2PPF+QApPoMK4HVW4waOLBTGZkAvhoxZ1N nJDN9Xp6c/z2e+A708iu8qx0RfhytVwbL6XZlwVg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Robin Gong , Vinod Koul , Richard Leitner , Shawn Guo Subject: [PATCH 5.14 057/432] dmaengine: imx-sdma: remove duplicated sdma_load_context Date: Thu, 16 Sep 2021 17:56:46 +0200 Message-Id: <20210916155812.725438157@linuxfoundation.org> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210916155810.813340753@linuxfoundation.org> References: <20210916155810.813340753@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Robin Gong commit e555a03b112838883fdd8185d613c35d043732f2 upstream. Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Fixes: ad0d92d7ba6a ("dmaengine: imx-sdma: refine to load context only once") Cc: Signed-off-by: Robin Gong Acked-by: Vinod Koul Tested-by: Richard Leitner Signed-off-by: Shawn Guo Signed-off-by: Greg Kroah-Hartman --- drivers/dma/imx-sdma.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1161,7 +1161,6 @@ static void sdma_set_watermarklevel_for_ static int sdma_config_channel(struct dma_chan *chan) { struct sdma_channel *sdmac = to_sdma_chan(chan); - int ret; sdma_disable_channel(chan); @@ -1201,9 +1200,7 @@ static int sdma_config_channel(struct dm sdmac->watermark_level = 0; /* FIXME: M3_BASE_ADDRESS */ } - ret = sdma_load_context(sdmac); - - return ret; + return 0; } static int sdma_set_channel_priority(struct sdma_channel *sdmac,