Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <b99f88db-edeb-fab1-803e-5e083594bec8@nvidia.com>
Date:   Thu, 16 Sep 2021 15:57:38 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.1.0
Subject: Re: [PATCH] mm/hugetlb: Drop __unmap_hugepage_range definition from
 hugetlb.h
Content-Language: en-US
To:     Peter Xu <peterx@redhat.com>, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Mike Kravetz <mike.kravetz@oracle.com>
References: <20210916212816.86838-1-peterx@redhat.com>
From:   John Hubbard <jhubbard@nvidia.com>
In-Reply-To: <20210916212816.86838-1-peterx@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ckRRaEJaRHVzM2hwSzFId2dybk5PNW9pazFMa2hWcjUwaWtCOGdxdUJrL2ZI?=
 =?utf-8?B?SWx5SkFkZ29jdkMxeXlyVFBZU1FBZXY1aVRaeGZBcGVCa013aFM1R0R5cC9Z?=
 =?utf-8?B?bFRsN2t0WkxBSVlrYi9JVTllcGRBdU1PQ0d6YjJLWW5ya0s0eEEwOVl2MkRt?=
 =?utf-8?B?UG1Ga1N6dExLV3dLbGh4MWRPRlNtYnhqVlBSV3FXSTU2R1JCYmwwbDlyOHNQ?=
 =?utf-8?B?QTlkQTQ0TWtwYVAzcTF6VDJQV1RxWVRadVpZUVVQbTNsNkxaZ0VrQnk4NUhm?=
 =?utf-8?B?Wi9ROW5VNFVxV0oyVC81U2pDWi9vQVNOR2pDbTFzNWYybGhXaWZOWk9xQlda?=
 =?utf-8?B?bDlZTjBXTWFzbzd1M3FPTmFiY3JQRElUN1dhNzFnN0VWZ1ZOWTl3VEhKbzc5?=
 =?utf-8?B?cFppenE5MzZEWjgvSENPTjhrRXhPVmVBR3RhRGpxRzhudWEwRm9WSHZQbytQ?=
 =?utf-8?B?NnBjb2dlNWFVc0hBdit3ZkdRNW1LU1FYMjMya2txY3ppUVQ2WjU2ckRWeXND?=
 =?utf-8?B?WHM5anNrM1pVT0JmUlBtamZ3K0NzVDl2T1ZJUzBhMDJwWFEwYmxVVDMwNERy?=
 =?utf-8?B?ZTVGVnQ4cUwwOUJaNFZYNUhqMzJOdkhSck03TXZIVk5DcFdPK0lxTGtXVDFh?=
 =?utf-8?B?Ly8zVjRZOTZRR09RZk81KytTajZwbFJOUkhUMS9RT2I0RC9oamsyQkRkZ05k?=
 =?utf-8?B?S0U4S2MveGhaNC9RY3ZScEFyVUVnREpZNlo3YlhUZys4ZHZjTEU1ZllHYmZh?=
 =?utf-8?B?QlVyblIxU2pZSVJJMm5NYXN2ajhrbXUyYWNGMFJFZ1JyWTZuZC9IaTZvL3Zz?=
 =?utf-8?B?NGlVL1h1MzAwSUJidzhNY3FOZkNPNTdzVTcxbzgyQzA1VTJYRVpZMnBSa3lB?=
 =?utf-8?B?ZnhNeVVnUFVPUjFDaGdoK051d3l1Y3BDaktyYjhaVHUrVCtNSDI4dm5TdTFC?=
 =?utf-8?B?UTBMZFNJb2VUUGxyb0VxazhxUzRxVmx2Tll4N09nSTAzekZCL2NGQ1hscEhy?=
 =?utf-8?B?WG13VWJiQWRxc3Z5RUhZV3IvMWFTZENsWER2dXRrWkZXZ1NFblQvWS9tN2pG?=
 =?utf-8?B?alZuNjR6UVZYODdlTzlkbGtzazNrUFo0ZTBoMnduZWlwZE5Pdi9wZTlGTTIw?=
 =?utf-8?B?ZU5oVkh1Y3oxamo4QkJnWVUvcGVBNHNPNTFiK3pUT1dPUFRybWdXZkZCSVJC?=
 =?utf-8?B?UWVZVEZBZGNmUFpMSVA3dGhtWGpiR1dieHZGVHZWc3RKbzZ1bDJuVmcwdDhx?=
 =?utf-8?B?OXFZRW0xdCs4elVzSmJHTVpmMXl3cFhYbUJVbVRVUVNFM1g0SUlkTGh2RUN6?=
 =?utf-8?B?U2lWbkxBN1RhOUNHN2lWYU5iK3ozb2Q0TDArSUp1clhHV2c5Rk4yb0RnWG41?=
 =?utf-8?B?YTl0Z280anNweXJnZnFHRU5mUUNpU2FyYkJxdDNWaHRsTGk2bG12MEt5VHJG?=
 =?utf-8?B?TXNwQjE4SFFSYjRFK05TQmEzRVk2TjFzeDIzS214MTNkb2VGTDNOMVNHSW01?=
 =?utf-8?B?QThSSTBYOGlablo1RVdLdElMbklMN3RqYzBLQVNXd2xVZEZTM2d2UjFqSUtF?=
 =?utf-8?B?bEEySFIvd1JKM2YydmJqQ08zOHlGT1NIRzVyQmZyLzF5OVVyMlcrRTJ6SEw3?=
 =?utf-8?B?eGZuU0wvU1g4aUdBcGlqTTJPUnFqMGp6UkRGM2dJUVdUMWtDVVNDMi9JY0Fo?=
 =?utf-8?B?M1lkdGsvc3F0WFFaRmtKbWtadDdqMnlIY0Y1Vkc3eUFhSDVYQ053ZGs2cm44?=
 =?utf-8?Q?GtPghujcTkehpWZijZC76k8Zo2+kcGulNGV4Mlt?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2550507f-3d49-458f-6d25-08d97965630b
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4140.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 22:57:41.1450
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: raUG/leiIZrhetwktEDDuPBiXY2bvW5pgijEO4a8zQMxu1MRiH0jFKlnb9wdjp3rW7uXx6/hhq+QeGpSUF4BiA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4284
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 9/16/21 14:28, Peter Xu wrote:
> Drop it in the header since it's only used in hugetlb.c.

Hi Peter,

Tiny documentation tweak: could the above line please be changed to
something approximately like this:

"Remove __unmap_hugepage_range() from the header file, because it is
only used in the .c file."

?

Because: "drop it in" is so close to "drop it into" (which means, "add
it to"), that it's actually reading a lot like the opposite of what you
intend to say.

> 
> Suggested-by: Mike Kravetz <mike.kravetz@oracle.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>   include/linux/hugetlb.h | 10 ----------
>   mm/hugetlb.c            |  6 +++---
>   2 files changed, 3 insertions(+), 13 deletions(-)


The change itself looks accurate for the current top of tree, so:

Reviewed-by: John Hubbard <jhubbard@nvidia.com>


thanks,
-- 
John Hubbard
NVIDIA

> 
> diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h
> index 1faebe1cd0ed..3cbf60464398 100644
> --- a/include/linux/hugetlb.h
> +++ b/include/linux/hugetlb.h
> @@ -143,9 +143,6 @@ void __unmap_hugepage_range_final(struct mmu_gather *tlb,
>   			  struct vm_area_struct *vma,
>   			  unsigned long start, unsigned long end,
>   			  struct page *ref_page);
> -void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
> -				unsigned long start, unsigned long end,
> -				struct page *ref_page);
>   void hugetlb_report_meminfo(struct seq_file *);
>   int hugetlb_report_node_meminfo(char *buf, int len, int nid);
>   void hugetlb_show_meminfo(void);
> @@ -385,13 +382,6 @@ static inline void __unmap_hugepage_range_final(struct mmu_gather *tlb,
>   	BUG();
>   }
>   
> -static inline void __unmap_hugepage_range(struct mmu_gather *tlb,
> -			struct vm_area_struct *vma, unsigned long start,
> -			unsigned long end, struct page *ref_page)
> -{
> -	BUG();
> -}
> -
>   static inline vm_fault_t hugetlb_fault(struct mm_struct *mm,
>   			struct vm_area_struct *vma, unsigned long address,
>   			unsigned int flags)
> diff --git a/mm/hugetlb.c b/mm/hugetlb.c
> index 95dc7b83381f..d394d9545c4e 100644
> --- a/mm/hugetlb.c
> +++ b/mm/hugetlb.c
> @@ -4426,9 +4426,9 @@ int copy_hugetlb_page_range(struct mm_struct *dst, struct mm_struct *src,
>   	return ret;
>   }
>   
> -void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
> -			    unsigned long start, unsigned long end,
> -			    struct page *ref_page)
> +static void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
> +				   unsigned long start, unsigned long end,
> +				   struct page *ref_page)
>   {
>   	struct mm_struct *mm = vma->vm_mm;
>   	unsigned long address;
>