Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Sep 2021 19:25:27 +0100
Message-ID: <87r1dobco8.wl-maz@kernel.org>
From:   Marc Zyngier <maz@kernel.org>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH 5.13 345/380] KVM: arm64: vgic: move irq->get_input_level into an ops structure
In-Reply-To: <20210916155815.779126002@linuxfoundation.org>
References: <20210916155803.966362085@linuxfoundation.org>
        <20210916155815.779126002@linuxfoundation.org>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Thu, 16 Sep 2021 17:01:42 +0100,
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> 
> From: Marc Zyngier <maz@kernel.org>
> 
> [ Upstream commit db75f1a33f82ad332b6e139c5960e01999969d2c ]
> 
> We already have the option to attach a callback to an interrupt
> to retrieve its pending state. As we are planning to expand this
> facility, move this callback into its own data structure.
> 
> This will limit the size of individual interrupts as the ops
> structures can be shared across multiple interrupts.
> 
> Signed-off-by: Marc Zyngier <maz@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>
> ---
>  arch/arm64/kvm/arch_timer.c |  8 ++++++--
>  arch/arm64/kvm/vgic/vgic.c  | 14 +++++++-------
>  include/kvm/arm_vgic.h      | 28 +++++++++++++++++-----------
>  3 files changed, 30 insertions(+), 20 deletions(-)

As I replied to Sasha earlier, I don't see a good reason to backport
this, as it doesn't improve anything on its own. Unless there is a
compelling reason to get this backported, I'd rather see it dropped.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.