Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAHk-=whiFC8Az2wD5_DCeysw+DV4srAj3sCbVP4asPPEJbOpqQ@mail.gmail.com>
 <64b88941-9ec0-8552-d05d-6503497f6f9d@MichaelLarabel.com> <CAHk-=wgcPrGW1=A9XetuUZv_QHf1p7znUUGbm7UCcawbboxRCQ@mail.gmail.com>
In-Reply-To: <CAHk-=wgcPrGW1=A9XetuUZv_QHf1p7znUUGbm7UCcawbboxRCQ@mail.gmail.com>
From:   Shakeel Butt <shakeelb@google.com>
Date:   Thu, 16 Sep 2021 14:04:50 -0700
Message-ID: <CALvZod73acr3zhbGzzQ8YyNGhTOe-6NhUNH6Z6O6FbD+oFoAmw@mail.gmail.com>
Subject: Re: memcg: infrastructure to flush memcg stats
To:     Linus Torvalds <torvalds@linux-foundation.org>
Cc:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Feng Tang <feng.tang@intel.com>,
        Michael Larabel <Michael@michaellarabel.com>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Sep 16, 2021 at 1:45 PM Linus Torvalds
<torvalds@linux-foundation.org> wrote:
>
> So the kernel test robot complained about this commit back when it was
> in the -mm tree:
>
>   https://lore.kernel.org/all/20210726022421.GB21872@xsang-OptiPlex-9020/
>
> but I never really saw anything else about it, and left it alone.
>
> However, now Michael Larabel (of phoronix) points to this commit too,
> and says it regresses several of his benchmarks too.
>
> Shakeel, are you looking at this? Based on previous experience,
> Michael is great at running benchmarks on patches that you come up
> with.
>

Yes, I am actively looking into this and the discussion is happening
at https://lore.kernel.org/all/20210905124439.GA15026@xsang-OptiPlex-9020/T/#u

I would definitely take up with Michael on helping with running the benchmarks.

We know the source of the regression which is queue_work() in
__mod_memcg_lruvec_state(). Previously we were doing atomic addition
up the memcg tree. I have to come up with an approach to reduce the
calls to queue_work() in that path.

thanks,
Shakeel