Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Mike Christie <michael.christie@oracle.com>
To:     stefanha@redhat.com, jasowang@redhat.com, mst@redhat.com,
        sgarzare@redhat.com, virtualization@lists.linux-foundation.org,
        christian.brauner@ubuntu.com, axboe@kernel.dk,
        linux-kernel@vger.kernel.org
Cc:     Mike Christie <michael.christie@oracle.com>
Subject: [PATCH 7/8] vhost: use kernel_copy_process to check RLIMITs and inherit cgroups
Date:   Thu, 16 Sep 2021 16:20:50 -0500
Message-Id: <20210916212051.6918-8-michael.christie@oracle.com>
In-Reply-To: <20210916212051.6918-1-michael.christie@oracle.com>
References: <20210916212051.6918-1-michael.christie@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?WY2G7GAz5cSnnWf7aGedyryYjBJOXNSpDm7tJ9PX9YFQKObpwRmiBBIVnw5q?=
 =?us-ascii?Q?ZsWjbsdPxM6h/LXqeU6m5E8MgiXbqDAr+n/+PZfdbJee876G+6vFOTJz/Tsb?=
 =?us-ascii?Q?ZqEvd3A9wU8MnmUPdVsgI1YXNIIJcZHXEvTafFUtIoopWzep6d+cbwCuf1nV?=
 =?us-ascii?Q?OeDMGNOFZC+HVgh1ctJLOAFuUzwOyW8JKn09NdYpSLKWYSMGetsOOl4Ylogx?=
 =?us-ascii?Q?fTqLir+nGUpDO5rtcy2yvMo35GQ3/Jg/kf2A20Ff1gH95KL8L8cYBRYVgDc5?=
 =?us-ascii?Q?3FSJ9pSjUroKv6Za2uNR4r2bsJWglx3rHWLiuJPI18sPph8BMH1c0HyBV6Yx?=
 =?us-ascii?Q?GgRVl3eW114viAN6guFXmH8daSYimg1v9fNoW8avURhrdAzLmtqNM/B9ad3Q?=
 =?us-ascii?Q?W/1Wdsgdb0X46lYgcmLi/+jSvjNgyw521FdUTco+QCKPpPvxm1LIAUXOLpjN?=
 =?us-ascii?Q?xH4+f0u6a1V/VxUSbm1bi7FCBH8UFY95wtjk02/g1ECjzime422T9N+QQk0N?=
 =?us-ascii?Q?srjF4e1hIOfqgCouvDzFcUo+A4qSVHvZj/GwIQdAGnRmChRaSg3dURzOmE+j?=
 =?us-ascii?Q?jnGjlfpfAvxT5SqJ8rYRkYNM/eIgOgbnsQLN0PD2+dcicpb1guVZcsfgNXyM?=
 =?us-ascii?Q?JHlR0lpqt5teTFe+6tRLaB8v93CVvxXlUkU/Ae98wpA+mLDXbXd7UmHppJuM?=
 =?us-ascii?Q?4KYU1/48wMPzVKb6h5/IgpZb2Q4xMNN55S0JhpMG1apbPh4AxqFQT0wSEfrn?=
 =?us-ascii?Q?09bKNw+2vYd0Oycr6kBpeaw4iKs1lHQtEXq68lfEjWVzPOLXpsAzUQsADiwK?=
 =?us-ascii?Q?zKyc8tnlAuSmzjpVkpVGE1rOJELT+Y3bvH4Zq+c5ZAczChm0yOdHwNOskah5?=
 =?us-ascii?Q?XDLpihzVwM6F81qFdyC5R1mwtzhrW+M+K+m1xi8Sk4mat2Jul+cuT7pTga44?=
 =?us-ascii?Q?jTvHWEfl52MxFMKCcNZFWlJp/pZxQudamChQk2qT3Wtf7cSxmw3k4HZpxNK1?=
 =?us-ascii?Q?I6K91sfg/fAuVryuh2YzUzhYBMIp6ZF7J/cgxiYcQjzv2meARAbNv8qZymaF?=
 =?us-ascii?Q?Ms8K+8Ek7noXxob/eIqFvfHo6/Gg/nAzjJJ5HIGKZ909d6wPcwaZnrkzn0wS?=
 =?us-ascii?Q?P0NyyR6zi27tCDfZHhpU8OCPjiSfUO7ap7OMY3oCaodBkdxFaNf0aVQaHh6k?=
 =?us-ascii?Q?oyxLbtvHq8g4qm7aSQsNK9BLCwVwv3erW6X/ScmU2CsYAsQuSNum4xhJrT51?=
 =?us-ascii?Q?g7oNWoTgwIBLUoCxN9yxgzSDwzjRHOTd5Vhzkoz0CsGlAsGm7yVdk+yKXOnP?=
 =?us-ascii?Q?+rVUIjXfure/IBCJPg+xDInH?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7dcff968-f5f4-477c-31e2-08d97957e6f9
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB3573.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 21:21:09.7370
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 7o1GAQobSH6WkMcm0R95s3fVwAvTLhSbK0tWD5iAdbd9VoU0iyuKOnBwfiGkQdX0t+JRvB7lVYcVlJypqMnZ2f1ZsnnuWVbEWOjXNXgwScM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2935
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10109 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0
 mlxlogscore=999 suspectscore=0 spamscore=0 bulkscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001
 definitions=main-2109160122
X-Proofpoint-GUID: ToCXx3IM1C9QwO4wlMgkY7hWgsea6WZu
X-Proofpoint-ORIG-GUID: ToCXx3IM1C9QwO4wlMgkY7hWgsea6WZu
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

For vhost workers we use the kthread API which inherit's its values from
and checks against the kthreadd thread. This results in cgroups v2 not
working and the wrong RLIMITs being checked. This patch has us use the
kernel_copy_process function which will inherit its values/checks from the
thread that owns the device.

Note this patch converts us. The next patch will remove the code that is
no longer needed.

Signed-off-by: Mike Christie <michael.christie@oracle.com>
---
 drivers/vhost/vhost.c | 49 +++++++++++++++++++++++++++----------------
 drivers/vhost/vhost.h |  7 ++++++-
 2 files changed, 37 insertions(+), 19 deletions(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index c9a1f706989c..6e58417b13fc 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -344,17 +344,14 @@ static void vhost_vq_reset(struct vhost_dev *dev,
 static int vhost_worker(void *data)
 {
 	struct vhost_worker *worker = data;
-	struct vhost_dev *dev = worker->dev;
 	struct vhost_work *work, *work_next;
 	struct llist_node *node;
 
-	kthread_use_mm(dev->mm);
-
 	for (;;) {
 		/* mb paired w/ kthread_stop */
 		set_current_state(TASK_INTERRUPTIBLE);
 
-		if (kthread_should_stop()) {
+		if (test_bit(VHOST_WORKER_FLAG_STOP, &worker->flags)) {
 			__set_current_state(TASK_RUNNING);
 			break;
 		}
@@ -376,8 +373,9 @@ static int vhost_worker(void *data)
 				schedule();
 		}
 	}
-	kthread_unuse_mm(dev->mm);
-	return 0;
+
+	complete(worker->exit_done);
+	do_exit(0);
 }
 
 static void vhost_vq_free_iovecs(struct vhost_virtqueue *vq)
@@ -579,6 +577,16 @@ static void vhost_detach_mm(struct vhost_dev *dev)
 	dev->mm = NULL;
 }
 
+static void vhost_worker_stop(struct vhost_worker *worker)
+{
+	DECLARE_COMPLETION_ONSTACK(exit_done);
+
+	worker->exit_done = &exit_done;
+	set_bit(VHOST_WORKER_FLAG_STOP, &worker->flags);
+	wake_up_process(worker->task);
+	wait_for_completion(worker->exit_done);
+}
+
 static void vhost_worker_free(struct vhost_dev *dev)
 {
 	struct vhost_worker *worker = dev->worker;
@@ -588,14 +596,16 @@ static void vhost_worker_free(struct vhost_dev *dev)
 
 	dev->worker = NULL;
 	WARN_ON(!llist_empty(&worker->work_list));
-	kthread_stop(worker->task);
+	vhost_worker_stop(worker);
 	kfree(worker);
 }
 
 static int vhost_worker_create(struct vhost_dev *dev)
 {
+	DECLARE_COMPLETION_ONSTACK(start_done);
 	struct vhost_worker *worker;
 	struct task_struct *task;
+	char buf[TASK_COMM_LEN];
 	int ret;
 
 	worker = kzalloc(sizeof(*worker), GFP_KERNEL_ACCOUNT);
@@ -603,27 +613,30 @@ static int vhost_worker_create(struct vhost_dev *dev)
 		return -ENOMEM;
 
 	dev->worker = worker;
-	worker->dev = dev;
 	worker->kcov_handle = kcov_common_handle();
 	init_llist_head(&worker->work_list);
 
-	task = kthread_create(vhost_worker, worker, "vhost-%d", current->pid);
-	if (IS_ERR(task)) {
-		ret = PTR_ERR(task);
+	/*
+	 * vhost used to use the kthread API which ignores all signals by
+	 * default and the drivers expect this behavior. So we do not want to
+	 * ineherit the parent's signal handlers and set our worker to ignore
+	 * everything below.
+	 */
+	task = kernel_copy_process(vhost_worker, worker, NUMA_NO_NODE,
+				   CLONE_FS|CLONE_CLEAR_SIGHAND, 0, 1);
+	if (IS_ERR(task))
 		goto free_worker;
-	}
 
 	worker->task = task;
-	wake_up_process(task); /* avoid contributing to loadavg */
 
-	ret = vhost_attach_cgroups(dev);
-	if (ret)
-		goto stop_worker;
+	snprintf(buf, sizeof(buf), "vhost-%d", current->pid);
+	set_task_comm(task, buf);
+
+	ignore_signals(task);
 
+	wake_up_new_task(task);
 	return 0;
 
-stop_worker:
-	kthread_stop(worker->task);
 free_worker:
 	kfree(worker);
 	dev->worker = NULL;
diff --git a/drivers/vhost/vhost.h b/drivers/vhost/vhost.h
index 102ce25e4e13..09748694cb66 100644
--- a/drivers/vhost/vhost.h
+++ b/drivers/vhost/vhost.h
@@ -25,11 +25,16 @@ struct vhost_work {
 	unsigned long		flags;
 };
 
+enum {
+	VHOST_WORKER_FLAG_STOP,
+};
+
 struct vhost_worker {
 	struct task_struct	*task;
+	struct completion	*exit_done;
 	struct llist_head	work_list;
-	struct vhost_dev	*dev;
 	u64			kcov_handle;
+	unsigned long		flags;
 };
 
 /* Poll a file (eventfd or socket) */
-- 
2.25.1