Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Fri, 16 Nov 2001 17:44:43 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Fri, 16 Nov 2001 17:44:34 -0500 Received: from hera.cwi.nl ([192.16.191.8]:29574 "EHLO hera.cwi.nl") by vger.kernel.org with ESMTP id ; Fri, 16 Nov 2001 17:44:14 -0500 From: Andries.Brouwer@cwi.nl Date: Fri, 16 Nov 2001 22:44:00 GMT Message-Id: To: pavel@suse.cz, zwane@linux.realnet.co.sz Subject: Re: [PATCH] trivial patch to support for "ACPI" keys in pc_keyb.c Cc: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Nov 2001, Pavel Machek wrote: > These keys are common on recent keyboards so I'd vote for adding this. And Zwane Mwaikambo answered and asked: Do these keys correspond to the correct ones on your keyboards? I still have to come across a keyboard which has these keys but different scancodes. But i think i'm beating a dead horse ;) My collection of scancode data can be found at http://www.win.tue.nl/~aeb/linux/kbd/scancodes.html In particular you see at http://www.win.tue.nl/~aeb/linux/kbd/scancodes-1.html#ss1.9 that having power saving keys with scancodes e0 followed by 5e/5f/63 is a Microsoft standard. Every modern keyboard that has power saving keys has them with these scancodes. So, I have no real objections against your patch. (On the other hand, this is an area that is perhaps best regarded as frozen. Changes just to avoid the trouble of a setkeycodes call should perhaps be postponed.) Andries - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/