Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] xen/x86: fix PV trap handling on secondary processors
To:     Jan Beulich <jbeulich@suse.com>, Juergen Gross <jgross@suse.com>
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
References: <34898e9c-5883-a978-98ee-b81b22d8caed@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
Message-ID: <823f4ef4-f9e5-68cb-d6e9-d079483c1e21@oracle.com>
Date:   Thu, 16 Sep 2021 21:34:46 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.14.0
In-Reply-To: <34898e9c-5883-a978-98ee-b81b22d8caed@suse.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXI0ZGZGbUZNRWtXQlhkNnVSNldRVGY1NFVFZUppZmdlU0RFbmE5bnpLM3Zv?=
 =?utf-8?B?ODFWS3dNZThDRzdraldpekVOZk4rUWVRdjRsQlp2RkNtQVcxYVhoUm5JeFBB?=
 =?utf-8?B?RkFnbndwVHdMbjNmbm5hZGlFS0FhV3pXRVFKbVNHbDg2ZEdIU2dCOGdJM2xN?=
 =?utf-8?B?TGRsWDFyQjh3RVErS3VMZ1RlbmVFdEFPeEJramFXN0NjTjVCRGFObVErQnhK?=
 =?utf-8?B?blhMYVd5eG9hNS9tazRXMEpKcnAyTnpuRDIxMWo2Mmp1dE5QWXdicnZUUEtJ?=
 =?utf-8?B?RjZra2poQkdaYXdweXZTSU00NXNORXkwOWlESXRjSURhcGJ6N1BHdTJrZU8r?=
 =?utf-8?B?QllRRGpEUTNnNWc5YTZpNE9kUE1QOEtCUEtxVVRXWEVNUkcyNml5UE1LUndQ?=
 =?utf-8?B?aExGRXFlNk4yY0xIVkxSdkc3ZUxjUis0WkhoNFpVRDVsWjNFSFNWaVIrOXVO?=
 =?utf-8?B?d3JmN2IrSk9BNUNDakgyaE8rNERnc1Q3dmphUWpkTTI4VzhkTkVXMTdrSmFl?=
 =?utf-8?B?cG9yRkdKcVdRU3lpSzJYaDQvM3o5anorL2ExSVYweDhtRlE1TUVFZnhJWmhQ?=
 =?utf-8?B?UGVjaXJxRnM3Z2xJcWUwZC9pWWQxK2RPaE1CRUZYYldnSjFuN3VVYWl3emlL?=
 =?utf-8?B?SVNjREpPNHNoNS9zVnF6V0RSTXVVbklRWERRcjRSLzlRZk9jUFl5Zll2b2lC?=
 =?utf-8?B?emdkbWdXZWdVMlRZYXJ0cmN1MjdrL3NkaWRlSno2emtjTERGYWIvdTZvY0NH?=
 =?utf-8?B?TVZwUHhpaklKMEpoVGRMRWhxYUlWRitSU1dtUzVaMnF2aWN5bU5mcEN5eWJG?=
 =?utf-8?B?NExSVjNBeFBSbzVQVlh6ODFHZWhLMEh0Sk5qcU1qdFAra1pVd0NTcG4va3Vp?=
 =?utf-8?B?SnF0SGtWa21YWm5PZUUrUzlyTVYyM1QreGVMeVc0YkNjbUhNb2x0dUw3Q29N?=
 =?utf-8?B?R3V4UG5RSUNMSUtUeTFuT2o4UWxMU0FEdWF3MVZjNjZqeWNXODNnbForNXlQ?=
 =?utf-8?B?alh5MUdlMGZGRTZUaDc4cWNqa1cyUWlMOE1uNnRjMy84M3FCY0RMSmtJZjhy?=
 =?utf-8?B?N1I2WFZCR3BaQkFPZXRiT3BDRU93L21xRzEwRUpsT0JpVUZOZkJxenpWTnVF?=
 =?utf-8?B?UUZ2bi85ak9JVlowc3ZiU1NFRUc0eVJqZURBUGYwM3BXRHdhRVorOSsvS0VG?=
 =?utf-8?B?V2lYWTJoY01FNGM4RXZpM0NkdmcvV0lZeFJ2SnlveHNlRENqb2haY1lhRDFw?=
 =?utf-8?B?QjAyWkRpYWFUejcrOFBBMXUvTmxYMEczZ1l5eUlZeXZ1U0tXNXFJTUY5ajVj?=
 =?utf-8?B?QTdKMkZKRjIybHhWMjloNUlVbDU1K01LQ2ZQWHJVbEs5bVJ1WDZlWElDWmZS?=
 =?utf-8?B?VFVQV3p2ZVFSS0FWWk9HY05jWEpDcktIMWZtSWhsMmxKVGd0S1dlckVwZ012?=
 =?utf-8?B?cE1YVTNJZzRJMVExZlpyUHRRMU5xcFhTMTRoOVhCV1VNLzNHaXNGcWRxbTN5?=
 =?utf-8?B?SS9nV01RR0tqTnhkd0hKeDF4OFB4Y2hJemFFckJScUJvdXU0TnNRWUlkRVN4?=
 =?utf-8?B?c0g4bys0MU84S0VCWnJtN1RVa08rVTZwSkJHNGRJK2pnV3REM3gvQyt4L1R5?=
 =?utf-8?B?WThOOENBZmdieG9pRzF1Q0o0cit4aFZTc2tkQW9PUUVnbjNTOG9NN09jclha?=
 =?utf-8?B?Q3pMbVZPOHc5VUdrNU5IbjRPQXlCTlgwM0thTmdrOG5SQ0doajhRL2UyRWhN?=
 =?utf-8?Q?b3cqGdbMAu0JOJpuXym5mf7FUAnPpc89a35/gZm?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4f6588c-cc38-4330-8580-08d9797b5737
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2021 01:34:50.2971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 5VDwvB/jq5c6PXezWaF6Ad72HqmYdRu9wBn5PEW7AStnjADhhnuOxwlvy0Bkf1szHS8lQAeNkEX+/ZnyGFb1Mj6AM36sl0VfepUZltOi0P0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4192
X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10109 signatures=668682
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 spamscore=0 phishscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2109030001 definitions=main-2109170007
X-Proofpoint-ORIG-GUID: GhWPyo4Tx_KQtWfNAsjXhmxVIymFwbxN
X-Proofpoint-GUID: GhWPyo4Tx_KQtWfNAsjXhmxVIymFwbxN
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 9/16/21 11:04 AM, Jan Beulich wrote:
>  {
>  	const struct desc_ptr *desc = this_cpu_ptr(&idt_desc);
> +	unsigned i, count = (desc->size + 1) / sizeof(gate_desc);
>  
> -	xen_convert_trap_info(desc, traps);


Can you instead add a boolean parameter to xen_convert_trap_info() to indicate whether to skip empty entries? That will avoid (almost) duplicating the code.


-boris


> +	BUG_ON(count > 256);
> +
> +	for (i = 0; i < count; ++i) {
> +		const gate_desc *entry = (gate_desc *)desc->address + i;
> +
> +		cvt_gate_to_trap(i, entry, &traps[i]);
> +	}
>  }
>  
>  /* Load a new IDT into Xen.  In principle this can be per-CPU, so we
>