Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] drm/qxl: Add qxl dma fence release function
To:     Gerd Hoffmann <kraxel@redhat.com>
Cc:     Dave Airlie <airlied@redhat.com>,
        virtualization@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
References: <20210914062352.6102-1-maobibo@loongson.cn>
 <20210914062352.6102-2-maobibo@loongson.cn>
 <20210915063835.36bhpadzbzuj7shw@sirius.home.kraxel.org>
From:   maobibo <maobibo@loongson.cn>
Message-ID: <42a70a29-3ecb-7f41-f4e2-378cf3f6939c@loongson.cn>
Date:   Fri, 17 Sep 2021 09:36:37 +0800
User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20210915063835.36bhpadzbzuj7shw@sirius.home.kraxel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 09/15/2021 02:38 PM, Gerd Hoffmann wrote:
> On Tue, Sep 14, 2021 at 02:23:52AM -0400, bibo mao wrote:
>> Add qxl dma fence release function, previously default dma fence
>> release function is used, and fence pointer is used to free 
>> the memory. With this patch, actual qxl release pointer is used
>> to free memory, so that dma fence can put at any place of 
>> struct qxl_release.
> 
> Why?  Is there a problem with struct dma_fence being the first
> element of struct qxl_release?
Yes, there is no problem put it in the first element of struct qxl_release. This patch has no actual use,it is only more flexible. And you can discard this patch if other graphics drivers do the same thing like this.

regards
bibo,mao
> 
> take care,
>   Gerd
>